Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp5041846rdb; Sat, 30 Dec 2023 03:44:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHobzivV14Eit452/6gA5seQy1CsNlRvZ+3GI9IekWageU1BiVCABM4bsmNuzwfY72OHAqY X-Received: by 2002:a17:903:2351:b0:1d4:ae5c:c3a with SMTP id c17-20020a170903235100b001d4ae5c0c3amr137181plh.114.1703936647061; Sat, 30 Dec 2023 03:44:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703936647; cv=none; d=google.com; s=arc-20160816; b=Q6QgYDiNVfITanwf4avYl+3hh7kjSZoorw7b+0moCcUdvS+IRP9rEGiGm/HOd4OiXm 209SHOSouoB/lkXAdkA4quIs/cJlK0VKOuJzZebIvv7tEkZ2izubSnAmH8eFy9yCekwk vNCpZ14cM1Xg3ChP2GwYHxhUNWrQgdMoOvAk8lXOQhfdB2c6Dgfcdjy/Dv8dhd8p2A3G vr3h+DIYonT9/il/jyyCTRNZyEpVnGQ3cyaB/9iXd9cb/cjhMLZZz9n0Xg6ZP9GvKdQm eetnj6R2ceaFEK9uH4i7nNK0rGRe/8FVLJDTiHe17uu5Yn2GnDb6vgV3UmqnSjEjj/SW q/1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:feedback-id:dkim-signature:dkim-signature; bh=RDMzNXeoRcXtTozgalvQ1v7S9gcCF0W/23GWD67Yelg=; fh=67agiwVtf7SL9Lp1G76jZqUs0lhG35+jEmQRT9JnphI=; b=SkQHzRptazSbagIFXnYh9AwyqH3o5nGws+eJuKcn/iVb6Cy5cNs0WQVmuvL86/n8+5 0pcJO1h0p9iJo1oU77bT4idRHua1IopUgiDR4UUmSMep8s+EQj+3ZBnbDKGrC1UMMfvr gdEsgTLyEAmluWJsU1f2Db8zW5ou6OPphGpgyiKDYQjievlbrrGGE4MncWi2eYVBu+L4 omMlwEcGb2r3//w1vDC2bW7aFvnrQexCBcb1HE8T0B2RdyCazpA7cWFjM4P6+wU3cE1j 1KJ+Xyj1DybZNrZfC0rrZzztU5NJR7fWyTD3TuG9zkvCyA92Z/Yb1LB/mg47QdSZZ2SG V6Sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kroah.com header.s=fm2 header.b=rtItvV3f; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=ZhOK0LBZ; spf=pass (google.com: domain of linux-kernel+bounces-13407-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13407-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kroah.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id iw19-20020a170903045300b001d3aa228957si15887377plb.30.2023.12.30.03.44.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Dec 2023 03:44:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13407-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kroah.com header.s=fm2 header.b=rtItvV3f; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=ZhOK0LBZ; spf=pass (google.com: domain of linux-kernel+bounces-13407-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13407-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kroah.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D04EEB2154E for ; Sat, 30 Dec 2023 11:44:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7D73779E0; Sat, 30 Dec 2023 11:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="rtItvV3f"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ZhOK0LBZ" X-Original-To: linux-kernel@vger.kernel.org Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF8DC79CD; Sat, 30 Dec 2023 11:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kroah.com Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id D6BA85C0075; Sat, 30 Dec 2023 06:43:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 30 Dec 2023 06:43:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1703936628; x=1704023028; bh=RDMzNXeoRc XtTozgalvQ1v7S9gcCF0W/23GWD67Yelg=; b=rtItvV3fct9Ah3tKmTbcAT+uro /8gumEOF30bzbKOqwjqcRllVZmBQPkn99DlIR0/NHH1R8jkAjhlFp3/ncXdGdj3l A/6p1FANm2O5UE+zY60kaaUmMARtGeDgayCODji3pDdCso1b5qslEOQaZP88+24z Z0BkybZk7MfkpKuSCwzrc2ZhPG0CsAhZKdkqWK4XmnpqBYeLZRo2cOfVvBxTnfOK lfBo8HKZ4vteixcWMTmzZBlOzot3xWnBetFYT6pX4hBvT2N/i90/N7WlIlUtkdZb oj+GjB7lShuyQQtRCm4Uu9c4eebrxMSNrP8/SW32slFyozjYdGxSA9uJddfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703936628; x=1704023028; bh=RDMzNXeoRcXtTozgalvQ1v7S9gcC F0W/23GWD67Yelg=; b=ZhOK0LBZRGNZxTF7TQ9YpCn1UYZkqTyTW0WKhBC2Av8V zqhUAaCDhEMWP0uaRG2+RmIE+Ra/FAFT8esGtklM92Xdn5DMK4TP7KyGJb9AyHUd BfeFUwSigl/+srUQB0/VKpOWj92YJZpQRf5Ih2allHdvToJBONXrBy5OoNcajo8l siWvQw1tjOVNRPXoV1vJkoS2w1zWja8su73SkjyI90/iqFAdLaG3b5h3Tg8zAxsf 0XDDpx2/urcS5xv8hTtKiB+8ONfejWGyvgEeDdfuYUadt0BzY5r5zXwazhxCEYyD 3W3+xodNudClje4KKFMmowDaMNVMxaGWPLQpA+HP3Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdefhedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepheegvd evvdeljeeugfdtudduhfekledtiefhveejkeejuefhtdeufefhgfehkeetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 30 Dec 2023 06:43:47 -0500 (EST) Date: Sat, 30 Dec 2023 11:43:46 +0000 From: Greg KH To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, zhangpeng.00@bytedance.com, stable@vger.kernel.org Subject: Re: [PATCH 6.6.y] maple_tree: do not preallocate nodes for slot stores Message-ID: <2023123027-baffling-arise-63bf@gregkh> References: <20231212195255.219624-1-sidhartha.kumar@oracle.com> <2023121847-cope-surviving-26bf@gregkh> <19b88718-a1e6-d699-f056-cf00b1b75346@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19b88718-a1e6-d699-f056-cf00b1b75346@oracle.com> On Mon, Dec 18, 2023 at 09:53:53AM -0800, Sidhartha Kumar wrote: > On 12/18/23 2:59 AM, Greg KH wrote: > > On Tue, Dec 12, 2023 at 11:52:55AM -0800, Sidhartha Kumar wrote: > > > mas_preallocate() defaults to requesting 1 node for preallocation and then > > > ,depending on the type of store, will update the request variable. There > > > isn't a check for a slot store type, so slot stores are preallocating the > > > default 1 node. Slot stores do not require any additional nodes, so add a > > > check for the slot store case that will bypass node_count_gfp(). Update > > > the tests to reflect that slot stores do not require allocations. > > > > > > User visible effects of this bug include increased memory usage from the > > > unneeded node that was allocated. > > > > > > Fixes: 0b8bb544b1a7 ("maple_tree: update mas_preallocate() testing") > > > Cc: # 6.6+ > > > Signed-off-by: Sidhartha Kumar > > > --- > > > This is a modified backport as the patch to fix this in upstream does not > > > apply to 6.6 because the node_end field was moved from the ma_wr_state to > > > the ma_state after 6.6. > > > > What is the git commit id of this change in Linus's tree? > > The patch is in akpm's mm-hotfixes-unstable tree and has not made it to > Linus's tree yet. Ok, please resend when it hits Linus's tree.