Received-SPF: pass (google.com: domain of linux-kernel+bounces-13434-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <a3825ab2-8987-4b85-9db0-642035789c49@web.de>
Date: Sat, 30 Dec 2023 14:36:37 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: scsi: ses: Move a label in ses_enclosure_data_process()
Content-Language: en-GB
To: James Bottomley <jejb@linux.ibm.com>, linux-scsi@vger.kernel.org,
 kernel-janitors@vger.kernel.org,
 "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>
References: <4616e325-e313-4078-9788-dd1e6e51b9e0@web.de>
 <9d24844f30604f969ac10da456801f594ce72f2d.camel@linux.ibm.com>
 <b65afa15-41e6-4d71-87bd-39fd688fa551@web.de>
 <a35c6128d4449fec00238c909e5f6f45ebf4bcba.camel@linux.ibm.com>
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <a35c6128d4449fec00238c909e5f6f45ebf4bcba.camel@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:5UJyCjxbrcU=;r9spU924Fg/pPKmxs3Ci3gKTuYI
 xGLm3pAms5++4J9TkEM6sJfydLA9VEB+9656vNRU9/8NBpTfZxNDx98fpHVWQsNfkuT5wRc33
 pIJfN6WfhjHiY4UvknKfnCzIekPFv6vB0S4ubIw8uTa5SxGCMgkWazz5jJAVTKb5AUZ9Qolqo
 kGCLMjd7iBHQwkg6ygYMcbrk0vEL1/B+5eb88uQBpefMVt6HX5SkpIE51BS8mfEBXu10i7mb+
 zNknBW11nKH1ENTXeIe4wVZkfYcM1fcTxUt5It31OOfO11Q2n3fI4jPhJtZm+zJjjErKYsIWZ
 +LOpsa4FGrkzuO5Gvqez0EJOt0ou3pbbUlLG9cr5stNCPZfdmScr6AXKq0wkuBlzCB/xDxE+B
 w+QxsTNxGdDA2tGZfVzHoQBX/5meG+1bST4BU8Pyq05XtmzGCLL8CfuES53YRrtIfJ3D/giFg
 LVS/UBAoh8uyjLUsWU0JvBsSW8UDI4t7Zm2COiNU+XaLFaWMQaGKqO8CXltW0QcTm7MBDr5h/
 b1SiUOUsZ4NsaFmCEjgqScPxRqk14vf2I1YThZtV70didVMEGeDMM1FwNzXW6ZTHOQZRepqEm
 uCpwR7Kgvrfn/8c8vja0Xd20vf3cu1vG7EEj9/tm8U/Dj0iOItPayS4L0NZZWdzNt9mHAEqlZ
 NgfSYleHa4ZQnlz+U7NvEXK4iXTx2yjxLPDvfqgad1uWXbWVjAMhuJvQ7c4DvSvn0/mBWPfPt
 jkMMZPB1COd5z59TgkcvJBB2ruX/fmBRPVv+xDOC5om6n5oSG0gyT/HjpCW3nFhZtOaLt2rZS
 yoaEgmiGcLxGY13/EhuNB53ZhYzsJAcyavPa3gkWyAjSfcmkP9T26VggqYuOkVMuIl0hhowsk
 fsdS/qmRjECDvAEl0OmOjNFTek6lnvBPBnMcXIZf/feNwnZlC6e/L0T0r6ynQhNqDD1++Bnjg
 Ktt6rjoej662cV58CUI9P7lY7t0=

>> You probably know some advices from another information source.
>>
>> https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a=
+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+reso=
urces
>>
>
> Yes, but it's about using staged deallocation at the end of the
> function instead of in the if loops.  That's to *simplify* the exit
> chain and make the error legs less error prone because the teardown
> isn't repeated in if bodies.  It has no bearing on what you just tried
> to do.

I got the impression that there is a general conflict involved
according to different programming styles.


>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 If coccinelle
>>> suddenly thinks this is a problem, it's coccinelle that needs
>>> fixing.
>>
>> This software tool can help to point source code places out for
>> further considerations. The search patterns are evolving accordingly.
>
> The pattern is wrong because kfree(NULL) exists as a teardown simplifica=
tion.

It might be convenient to view in this way.

If you would dare to follow advice from goto chains in a strict way,
I imagine that you can tend to stress the attention for more useful
data processing a bit more than such a redundant function call.

Regards,
Markus