Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753180AbXLKMgi (ORCPT ); Tue, 11 Dec 2007 07:36:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751728AbXLKMg3 (ORCPT ); Tue, 11 Dec 2007 07:36:29 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:3073 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751387AbXLKMg2 (ORCPT ); Tue, 11 Dec 2007 07:36:28 -0500 From: Herbert Xu To: davem@davemloft.net (David Miller) Subject: Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action. Cc: joonwpark81@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Organization: Core In-Reply-To: <20071211.023218.31965443.davem@davemloft.net> X-Newsgroups: apana.lists.os.linux.kernel,apana.lists.os.linux.netdev User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.6.17-rc4 (i686)) Message-Id: Date: Tue, 11 Dec 2007 20:36:21 +0800 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 24 David Miller wrote: > > How can the NAPI_STATE_SCHED bit be cleared externally yet we take > this list_move_tail() code path? His driver is probably buggy. When we had two drivers beginning with e100 we often forgot to apply fixes to the both of them. Now that we have three it's even more confusing. I just checked and indeed e1000e seems to be missing the NAPI fix that was applied to e1000. Of course it doesn't rule out the possibility of another NAPI bug in e1000. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/