Received-SPF: pass (google.com: domain of linux-kernel+bounces-13769-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d250255b-fd88-4ea9-aa08-bc8d911143af@web.de>
Date: Sun, 31 Dec 2023 18:48:11 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: =?UTF-8?Q?=5BPATCH_4/4=5D_netlink=3A_Move_an_assignment_for_the_var?=
 =?UTF-8?B?aWFibGUg4oCcY2JfbXV0ZXjigJ0gaW4gX19uZXRsaW5rX2tlcm5lbF9jcmVhdGUo?=
 =?UTF-8?Q?=29?=
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
To: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
 Anjali Kulkarni <anjali.k.kulkarni@oracle.com>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Kuniyuki Iwashima <kuniyu@amazon.com>,
 Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
References: <90679f69-951c-47b3-b86f-75fd9fde3da3@web.de>
In-Reply-To: <90679f69-951c-47b3-b86f-75fd9fde3da3@web.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:04G/Mo8NypI=;ESAuPWEakwRUjaQfehxGcf2D2Vk
 3begh/m05m7c7+oZ4sh68mPFNhtQV1WG3aXHBMfTiv6JHCFqLkIwgSXzkpBm1oyCduIuLH6Jt
 +RHlWub3yeOHJ+cnTpUgj8r6re7OlKfr8yIXsO1+LiCAfGswpSECXu4q24rItiEKrviaWiCmi
 rBctdCqP+1Tm7KXDuuPITAy4IAjZC8HNeFgei+mRISl0ISooRsM/Oan96iXML6L2JVPjbGicJ
 jJ8OZB0Ucu7qLn+fpZFk7lFLW7BVVQhACxwkt6X8vwewY0FdoNBfkTIv8l7oAfR6AWfkfwHYC
 2R/Gf4fHyQ74lYM/KhjX1UTkStDhT1xx2PdBRRp9q4MPh4eJqgFkK2xoxAsdT8vvYqRwbFCM4
 fGLgt3SjMhjIjRiawzhEowB9ppvNmVuilooi9Wx6dWmT/uVcM+Xq9Rdyi2MA8knPprmezd/tZ
 ZjLC5NN4HeRPNBHf+UNRyv50+VSu4zMLC0BA/1FP0YazhDq1bVqqdebrp/RWwS/+ZOqihCTfG
 rhqhxDd5Tlw1iaoab1lfRpGh+F7d/UVSOpmUn+uM02IeAyMQoo92tZnSBxqFw9LV9PsczX2nL
 QTuEbqxrpn1ukn3H+ezUgh28yIwAb4LPzbSPGz8HKEkQHiEQHf8ElH5aZjYIaISl8blcILsBF
 MFoKSztGoIszzodIQDENpVvaM4qTB8sV1cL+WfPMchmJTWCzcH/uh7DB7+kGzQ/CCWFqmjYSG
 qGvOdD5BvC9v8Izin4IH4gDkEAfsqBGsoYx7qOL8NvJL8RpeW4UPDHHERTaLFfnPh+u8XYZPg
 4LyCEOPqQbJ0cBIdCtDAx878ohZN8Q3iCtutSUC7WeZVI8Si4B9so9a8lmJ3aBdRoZsDQYQN7
 URNGLtvS9OtyAIxWXBY5s0rmEfmKB+IsEonZUoAWa5nOOtcQAlVGUF8uwnXOZIYytPsofO7Rh
 lnxJBJALSR7ayDmPgtuLX5qr3Ro=

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 31 Dec 2023 18:16:26 +0100

Move one assignment for the variable =E2=80=9Ccb_mutex=E2=80=9D closer to =
the place
where this pointer is used.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 net/netlink/af_netlink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index cfddc9c6a376..12a0b6f8be19 100644
=2D-- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2019,7 +2019,7 @@ __netlink_kernel_create(struct net *net, int unit, s=
truct module *module,
 	struct sock *sk;
 	struct netlink_sock *nlk;
 	struct listeners *listeners;
-	struct mutex *cb_mutex =3D cfg ? cfg->cb_mutex : NULL;
+	struct mutex *cb_mutex; /* Serialize data processing with callbacks */
 	unsigned int groups;

 	BUG_ON(!nl_table);
@@ -2030,6 +2030,7 @@ __netlink_kernel_create(struct net *net, int unit, s=
truct module *module,
 	if (sock_create_lite(PF_NETLINK, SOCK_DGRAM, unit, &sock))
 		return NULL;

+	cb_mutex =3D (cfg ? cfg->cb_mutex : NULL);
 	if (__netlink_create(net, sock, cb_mutex, unit, 1) < 0)
 		goto out_sock_release_nosk;

=2D-
2.43.0