Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp5731802rdb; Sun, 31 Dec 2023 14:44:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFkLsEyvtLHxiqzYZy6m52prV3p6JGmD8HMA5xO+fhUtbCh+mh3f2oshCTTA6NI7YPEXj4o X-Received: by 2002:a17:90a:f98d:b0:28c:843c:105b with SMTP id cq13-20020a17090af98d00b0028c843c105bmr3465499pjb.27.1704062694997; Sun, 31 Dec 2023 14:44:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704062694; cv=none; d=google.com; s=arc-20160816; b=fYkfmNMAmY9PVVPoSRNd3cYukbIa/oYCAjJr+B1VG663H3RE6OFtPcjAZ5Qka5RNcF wh/+nxqHmxaOjw8UtOO0zd9+GccYAplFJXJZuW+ik1xascdAYT00nxsCNzFNdegFio3h RPo5X2i0zYdPrRCYbR0sMIKis6Jr+zY4a0+HrA/pJz8BSdfU4mRHSzgHB7TUmJo6NOmo Uv4vqd3PsJG5dsOVkBk1dzqXvV2YmVdOhriYC2P49rlMzPKikQ19q/8oKde4EI6zGSEU EewrF8kOepgEzZ/Ey1CRDXk7+sfLYu7Op7R99SuE6Nm/UQd0lWK0b0XmTnPMhWtLAlNv jg7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=RGJrf2qGjaqs2Gg0g2FguVq8u9ZcCJz+T1LvcJxj27A=; fh=NHfGaOh14kJB/ByaelmSpejnnVdTMVu1BqwvGoh3FbU=; b=pdl4UZCspVPZMrSGOPyFikFiloN6typLOngH4ZuA8fqYdJUJad8rxxb9ycA9JAkIqi oqRNowdjWzb6VOjjFq63A1M10S6GTKeAYHYrT20KAQAsJXTNc5KgkhW+IFbY852yoxc2 fAVE7zzrOKNbtlttTn4DmIZixFgQ7ycucDFldCdv18ZTqmxU2eQw4dGVsEkh4LUkBerv +EQGK0EbQ2zm9WlLCq4dcSV3oWDhF0nFOdmB4wbsqNYUBNuxyDJCArFHSK3G5Yu4CXHT APfhl6IG/kBSyEqSXPDQQvDh8ORh19h/icjykhKGOhiqapsYFSZSTlvJ1ZSeI+hQwiGO 7wmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20230601.gappssmtp.com header.s=20230601 header.b=sW0MsEYO; spf=pass (google.com: domain of linux-kernel+bounces-13800-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13800-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=networkplumber.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id pc14-20020a17090b3b8e00b0028cd234e938si463122pjb.61.2023.12.31.14.44.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Dec 2023 14:44:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13800-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20230601.gappssmtp.com header.s=20230601 header.b=sW0MsEYO; spf=pass (google.com: domain of linux-kernel+bounces-13800-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13800-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=networkplumber.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 09FF1B21AE9 for ; Sun, 31 Dec 2023 22:44:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B01BDC8F7; Sun, 31 Dec 2023 22:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="sW0MsEYO" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AA04C13B for ; Sun, 31 Dec 2023 22:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-28cc07d8876so212584a91.1 for ; Sun, 31 Dec 2023 14:44:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1704062664; x=1704667464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=RGJrf2qGjaqs2Gg0g2FguVq8u9ZcCJz+T1LvcJxj27A=; b=sW0MsEYOZ1iWtS9nk6L7vDOflUK+a0mm4mvPEmAO/Yr/ZipkIh99jfiwUWNZOZDjCs bxYdcuijlTQRFjn+AP9zTGs0ypsaonJR2mOW0fiMZEWLp8g6SW6FaxJqaZlCW6v8bK0o TDQ1eXSltNexPM5wMLnyiTxmRHgO4UlLHdVi3Po9B9DlB5ntCA7nwUunbukafHPzLwGt nZ0n/eY35uMxyv768ninBtzgooBDz5HRo1zWw87GeYK6577d9JnbPD1ni6s2st+HyTF8 HV+p/pwvh86SdNm/EzuoRCyfzQZwrALyVjbelbESgKfIebC+BV3t0v4ifb82Wisobsto Ox8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704062664; x=1704667464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RGJrf2qGjaqs2Gg0g2FguVq8u9ZcCJz+T1LvcJxj27A=; b=ltOZAinUAVfHNhUAEJtqWAN/fqftwhlHTZH0gbqgTKPhx6Eszgb9DlcExnc+j5vUsT 0wvzf9mtaF6IBxa+d9dwMshIsZ+cLy0MOSoasOAqm0UbxOADOytHwT20KeP4PLEtPc2Q YZcCeC3T2zwu/+qvajozEn2nRgznhKxzeuCufBBuqu0/oOjm4J4eq7+0qjCHljSL7DPQ eAJS7GzHqKfWrb5gKXzgVJkY6Y0BaBYZoJGqxWEqZuSkKvbf4pplaCtGnpMt/QFXu5jd 6hcuQ0hLd1qoRSG8TNZhoAeDYKaeQUC2x55sEFdSGxes4mnstZ6Hc/oXmwlXZVy5W3e/ zQUA== X-Gm-Message-State: AOJu0YwAr6mZ0ryQS3yHNGJHm0aIzn6PBLBxF5zY/zVaRWVGueLO5Sos G6uEXpnpSTVTO4+LvNvBixwdX/8+GFk8bQ== X-Received: by 2002:aa7:920d:0:b0:6d9:e2ce:2e1f with SMTP id 13-20020aa7920d000000b006d9e2ce2e1fmr4456031pfo.31.1704062664418; Sun, 31 Dec 2023 14:44:24 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id t22-20020aa79396000000b006d9b95034d9sm12293986pfe.211.2023.12.31.14.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Dec 2023 14:44:22 -0800 (PST) Date: Sun, 31 Dec 2023 14:44:21 -0800 From: Stephen Hemminger To: Markus Elfring Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , LKML Subject: Re: [PATCH] packet: Improve exception handling in fanout_add() Message-ID: <20231231144421.13ba1d04@hermes.local> In-Reply-To: <828bb442-29d0-4bb8-b90d-f200bdd4faf6@web.de> References: <828bb442-29d0-4bb8-b90d-f200bdd4faf6@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 31 Dec 2023 16:39:02 +0100 Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 31 Dec 2023 16:30:51 +0100 > > The kfree() function was called in some cases by the fanout_add() function > even if the passed variable contained a null pointer. > This issue was detected by using the Coccinelle software. > > Thus use another label. > > Signed-off-by: Markus Elfring NAK kfree of null is perfectly fine. There is no need for this patch.