Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp5800330rdb; Sun, 31 Dec 2023 18:28:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFmwfMZc0Vt0hPYGbpZQLQYj/eb7ThDK6SalWQefb0+M0BtUR/pBssclL0MOig3P1SZ72qK X-Received: by 2002:a5e:a80a:0:b0:7ba:95fc:5dd0 with SMTP id c10-20020a5ea80a000000b007ba95fc5dd0mr20039030ioa.18.1704076106073; Sun, 31 Dec 2023 18:28:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704076106; cv=none; d=google.com; s=arc-20160816; b=mwDE7iq+HapgJuk9Ja+v1fwuMBAzv6HpoI2wkJd5+VDTZGzLO2NDbRrlfljuMY6teC j9bJ6xNPoeCx49gE7RoLD1KHnVgO3GLQhVagIsX6Gt/2JBmCzwq3kt9euvvPIGsEiCUX 0ulM8i8wWZQc1OW7OzqoqpjC7ueg0Yl5ySCX4U5dh5ZspjIvckw/EOl2w3Hj6GN7fzla w1x8xXksH06VdYcmkxqcqX+QRa72CpNYqrqqadw5VGH30ezyo7IrtrVaZVxXYNK0ib2w 2yhg9TktG6fRpyFMWaC7TOq7v9ow0fypj6+hPZF4jxv7X99/B4q7EDxjAuyOIUTzfOs6 b84g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=H+pt6se1JI+NkS4RwpWMAbATmPk5Tyd381aU+nIBAqw=; fh=InNqzhAJOemXwQSaEaEUtSG3r8ncKJpppJyolM74hYg=; b=LJhLpBY121MvxXmXh6JViSu433BWi1Uek/jiaTdTtsiUjasWPmIHPViKihiNNd1whx qFweimRAzB38Kh/S9pZiIz50WBI17CblJeYMploi4iGNaNea3C/j+IVmC296yXZISlLY XuQWndLiR/mxbv9Mdbnk+BdEDH8X12x+SOmt2bWxRWYaZo5MRlFJV7BKRcbOm4MQ5Vgj tTD07LsVPTCZ6Mga6+7iH/W2Q3Q87BcZiA6/29ggEnC3c88URlp0zLL6Efv65vIuSLzS wamlpjf2kXIu+4I6/jy/AHgGij9BntA9085xkQons4MWvYD1DaJIYHJ3z45UecGpUjSV iyuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-13814-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13814-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id q15-20020a17090a304f00b0028bbce449fcsi21343259pjl.86.2023.12.31.18.28.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Dec 2023 18:28:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13814-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-13814-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13814-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3F391B21C06 for ; Mon, 1 Jan 2024 02:28:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 05F74817; Mon, 1 Jan 2024 02:28:16 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mail115-24.sinamail.sina.com.cn (mail115-24.sinamail.sina.com.cn [218.30.115.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31EEB7ED for ; Mon, 1 Jan 2024 02:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([113.118.70.64]) by sina.com (10.75.12.45) with ESMTP id 6592229E0000611E; Mon, 1 Jan 2024 10:25:37 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 0876431457826 X-SMAIL-UIID: C39BE61ED4F7499D81D21A62A897F6D6-20240101-102537-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [dri?] [media?] memory leak in get_sg_table Date: Mon, 1 Jan 2024 10:25:25 +0800 Message-Id: <20240101022525.2537-1-hdanton@sina.com> In-Reply-To: <0000000000009e6825060dd6c287@google.com> References: <0000000000009e6825060dd6c287@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, 31 Dec 2023 15:38:19 -0800 > HEAD commit: fbafc3e621c3 Merge tag 'for_linus' of git://git.kernel.org.. > git tree: upstream > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15e8171ae80000 #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master --- x/drivers/dma-buf/udmabuf.c +++ y/drivers/dma-buf/udmabuf.c @@ -153,7 +153,12 @@ static int begin_cpu_udmabuf(struct dma_ int ret = 0; if (!ubuf->sg) { - ubuf->sg = get_sg_table(dev, buf, direction); + static DEFINE_MUTEX(lock); + + mutex_lock(&lock); + if (!ubuf->sg) + ubuf->sg = get_sg_table(dev, buf, direction); + mutex_unlock(&lock); if (IS_ERR(ubuf->sg)) { ret = PTR_ERR(ubuf->sg); ubuf->sg = NULL; --