Received-SPF: pass (google.com: domain of linux-kernel+bounces-13825-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <tencent_A9576F5763C6CBF3660361296723B2A44605@qq.com>
From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+9b4adfed366b14496e7e@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [dri?] [media?] memory leak in get_sg_table
Date: Mon,  1 Jan 2024 12:01:29 +0800
In-Reply-To: <0000000000009e6825060dd6c287@google.com>
References: <0000000000009e6825060dd6c287@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

please test memory leak in get_sg_table

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git fbafc3e621c3

diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index 21916bba77d5..709260211546 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -471,8 +471,11 @@ static long dma_buf_ioctl(struct file *file,
 
 		if (sync.flags & DMA_BUF_SYNC_END)
 			ret = dma_buf_end_cpu_access(dmabuf, direction);
-		else
+		else {
+			if (dmabuf->doing)
+				return -EBUSY;
 			ret = dma_buf_begin_cpu_access(dmabuf, direction);
+		}
 
 		return ret;
 
diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index c40645999648..ff49e5cf7d07 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -151,7 +151,10 @@ static int begin_cpu_udmabuf(struct dma_buf *buf,
 	struct udmabuf *ubuf = buf->priv;
 	struct device *dev = ubuf->device->this_device;
 	int ret = 0;
+	static DEFINE_MUTEX(lock);
 
+	mutex_lock(&lock);
+	buf->doing = true;
 	if (!ubuf->sg) {
 		ubuf->sg = get_sg_table(dev, buf, direction);
 		if (IS_ERR(ubuf->sg)) {
@@ -162,6 +165,8 @@ static int begin_cpu_udmabuf(struct dma_buf *buf,
 		dma_sync_sg_for_cpu(dev, ubuf->sg->sgl, ubuf->sg->nents,
 				    direction);
 	}
+	buf->doing = false;
+	mutex_unlock(&lock);
 
 	return ret;
 }
diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
index 3f31baa3293f..4316ad0e6155 100644
--- a/include/linux/dma-buf.h
+++ b/include/linux/dma-buf.h
@@ -446,6 +446,7 @@ struct dma_buf {
 		struct dma_buf *dmabuf;
 	} *sysfs_entry;
 #endif
+	bool doing;
 };
 
 /**