Received-SPF: pass (google.com: domain of linux-kernel+bounces-13904-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <86fa9afa-21c0-42fb-926d-5ffc69695d30@redhat.com>
Date: Mon, 1 Jan 2024 11:26:57 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] cgroup/cpuset: Adjust exception handling in
 generate_sched_domains()
Content-Language: en-US
To: Markus Elfring <Markus.Elfring@web.de>, cgroups@vger.kernel.org,
 kernel-janitors@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
 Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>
Cc: LKML <linux-kernel@vger.kernel.org>
References: <53be5f98-6359-48b5-955e-fd203d99d3cb@web.de>
 <9cd1ce1d-15c7-427c-9929-f3c75b97b49c@redhat.com>
 <b441f304-a3cc-4ebe-91cb-84caf55cbfe2@web.de>
From: Waiman Long <longman@redhat.com>
In-Reply-To: <b441f304-a3cc-4ebe-91cb-84caf55cbfe2@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 1/1/24 03:56, Markus Elfring wrote:
>>> Two resource allocation failures triggered further actions
>>> over the label “done” so far.
>>>
>>> * Jump to the statement “ndoms = 1;” in three cases directly
>>>     by using the label “set_ndoms” instead.
>>>
>>> * Delete an assignment for the variable “ndoms” in one if branch.
> …
>>> ---
>>>    kernel/cgroup/cpuset.c | 8 ++++----
>>>    1 file changed, 4 insertions(+), 4 deletions(-)
> …
>>> @@ -973,10 +973,9 @@ static int generate_sched_domains(cpumask_var_t **domains,
>>>
>>>        /* Special case for the 99% of systems with one, full, sched domain */
>>>        if (root_load_balance && !top_cpuset.nr_subparts) {
>>> -        ndoms = 1;
>>>            doms = alloc_sched_domains(ndoms);
>>>            if (!doms)
>>> -            goto done;
>>> +            goto set_ndoms;
>>>
>>>            dattr = kmalloc(sizeof(struct sched_domain_attr), GFP_KERNEL);
>>>            if (dattr) {
> …
>>> @@ -1123,6 +1122,7 @@ static int generate_sched_domains(cpumask_var_t **domains,
>>>         * See comments in partition_sched_domains().
>>>         */
>>>        if (doms == NULL)
>>> +set_ndoms:
>>>            ndoms = 1;
>>>
>>>        *domains    = doms;
> …
>> Please clarify what this patch is for. Is it just a cleanup with no functional changes or is there a bug that is being fixed?
> The development opinions might vary for the presented transformation.
> I suggest to reconsider the number of relevant variable assignments here.
> Would you categorise an extra statement still as a desirable implementation detail?

My understanding of the patch is just to avoid an unnecessary call to 
kfree() as kfree(NULL) is basically a NOP. By jumping inside the "if" 
part of the conditional statement, however, it makes it a bit harder to 
read. As generate_sched_domains() is not in the fast path, I would 
rather have a patch that can simplify the logic than to make it harder 
to understand.

Cheers,
Longman