Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6097922rdb; Mon, 1 Jan 2024 08:34:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IG1cf0yCMxBPHpTR5JWSws2i/jEf+K6KFCf5RD9TDk2KYyOv6akslOV5lBvMWnXz1B8x1fl X-Received: by 2002:a05:600c:2941:b0:40d:60ce:1690 with SMTP id n1-20020a05600c294100b0040d60ce1690mr3944443wmd.44.1704126865134; Mon, 01 Jan 2024 08:34:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704126865; cv=none; d=google.com; s=arc-20160816; b=cp/+NHC5+QnEHPmJgsGzgemqc80l9T+dYqgZYzPS2sBFIfty6q7p+RJBpIDzwy3pLU rEe3euHmec/Vc4t+BijEr+khRFqwHCwebiQT5zvf+CCD2sU3qTXqhtlQU3RQIE5T5oyT M5Q9PpHEX3sd4rT8BKnJAVeOQpCu+sb6GOu7FmHyh/qYskWFSejyrqh9YViF35Y3yz/e hrhl7yRM9MUTcc0E1kfRgHhTc8M5dv5s3677PTxC8pO1z3IK4AOGt8wxNe5ngnEuDW/G lB1HT1Q4RzZLhrM6QLhpXPxUAszl84efFRrnbAzsngJSt5/KfR41/elYaXafj4ZsykbB Jnow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:accept-language :in-reply-to:references:message-id:date:thread-index:thread-topic :subject:cc:to:from; bh=yihxWybJiKyJXGVx+uAox2aCoGzmn9f9wRHFZWfGaJE=; fh=vRodM1cd8LfN2LrB+2MWePXB8AuQNXwNzH2HcR6L75E=; b=Tam78V8EyXW3nQUWYtBrvgdQUPVGMpNhPR0pGDP26J/AUAG1ealWC8xUkZUSPktcSB O0slofRWF417PKj7v4aXEksGssIBz6CSh7gfLwi+T0dHEsIZqZ2M2HwRSoj1rw4RGvoH XbFyX7Gi0BKuqB3FFQWMpBe8DP29eGsR9L44wJoOYCB9bTdDbpcEDST1y1PDefEA+Nij NE219UrnSPl3OYeRye/Sz/ua8oLccEibQR/C91Vd/QFeIjortTVpbe9jFVlxfw1Lw9PL 3k+n6QNnaOmBrxE0838XRUo7u7DgtGsmpSc2RMEknlvzp/Fkkg2igKC6pMUPXej/+wSr ZnUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-13905-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13905-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ka13-20020a170907920d00b00a27765fb8f2si3061035ejb.825.2024.01.01.08.34.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 08:34:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13905-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-13905-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13905-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CCE8C1F217EB for ; Mon, 1 Jan 2024 16:34:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 948926FB0; Mon, 1 Jan 2024 16:34:10 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6784A8BF7 for ; Mon, 1 Jan 2024 16:34:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ACULAB.COM Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aculab.com Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-203-kjforqtyMaePgnFYa79FrA-1; Mon, 01 Jan 2024 16:33:58 +0000 X-MC-Unique: kjforqtyMaePgnFYa79FrA-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Mon, 1 Jan 2024 16:33:34 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Mon, 1 Jan 2024 16:33:34 +0000 From: David Laight To: 'Willem de Bruijn' , Markus Elfring , "netdev@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , "Stephen Hemminger" CC: LKML Subject: RE: packet: Improve exception handling in fanout_add() Thread-Topic: packet: Improve exception handling in fanout_add() Thread-Index: AQHaPMdEXQvPcsiVWUu1iBz3bxTbObDFHIww Date: Mon, 1 Jan 2024 16:33:34 +0000 Message-ID: <25b3322081b64bd2a610f76f71de30f7@AcuMS.aculab.com> References: <828bb442-29d0-4bb8-b90d-f200bdd4faf6@web.de> <6591e0fcb089f_21410c2946c@willemb.c.googlers.com.notmuch> <6592da5178589_238b0d2943a@willemb.c.googlers.com.notmuch> In-Reply-To: <6592da5178589_238b0d2943a@willemb.c.googlers.com.notmuch> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 RnJvbTogV2lsbGVtIGRlIEJydWlqbg0KPiBTZW50OiAwMSBKYW51YXJ5IDIwMjQgMTU6MjkNCj4g DQo+IE1hcmt1cyBFbGZyaW5nIHdyb3RlOg0KPiA+ID4gSXQgaXMgZmluZSB0byBjYWxsIGtmcmVl IHdpdGggYSBwb3NzaWJsZSBOVUxMIHBvaW50ZXI6DQo+ID4g4oCmDQo+ID4gPiAJICogSWYgQG9i amVjdCBpcyBOVUxMLCBubyBvcGVyYXRpb24gaXMgcGVyZm9ybWVkLg0KPiA+ID4gCSAqLw0KPiA+ ID4gCXZvaWQga2ZyZWUoY29uc3Qgdm9pZCAqb2JqZWN0KQ0KPiA+DQo+ID4gU3VjaCBhIGZ1bmN0 aW9uIGNhbGwgdHJpZ2dlcnMgYW4gaW5wdXQgcGFyYW1ldGVyIHZhbGlkYXRpb24NCj4gPiB3aXRo IGEgY29ycmVzcG9uZGluZyBpbW1lZGlhdGUgcmV0dXJuLCBkb2Vzbid0IGl0Pw0KPiA+IERvIHlv dSBmaW5kIHN1Y2ggZGF0YSBwcm9jZXNzaW5nIHJlYWxseSBoZWxwZnVsIGZvciB0aGUgZGVzaXJl ZCBlcnJvci9leGNlcHRpb24gaGFuZGxpbmc/DQo+IA0KPiBJdCdzIG5vdCBqdXN0IHBlcnNvbmFs IHByZWZlcmVuY2UuIEl0IGlzIGFuIGVzdGFibGlzaGVkIHBhdHRlcm4gdG8NCj4gYXZvaWQgZXh0 cmEgTlVMTCB0ZXN0cyBhcm91bmQga2ZyZWUuDQo+IA0KPiBBIHF1aWNrIGdpdCBsb2cgdG8gc2hv dyBhIGZldyByZWNlbnQgZXhhbXBsZXMgb2YgcGF0Y2hlcyB0aGF0IGV4cHJlc3NseQ0KPiByZW1v dmUgc3VjaCBicmFuY2hlcywgZS5nLiwNCj4gDQo+IGNvbW1pdCBkMDExMDQ0M2NmNGEgKCJhbWQv cGRzX2NvcmU6IGNvcmU6IE5vIG5lZWQgZm9yIE51bGwgcG9pbnRlciBjaGVjayBiZWZvcmUga2Zy ZWUiKQ0KPiBjb21taXQgZWZkOWQwNjVkZTY3ICgiZHJtL3JhZGVvbjogUmVtb3ZlIHVubmVjZXNz YXJ5IE5VTEwgdGVzdCBiZWZvcmUga2ZyZWUgaW4NCj4gJ3JhZGVvbl9jb25uZWN0b3JfZnJlZV9l ZGlkJyIpDQo+IA0KPiBBbiBpbnRlcmVzdGluZyBvbGRlciB0aHJlYWQgb24gdGhlIHRvcGljOg0K PiANCj4gaHR0cHM6Ly9saW51eC1rZXJuZWwudmdlci5rZXJuZWwubmFya2l2ZS5jb20vS1ZqbERz VG8va2ZyZWUtbnVsbA0KDQpUaGF0IGFjdHVhbGx5IGZhaWxzIHRvIG5vdGUgdGhhdCBpZiB0aGUg Y2FsbCBzaXRlIGNvbnRhaW5zIHRoZQ0KY29uZGl0aW9uYWwgKGV4cGxpY2l0bHkgb3IgZnJvbSBh ICNkZWZpbmUvc3RhdGljIGlubGluZSkgdGhlbiBnY2MNCndpbGwgb3B0aW1pc2UgdGhlIHRlc3Qg YXdheSBpZiBpdCBjYW4gZGV0ZXJtaW5lIHRoYXQgdGhlIHBvaW50ZXINCmlzIE5VTEwgKGZyb20g YW4gZWFybGllciB0ZXN0KSBvciBub24tTlVMTCAoaGFzIGJlZW4gZGVyZWZlcmVuY2VkKS4NClBv c3NpYmx5IGJlY2F1c2UgZ2NjIGRpZG4ndCBkbyB0aGF0IDE4IHllYXJzIGFnby4NCg0KPiBNeSBz dW1tYXJ5LCB0aGUgbWFueSBicmFuY2hlcyBzY2F0dGVyZWQgdGhyb3VnaG91dCB0aGUga2VybmVs IGxpa2VseQ0KPiBhcmUgbW9yZSBleHBlbnNpdmUgdGhhbiB0aGUgb2NjYXNpb25hbCBzYXZlIGZy b20gc2VlaW5nIHRoZSByYXJlIE5VTEwNCj4gcG9pbnRlci4NCg0KRXNwZWNpYWxseSBpbiBlcnJv ciBwYXRocyBvciB3aGVyZSB0aGUgbm9ybWFsIGNhc2UgaXMgdGhhdCB0aGUgcG9pbnRlcg0KaXMg YWxsb2NhdGVkLg0KDQpBYm91dCB0aGUgb25seSBwbGFjZSB3aGVyZSBhIGNoZWNrIGluIHRoZSBj YWxsZXIgbWF5IG1ha2Ugc2Vuc2UgaXMNCmZvciBmcmVxdWVudGx5IHVzZWQgY29kZSBwYXRocyB3 aGVyZSB0aGUgcG9pbnRlciBpcyBub3JtYWxseSBOVUxMLg0KT25lIGV4YW1wbGUgd291bGQgYmUg dGhlIGNvZGUgdGhhdCByZWFkcyBhbiBpb3ZlY1tdIGZyb20gdXNlciBzcGFjZS4NCkFuIG9uLXN0 YWNrIGFycmF5IGlzIHVzZWQgZm9yIHNtYWxsIChzYW5lKSBmcmFnbWVudCBjb3VudHMgd2l0aA0K a21hbGxvYygpIGJlaW5nIGNhbGxlZCBmb3IgbGFyZ2UgY291bnRzLg0KSW4gdGhhdCBjYXNlIGhh dmluZyAnaWYgKHVubGlrZWx5KHB0cikpIGtmcmVlKHB0cik7JyB3aWxsIHByb2JhYmx5DQpnZW5l cmF0ZSBjb2RlIHRoYXQgaXMgbWVhc3VyYWJseSBmYXN0ZXIuDQooRXNwZWNpYWxseSBpZiB0aGVy ZSBhcmUgbWl0aWdhdGlvbnMgZm9yICdyZXQnLikNCg0KSSBhbHNvIGJlbGlldmUgdGhhdCBsaWtl bHkvdW5saWtlbHkgaGF2ZSBhbG1vc3Qgbm8gZWZmZWN0IG9uIG1vZGVybiB4ODYuDQood2FzIGl0 IHRoZSBQLVBybyB0aGF0IHVzZWQgcHJlZml4IGZvciBzdGF0aWMgcHJlZGljdGlvbj8pDQpJSVJD IHRoZXJlIGlzIG5vICdzdGF0aWMgcHJlZGljdGlvbicgLSBwcmVkaWN0aW9uIGlzIGJhc2VkIG9u IHdoYXRldmVyDQonc2V0IG9mIGJyYW5jaGVzJyB0aGUgY3VycmVudCBicmFuY2ggYWxhc2VzIHRv Lg0KVGhlIG9ubHkgc2xpZ2h0IGdhaW4gaXMgdGhhdCB0aGUgJ2ZhbGwgdGhyb3VnaCcgcGF0aCBp cyBsZXNzIGxpa2VseQ0KdG8gc3RhbGwgZHVlIHRvIGEgY2FjaGUgbWlzcy4gQnV0IGV2ZW4gdGhh dCBjYW4gYmUgZmFyIGVub3VnaCBhaGVhZA0Kb2YgdGhlIG5vbi1zcGVjdWxhdGl2ZSBleGVjdXRp b24gcG9pbnQgdGhhdCB0aGUgYWN0dWFsIHN0YWxsIGlzIHNtYWxsLg0KDQpPZiBjb3Vyc2Ugb3Ro ZXIgc2ltcGxlciBjcHUgZG8gaGF2ZSBzdGF0aWMgcHJlZGljdGlvbiBydWxlcy4NCkNvbW1vbiB3 b3VsZCBiZSB0byBwcmVkaWN0IGJhY2t3YXJkcyBicmFuY2hlcyB0YWtlbiAoZWcgbG9vcHMpDQph bmQgZm9yd2FyZHMgb25lcyBub3QtdGFrZW4uDQpJZiB5b3UgcmVhbGx5IGRvIGNhcmUgKGVzcGVj aWFsbHkgaWYgeW91J3ZlIGRpc2FibGVkIGFueSBkeW5hbWljIHByZWRpY3Rpb24NCmluIG9yZGVy IHRvIGdldCBtZWFzdXJhYmxlIGV4ZWN1dGlvbiB0aW1lcykgdGhlbiB5b3UgY2FuIG5lZWQgdG8g YWRkDQooZWcpIGFzbSBjb21tZW50cyB0byBmb3JjZSBhIHByZWRpY3RlZCBub3QtdGFrZW4gZm9y d2FyZHMgYnJhbmNoIHRvDQphbiB1bmNvbmRpdGlvbmFsIGJhY2t3YXJkcyBicmFuY2ggdG8gYXZv aWQgYSAncHJlZGljdGVkIHRha2VuJyBiYWNrd2FyZA0KYnJhbmNoLg0KDQoJRGF2aWQNCg0KLQ0K UmVnaXN0ZXJlZCBBZGRyZXNzIExha2VzaWRlLCBCcmFtbGV5IFJvYWQsIE1vdW50IEZhcm0sIE1p bHRvbiBLZXluZXMsIE1LMSAxUFQsIFVLDQpSZWdpc3RyYXRpb24gTm86IDEzOTczODYgKFdhbGVz KQ0K