Received-SPF: pass (google.com: domain of linux-kernel+bounces-13924-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 1 Jan 2024 10:12:21 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
 netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
 <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, LKML
 <linux-kernel@vger.kernel.org>
Subject: Re: packet: Improve exception handling in fanout_add()
Message-ID: <20240101101221.73276d5d@hermes.local>
In-Reply-To: <a69fce11-68c2-446c-9da8-b959bb3ba70f@web.de>
References: <828bb442-29d0-4bb8-b90d-f200bdd4faf6@web.de>
	<6591e0fcb089f_21410c2946c@willemb.c.googlers.com.notmuch>
	<a69fce11-68c2-446c-9da8-b959bb3ba70f@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, 1 Jan 2024 10:46:45 +0100
Markus Elfring <Markus.Elfring@web.de> wrote:

> > It is fine to call kfree with a possible NULL pointer: =20
> =E2=80=A6
> > 	 * If @object is NULL, no operation is performed.
> > 	 */
> > 	void kfree(const void *object) =20
>=20
> Such a function call triggers an input parameter validation
> with a corresponding immediate return, doesn't it?
> Do you find such data processing really helpful for the desired error/exc=
eption handling?

If you look at the existing coccinelle script there is even one
to remove unnecessary checks for null before calling kfree.