Received-SPF: pass (google.com: domain of linux-kernel+bounces-13936-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 1 Jan 2024 10:18:51 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, Anjali Kulkarni
 <anjali.k.kulkarni@oracle.com>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Kuniyuki Iwashima <kuniyu@amazon.com>, Paolo Abeni <pabeni@redhat.com>,
 Simon Horman <horms@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] netlink: Move an assignment for the variable
 =?UTF-8?B?4oCcY2JfbXV0ZXjigJ0=?= in __netlink_kernel_create()
Message-ID: <20240101101851.10c640ef@hermes.local>
In-Reply-To: <d250255b-fd88-4ea9-aa08-bc8d911143af@web.de>
References: <90679f69-951c-47b3-b86f-75fd9fde3da3@web.de>
	<d250255b-fd88-4ea9-aa08-bc8d911143af@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sun, 31 Dec 2023 18:48:11 +0100
Markus Elfring <Markus.Elfring@web.de> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 31 Dec 2023 18:16:26 +0100
>=20
> Move one assignment for the variable =E2=80=9Ccb_mutex=E2=80=9D closer to=
 the place
> where this pointer is used.
>=20
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

NAK
Useless code churn, no improvement in performance or readablilty.
Compiler optimizer will do this already if it wants.