Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6233655rdb; Mon, 1 Jan 2024 14:36:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDkMOC/bKf1iv2aaRbsWm0S0nkxYD3fwni4k21A8aMfqXXmJYxdFu57b8WP7cK3HnMW+dS X-Received: by 2002:a05:600c:1608:b0:40d:2853:8204 with SMTP id m8-20020a05600c160800b0040d28538204mr9069091wmn.166.1704148596105; Mon, 01 Jan 2024 14:36:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704148596; cv=none; d=google.com; s=arc-20160816; b=gDjDRs2905OAq+3sjeVstwhM3sIjmGEFSY0xXMWazSnuu92MqetzNrz0LEldA5MnhG FSljre4vlJnL6cs/OdO/YY/3rXH+A3j1pDhekSU3fIaZF3uXH/D/WGk9wmICakf/0mSc OyrQ7k0F+AyJwhSeiM3+PCXW5/p+q1Svk3XX681O/xsN5Hh4yMnXL8Coz7nV5fcQYEOF ag4cOBM3yT1vG1KogVBIjAKva4kk+HYVKTncX9t8h0X4+MsaJYylkO6H4iDLy7VGYGkF x0vgh163wHR8Nt301b8aHlPLoVzJh0/saPFpBipPEPAJ+okT/94By/UqboW8Bvn1Ig3z 6zAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:subject:cc:to:from:date:dkim-signature; bh=2FQy+ORQlDr6BlS1/OXUjM6c+rLOzpW8GfhmKHifP4w=; fh=CTNbqjjTf++MClya1oQBj7I35ZCaGzKfIHi54oS2V2s=; b=yTCGz1jUDOCbnEZDjlV4MWf1yLVmsEWQ8ldLG9IaqG73zD+xIcWYbosRcqLzUJoU/n +bMbwvatoljHNZPKKS8W+BY6r29g93hkrRU7VYHFViiUfnDo69qALTBmzlJo+jK53xeu YCJ3FO9ZqfrCY306NU9O+Gh4g8CQQIfco0H0P61oDPIxrlsp+wOHEWoXkdw2w/m/xVm5 orVVfazhPZIVl0igzXAG/8u4z+iiCGKIfmh+BCWj+8uU3Jd5mgAvz8Q1sOuaErvJNIIL fbxTqQG1tsX6GgUMDHdKVcK4HI2houpbxVcZN2WMtqgeLUDMQFs4OlAxA0c7qUXHQrCW K/Fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b="FdBGdn3/"; spf=pass (google.com: domain of linux-kernel+bounces-13955-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13955-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ka21-20020a170907921500b00a27d904ccbasi1625840ejb.327.2024.01.01.14.36.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jan 2024 14:36:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13955-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b="FdBGdn3/"; spf=pass (google.com: domain of linux-kernel+bounces-13955-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13955-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D6E641F21808 for ; Mon, 1 Jan 2024 22:36:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2DB17EAD0; Mon, 1 Jan 2024 22:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="FdBGdn3/" X-Original-To: linux-kernel@vger.kernel.org Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 602BDE55F; Mon, 1 Jan 2024 22:36:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canb.auug.org.au DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1704148579; bh=2FQy+ORQlDr6BlS1/OXUjM6c+rLOzpW8GfhmKHifP4w=; h=Date:From:To:Cc:Subject:From; b=FdBGdn3/A8KDOjrGc+K2eVZYO/eN7kMUILSwcmiH2h2BWrObW9cDELRJGnHH2pIc2 Pe+q4JAKjXT249aegVfRpJU0/vje/SGG+oXz5zJnVHB4HJew0RgQb+kWgNu6C4SS2d ecjDtEumAR/piFeU3erbdCmTb0AzQlg9jd2ntgy9bqbY/yb/QuyFzVWmdAlbyvBLdX flK+m2ZtDN5YjZyYHb5L7rBz2D7laLgJQXBkVSDiY/tQGJvKKNKbu1ZsrDA012iOHr 2jYsAi3W/rBcAbNRe3SJvB9JcB88anNO7mxLIYsd+8bA0+ph5iq5LktLitQ4XNkfeS jVTnbRFrmvQZQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4T3rS315rCz4wcg; Tue, 2 Jan 2024 09:36:18 +1100 (AEDT) Date: Tue, 2 Jan 2024 09:36:17 +1100 From: Stephen Rothwell To: Al Viro Cc: Linux Kernel Mailing List , Linux Next Mailing List , "Steven Rostedt (Google)" Subject: linux-next: manual merge of the vfs tree with Linus' tree Message-ID: <20240102093617.0b3a0907@canb.auug.org.au> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/d+MIXcnLuloSv.dh+tZIWZ6"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/d+MIXcnLuloSv.dh+tZIWZ6 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, Today's linux-next merge of the vfs tree got a conflict in: fs/tracefs/inode.c between commit: 7e8358edf503 ("eventfs: Fix file and directory uid and gid ownership") from Linus' tree and commit: da549bdd15c2 ("dentry: switch the lists of children to hlist") from the vfs tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. --=20 Cheers, Stephen Rothwell diff --cc fs/tracefs/inode.c index 62524b20964e,61ca5fcf10f9..000000000000 --- a/fs/tracefs/inode.c +++ b/fs/tracefs/inode.c @@@ -207,24 -206,14 +206,21 @@@ static void set_gid(struct dentry *pare =20 change_gid(this_parent, gid); repeat: - next =3D this_parent->d_subdirs.next; + dentry =3D d_first_child(this_parent); resume: - while (next !=3D &this_parent->d_subdirs) { + hlist_for_each_entry_from(dentry, d_sib) { + struct tracefs_inode *ti; - struct list_head *tmp =3D next; - struct dentry *dentry =3D list_entry(tmp, struct dentry, d_child); - next =3D tmp->next; + spin_lock_nested(&dentry->d_lock, DENTRY_D_LOCK_NESTED); =20 change_gid(dentry, gid); =20 + /* If this is the events directory, update that too */ + ti =3D get_tracefs(dentry->d_inode); + if (ti && (ti->flags & TRACEFS_EVENT_INODE)) + eventfs_update_gid(dentry, gid); + - if (!list_empty(&dentry->d_subdirs)) { + if (!hlist_empty(&dentry->d_children)) { spin_unlock(&this_parent->d_lock); spin_release(&dentry->d_lock.dep_map, _RET_IP_); this_parent =3D dentry; --Sig_/d+MIXcnLuloSv.dh+tZIWZ6 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmWTPmEACgkQAVBC80lX 0Gz6egf8DAkzOrBYU+3hxpdmPeBJ8/ZNK3XUpXqfJfvTeGRepAXnwpqfc9QbKiJT RHlwdYtu0CxBlALMxg408duhz2tp+d9cEteOIuc/9dxkm7SH2F0tiCDk/bJXOoRh S0HKpxmMqgXA+Sk2Z2tWF+npLz0hBlO2qxXEgA6Zc6BPnB9608LggDwWl0Gk5EGk nIpictcCV0M/D8ukC/4/FzeF0q4g8QauRiy0DDBOw5AcQoCQoFDM2JKE1k788fus dJJG2WzWPEHxyfjeiDob7pu3PkeQP+cRS7tN0beza3RYlGfruiPZRuODRzT+QhFO Lc4t7yBMeD0on8SkBB5YWJvUp7lJPQ== =ht0o -----END PGP SIGNATURE----- --Sig_/d+MIXcnLuloSv.dh+tZIWZ6--