Received-SPF: pass (google.com: domain of linux-kernel+bounces-13999-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 2 Jan 2024 11:25:57 +0800
From: Jisheng Zhang <jszhang@kernel.org>
To: Alexandre Ghiti <alex@ghiti.fr>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>, Will Deacon <will@kernel.org>,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Nick Piggin <npiggin@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/4] riscv: enable HAVE_FAST_GUP if MMU
Message-ID: <ZZOCRZjBch1grrFp@xhacker>
References: <20231219175046.2496-1-jszhang@kernel.org>
 <20231219175046.2496-5-jszhang@kernel.org>
 <3d36ca3c-9a91-41a7-9e68-288982c2c8a8@ghiti.fr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3d36ca3c-9a91-41a7-9e68-288982c2c8a8@ghiti.fr>

On Sun, Dec 31, 2023 at 07:37:33AM +0100, Alexandre Ghiti wrote:
> On 19/12/2023 18:50, Jisheng Zhang wrote:
> > Activate the fast gup for riscv mmu platforms. Here are some
> > GUP_FAST_BENCHMARK performance numbers:
> > 
> > Before the patch:
> > GUP_FAST_BENCHMARK: Time: get:53203 put:5085 us
> > 
> > After the patch:
> > GUP_FAST_BENCHMARK: Time: get:17711 put:5060 us
> 
> 
> On which platform did you run this benchmark?

T-HEAD th1520(cpufreq isn't enabled since the clk/pll isn't upstreamed,
so cpu is running at the default freq set by u-boot)
> 
> 
> > 
> > The get time is reduced by 66.7%! IOW, 3x get speed!
> 
> 
> Well done!
> 
> Thanks,
> 
> Alex
> 
> 
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > ---
> >   arch/riscv/Kconfig               | 1 +
> >   arch/riscv/include/asm/pgtable.h | 6 ++++++
> >   2 files changed, 7 insertions(+)
> > 
> > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> > index d3555173d9f4..04df9920282d 100644
> > --- a/arch/riscv/Kconfig
> > +++ b/arch/riscv/Kconfig
> > @@ -119,6 +119,7 @@ config RISCV
> >   	select HAVE_FUNCTION_GRAPH_RETVAL if HAVE_FUNCTION_GRAPH_TRACER
> >   	select HAVE_FUNCTION_TRACER if !XIP_KERNEL && !PREEMPTION
> >   	select HAVE_EBPF_JIT if MMU
> > +	select HAVE_FAST_GUP if MMU
> >   	select HAVE_FUNCTION_ARG_ACCESS_API
> >   	select HAVE_FUNCTION_ERROR_INJECTION
> >   	select HAVE_GCC_PLUGINS
> > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> > index ab00235b018f..c6eb214139e6 100644
> > --- a/arch/riscv/include/asm/pgtable.h
> > +++ b/arch/riscv/include/asm/pgtable.h
> > @@ -673,6 +673,12 @@ static inline int pmd_write(pmd_t pmd)
> >   	return pte_write(pmd_pte(pmd));
> >   }
> > +#define pud_write pud_write
> > +static inline int pud_write(pud_t pud)
> > +{
> > +	return pte_write(pud_pte(pud));
> > +}
> > +
> >   static inline int pmd_dirty(pmd_t pmd)
> >   {
> >   	return pte_dirty(pmd_pte(pmd));