Received-SPF: pass (google.com: domain of linux-kernel+bounces-14026-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.7\))
Subject: Re: [PATCH v3 00/12] RISC-V: provide some accelerated cryptography
 implementations using vector extensions
From: Jerry Shih <jerry.shih@sifive.com>
In-Reply-To: <20231230035112.GC770@quark.localdomain>
Date: Tue, 2 Jan 2024 13:16:54 +0800
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>,
 Albert Ou <aou@eecs.berkeley.edu>,
 herbert@gondor.apana.org.au,
 davem@davemloft.net,
 conor.dooley@microchip.com,
 ardb@kernel.org,
 conor@kernel.org,
 heiko@sntech.de,
 phoebe.chen@sifive.com,
 hongrong.hsu@sifive.com,
 linux-riscv@lists.infradead.org,
 linux-kernel@vger.kernel.org,
 linux-crypto@vger.kernel.org,
 Andy Chiu <andy.chiu@sifive.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <EED7F0DA-5619-411B-82A2-7926155E9B73@sifive.com>
References: <20231205092801.1335-1-jerry.shih@sifive.com>
 <20231222054827.GE52600@quark.localdomain>
 <20231230035112.GC770@quark.localdomain>
To: Eric Biggers <ebiggers@kernel.org>

On Dec 30, 2023, at 11:51, Eric Biggers <ebiggers@kernel.org> wrote:
> Hi Jerry,
> On Thu, Dec 21, 2023 at 11:48:27PM -0600, Eric Biggers wrote:
>> Hi Jerry,
>>=20
>> On Tue, Dec 05, 2023 at 05:27:49PM +0800, Jerry Shih wrote:
>>> Changelog v2:
>>> - Turn to use simd skcipher interface for AES-CBC/CTR/ECB/XTS and
>>>   Chacha20.
>>=20
>> If I understand correctly, the RISC-V kernel-mode vector support now =
seems to be
>> heading down the path of supporting softirq context, as I had =
suggested
>> originally.  With patches 1-2 of Andy Chiu's latest patchset
>> "[v7, 00/10] riscv: support kernel-mode Vector"
>> =
(https://lore.kernel.org/linux-riscv/20231221134318.28105-1-andy.chiu@sifi=
ve.com).
>> applied, the kernel has basic support for kernel-mode vector, =
including in
>> softirq context.
>>=20
>> With that being the case, "skcipher" algorithms can just use the =
RISC-V vector
>> unit unconditionally, given that skcipher only supports task and =
softirq
>> context.  Therefore, can you consider undoing your change that added =
fallbacks
>> using the simd helper (crypto/simd.c)?  Thanks!
>>=20
>=20
> I had a go at incorporating my suggestions into your patchset, and =
rebasing the
> patchset onto riscv/for-next plus the first two patches of "[v9, =
00/10] riscv:
> support kernel-mode Vector".  You can get the result from branch =
"riscv-crypto"
> of https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git.
> Everything seems to work (tested in QEMU, as usual).
>=20
> Please consider using it when you send out v4; thanks!  I can even =
send it out
> myself, if you want, but I assume you're still "owning" the patchset.
>=20
> - Eric

Thank you. I sent the v4 patch.
Link: =
https://lore.kernel.org/all/20231231152743.6304-1-jerry.shih@sifive.com/

-Jerry=