Received-SPF: pass (google.com: domain of linux-kernel+bounces-14052-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <0f605226-dd98-addc-eac2-9e3eb36e748a@quicinc.com>
Date: Tue, 2 Jan 2024 11:02:28 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] media: venus: use div64_u64() instead of do_div()
To: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>,
        <stanimir.k.varbanov@gmail.com>, <quic_vgarodia@quicinc.com>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <mchehab@kernel.org>
CC: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
        <linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20231229121504.3479594-1-himanshu.bhavani@siliconsignals.io>
Content-Language: en-US
From: Dikshita Agarwal <quic_dikshita@quicinc.com>
In-Reply-To: <20231229121504.3479594-1-himanshu.bhavani@siliconsignals.io>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 12/29/2023 5:45 PM, Himanshu Bhavani wrote:
> do_div() does a 64-by-32 division.
> When the divisor is u64, do_div() truncates it to 32 bits, this means it
> can test non-zero and be truncated to zero for division.
> 
> fix do_div.cocci warning:
> do_div() does a 64-by-32 division, please consider using div64_u64 instead.
> 
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
> 
> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
> index 44b13696cf82..81853eb2993a 100644
> --- a/drivers/media/platform/qcom/venus/venc.c
> +++ b/drivers/media/platform/qcom/venus/venc.c
> @@ -409,13 +409,13 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
>  	out->capability = V4L2_CAP_TIMEPERFRAME;
>  
>  	us_per_frame = timeperframe->numerator * (u64)USEC_PER_SEC;
> -	do_div(us_per_frame, timeperframe->denominator);
> +	div64_u64(us_per_frame, timeperframe->denominator);
I think, this should be like below:
us_per_frame = div64_u64(us_per_frame, timeperframe->denominator);

because do_div does the in-place division while div64_u64 doesn't.
so final value of us_per_frame won't be correct with this change.

>  
>  	if (!us_per_frame)
>  		return -EINVAL;
>  
>  	fps = (u64)USEC_PER_SEC;
> -	do_div(fps, us_per_frame);
> +	div64_u64(fps, us_per_frame);
ditto..
fps = div64_u64(fps, us_per_frame);
>  
>  	inst->timeperframe = *timeperframe;
>  	inst->fps = fps;

Thanks,
Dikshita