Received-SPF: pass (google.com: domain of linux-kernel+bounces-14083-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0
Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge()
From: Muchun Song <muchun.song@linux.dev>
In-Reply-To: <ZZOhCuuozrBscdRC@x1n>
Date: Tue, 2 Jan 2024 14:30:25 +0800
Cc: LKML <linux-kernel@vger.kernel.org>,
 Linux-MM <linux-mm@kvack.org>,
 Matthew Wilcox <willy@infradead.org>,
 Christophe Leroy <christophe.leroy@csgroup.eu>,
 Lorenzo Stoakes <lstoakes@gmail.com>,
 David Hildenbrand <david@redhat.com>,
 Vlastimil Babka <vbabka@suse.cz>,
 Mike Kravetz <mike.kravetz@oracle.com>,
 Mike Rapoport <rppt@kernel.org>,
 Christoph Hellwig <hch@infradead.org>,
 John Hubbard <jhubbard@nvidia.com>,
 Andrew Jones <andrew.jones@linux.dev>,
 linux-arm-kernel@lists.infradead.org,
 Michael Ellerman <mpe@ellerman.id.au>,
 "Kirill A . Shutemov" <kirill@shutemov.name>,
 linuxppc-dev@lists.ozlabs.org,
 Rik van Riel <riel@surriel.com>,
 linux-riscv@lists.infradead.org,
 Yang Shi <shy828301@gmail.com>,
 James Houghton <jthoughton@google.com>,
 "Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Andrea Arcangeli <aarcange@redhat.com>,
 Axel Rasmussen <axelrasmussen@google.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <4B38660D-3AC2-4F96-9DD1-2D8CAA55E7E4@linux.dev>
References: <20231219075538.414708-1-peterx@redhat.com>
 <20231219075538.414708-4-peterx@redhat.com>
 <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> <ZZOhCuuozrBscdRC@x1n>
To: Peter Xu <peterx@redhat.com>


> On Jan 2, 2024, at 13:37, Peter Xu <peterx@redhat.com> wrote:
>=20
> On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote:
>>> @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd)
>>>  #endif /* pmd_write */
>>>  #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
>>> +#ifndef pmd_thp_or_huge
>>=20
>> I think it may be the time to rename to pmd_thp_or_hugetlb,
>> the "huge" is really confusing. thp is not huge? Actually,
>> it is huge. It is better to make it more specific from now on, like
>> "hugetlb".
>=20
> The rename will need to touch ARM code, which I wanted to avoid, see:

I see.

>=20
> arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd)   =
(pmd_huge(pmd) || pmd_trans_huge(pmd))
>=20
> So far this series only touches generic code.  Would you mind I keep =
this
> patch as-is, and leave renaming to later?

OK.

THanks.

>=20
>>=20
>> BTW, please cc me via the new email (muchun.song@linux.dev) next =
edition.
>=20
> Sure.  Thanks for taking a look.
>=20
> --=20
> Peter Xu
>=20