Received-SPF: pass (google.com: domain of linux-kernel+bounces-14084-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Suman Ghosh <sumang@marvell.com>
To: Marcin Wojtas <marcin.s.wojtas@gmail.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>
CC: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>,
        "olteanv@gmail.com" <olteanv@gmail.com>,
        "davem@davemloft.net"
	<davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "linux@armlinux.org.uk"
	<linux@armlinux.org.uk>
Subject: RE: [EXT] [net-next: PATCH] net: mvpp2: initialize port fwnode
 pointer
Thread-Topic: [EXT] [net-next: PATCH] net: mvpp2: initialize port fwnode
 pointer
Thread-Index: AQHaO+PaWSTamNY+eUmSUJU8cdyTBrDGE7Tw
Date: Tue, 2 Jan 2024 06:35:37 +0000
Message-ID: 
 <SJ0PR18MB5216B68CF41CA2DA540DF979DB61A@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20231231122019.123344-1-marcin.s.wojtas@gmail.com>
In-Reply-To: <20231231122019.123344-1-marcin.s.wojtas@gmail.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?duxoypx5W+we1Q6g7CLphCuqK6EB/0eUNXFe9i+6fNF/IgPVFAI6Z8xwycgm?=
 =?us-ascii?Q?f2/zYqhJbVh7+9/mcP7ncBVR4x+UM8hoVb4wcNRY5VKvbniFp7Lgvm3oRIye?=
 =?us-ascii?Q?cHZCnkjvYdxlKAaiYH1LnCzeU5xDEBqYT3ciob8NrKX/V0aupkGbFhA50p5T?=
 =?us-ascii?Q?BDCwfTmb6EQqNokfzyAUIBatCwhqQRkb2gJLIjOAIgD5NeJczrUvhjsjophB?=
 =?us-ascii?Q?5Tcv35CF9LrnEmEu0dA0szBPxwgfh5eMTIwL9Upo5kJ1JaoFdh7xg3XZISZo?=
 =?us-ascii?Q?9dmR2puFJWilaJusj3LKaq+82jCcA8zPkAe1mLsSgQ5+Ehu5kd9yKWiug/1f?=
 =?us-ascii?Q?FJkzBn8piZuT137aCZJDoBiU9B7/21Lt0qVGVRHmJ1cvaPO6Xpb5wReMygb2?=
 =?us-ascii?Q?edgODq7ZFi6AtNysUwR7fEcQxwvj9ekLZnIyVPFDjLB8eBSseQ1L/3NUh1eL?=
 =?us-ascii?Q?BqF6uD/dgLeyIAMQ9VvMEVS58qE2KhP+mWhrx4cnazFMq5S08j1i1eoQ5Prh?=
 =?us-ascii?Q?0wHyByv/OEUxbTUamphFeDksWc2DudeT1E4qUkNspyoKFr/Kkw2PSL0KnlVM?=
 =?us-ascii?Q?ttySUykfFBUwBqsuvkrxiFcnGcJhiMllrmU6yh57H7rxJL+T+mfRQ+se6nf4?=
 =?us-ascii?Q?Wjr4FvPJ2g8xn0FabPsTS6XXXEYeHXwDM1r/AMCCpArpxY+tSazp+s/oyuG7?=
 =?us-ascii?Q?XXHY5EYN2PVTw+/i6zIV6qmB/fWHf3PJA6fqRjjjPLDvybN20SLQRGAossw1?=
 =?us-ascii?Q?HosCuSa8RuMCwFRigWiOZZSkOY2seMav8baRKb1Vzt9gAJmhHFNsVNTMjGRM?=
 =?us-ascii?Q?p962QLVIw5/q/bM+2VtE1KOBpXvUYklr7RXxcs2U6QmgmZPwhNnSbgSXctYc?=
 =?us-ascii?Q?g2cormo5Rs89DtAMUBO7hfMrjgBedlQKqwHrbP5I7vCid5sJqaBphbC1lzUp?=
 =?us-ascii?Q?8OBWewC9gEEe9ezoZo54sIbA8DZPfLiY3M/uxhJgVaaYJZPp+OgFKcyYHpox?=
 =?us-ascii?Q?Y47UmdviqfqObYJ9nk3drbHeTlFOGeJnEM28Jax+K+rtt/q/g7rjzabFCqw1?=
 =?us-ascii?Q?i/bFK79oi2OrgQwkK/WIOWLNMYKU+U62GbmVIVEeP394iPBi+kOf1Gl9Pm5D?=
 =?us-ascii?Q?AJKf+XfEZQj00TzeZuTalmZ2RAwNsLLZA0c/3IG05j3Y1d3tgH3AomDhwRas?=
 =?us-ascii?Q?TWQEewHwieRq9oMreNk4G6Oe0WreBcs+JAzcvT6+Bf+HCjUnnKHGL7vFvmqd?=
 =?us-ascii?Q?0xQr2TPBXFAcVF/k/7QKVuw5PxiS9cRbkHs6Km2iCGT0+JOKCJDpwjPDj/FV?=
 =?us-ascii?Q?ys1Sym8ekyFr/XRhyOGcMFo8s4RBNQP4MViPrwsxdIaUJ/Wl6Jzd1rYbvYBW?=
 =?us-ascii?Q?F3PU2/m3tyb2HT7WpRwn/9ogbaQkDon31AHqEYP12qydeg/T7cg2qJiwKrGq?=
 =?us-ascii?Q?IrDDrIj6ouaeqSa13W5m0npn73Yqgodj8GDC5i60wG6NtUq0/Y+PsnjQO/kC?=
 =?us-ascii?Q?kZnS4oAQa4eb1ETS4W+6uF9/vZ7yA/Ym7PZRXq5MvXiL2pcowvwgSwPfZxO+?=
 =?us-ascii?Q?Fpl8PI4H86xPkEJYVHc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69a5e14b-a45d-4180-2452-08dc0b5d0853
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2024 06:35:37.8525
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UeqryvdDeywI7ZYl5uzM9ZvNAQnXFxkm61/vOjwpBE9tlWZrwirDnLjFTgKpRiRn8943SeoS+dynJD78JJSqYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR18MB5036
X-Proofpoint-ORIG-GUID: 28r9n1L7E2L_6ySP3yh37hw-2Ztc2dN1
X-Proofpoint-GUID: 28r9n1L7E2L_6ySP3yh37hw-2Ztc2dN1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02

Looks good to me.

>----------------------------------------------------------------------
>Update the port's device structure also with its fwnode pointer with a
>recommended device_set_node() helper routine.
>
>Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com>
[Suman] Reviewed-by: Suman Ghosh <sumang@marvell.com>
>---
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>index 1ca273f17d29..820b1fabe297 100644
>--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
>@@ -6877,7 +6877,7 @@ static int mvpp2_port_probe(struct platform_device
>*pdev,
> 	dev->min_mtu =3D ETH_MIN_MTU;
> 	/* 9704 =3D=3D 9728 - 20 and rounding to 8 */
> 	dev->max_mtu =3D MVPP2_BM_JUMBO_PKT_SIZE;
>-	dev->dev.of_node =3D port_node;
>+	device_set_node(&dev->dev, port_fwnode);
>
> 	port->pcs_gmac.ops =3D &mvpp2_phylink_gmac_pcs_ops;
> 	port->pcs_gmac.neg_mode =3D true;
>--
>2.34.1
>