Received-SPF: pass (google.com: domain of linux-kernel+bounces-14104-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 2 Jan 2024 14:51:00 +0800
From: Hangbin Liu <liuhangbin@gmail.com>
To: Yujie Liu <yujie.liu@intel.com>
Cc: Guillaume Nault <gnault@redhat.com>, netdev@vger.kernel.org,
	Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	lkp@intel.com, kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH v2 net-next] selftests/net: change shebang to bash to
 support "source"
Message-ID: <ZZOyVGQ7U3K16wHr@Laptop-X1>
References: <20231229131931.3961150-1-yujie.liu@intel.com>
 <ZZFbxyQeHgf3UQrN@debian>
 <ZZOkfPgs6T3ujpJo@yujie-X299>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZZOkfPgs6T3ujpJo@yujie-X299>

On Tue, Jan 02, 2024 at 01:51:56PM +0800, Yujie Liu wrote:
> > Looks like it'd be simpler to just replace the "source" commands with
> > "." and leave the shebang as is (unless there are other bash-specific
> > constructs in these scripts of course).
> > 
> > Generally speaking, I think we should avoid madating a specific shell,
> > unless that really simplifies the test script (which is not the case
> > here).
> 
> Hi Guillaume,
> 
> Thanks for the comments. As this is related with a large patch series from
> Hangbin, and other scripts use "source" during the conversion, so we may
> need some input from Hangbin.
> 
> Hi Hangbin,
> 
> Could you please share your comments on this? Would you like to replace
> "source" with "." for these two specific scripts as Guillaume suggested,
> or change the shebang from "sh" to "bash"?

Both works for me :)

Thanks
Hangbin