Received-SPF: pass (google.com: domain of linux-kernel+bounces-14105-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240102024916.19093-1-andy.chi@canonical.com>
 <ZZOQamQsHUR7eEPd@geday> <CAEzXkg3YiH_XQGz4vbFc7dptmMSWrVDrALdNJAmmQgWa17PP1A@mail.gmail.com>
 <CAEzXkg1DmR2PJ2SKF8hRdbRaPVVU8eWHjzjXHcJE-KqCU-8wqA@mail.gmail.com> <ZZOwVZN7Xn2rIKtB@geday>
In-Reply-To: <ZZOwVZN7Xn2rIKtB@geday>
From: Andy Chi <andy.chi@canonical.com>
Date: Tue, 2 Jan 2024 14:59:56 +0800
Message-ID: <CAEzXkg0NLYxgKHr4iyoJPU7aZcrtcQFBo3o_K=qHuBpXeyNvbQ@mail.gmail.com>
Subject: Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LEDs for a HP ZBook
To: Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, 
	Stefan Binding <sbinding@opensource.cirrus.com>, Kailang Yang <kailang@realtek.com>, 
	"Luke D. Jones" <luke@ljones.dev>, Shenghao Ding <shenghao-ding@ti.com>, 
	Matthew Anderson <ruinairas1992@gmail.com>, Luka Guzenko <l.guzenko@web.de>, 
	Yuchi Yang <yangyuchi66@gmail.com>, Vitaly Rodionov <vitalyr@opensource.cirrus.com>, 
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 2, 2024 at 2:42=E2=80=AFPM Geraldo Nascimento
<geraldogabriel@gmail.com> wrote:
>
> On Tue, Jan 02, 2024 at 01:49:40PM +0800, Andy Chi wrote:
> > Hi Geraldo,
> > Yes, this model is not yet publicly available, so I can't type the
> > full name on this patch.
> >
> > (change to text plain mode to send out again.)
>
Hi Geraldo,
> Hi Andy, please be kind and next time refrain from top-posting,
> as it reverses the attention order for those reading the
> discussion for posterity.
>
Got it, appreciate your feedback.
> I think it is reasonable to mention it explicitly as an
> upcoming product in order not to cause any confusion and
> to make sure there's another janitorial patch later on
> filling in the model details.
>
Should I mention it in the commit message? Or is it ok if I put the
model name after it's on the market?

> It's best to leave Takashi now to attend to your patch, and I
> congratulate both you as well as Canonical and HP for the
> effort towards bettering Linux.
Cheers :)

>
> Thanks for addressing this quickly.
>
> Geraldo Nascimento
>
> >
> > Kr,
> > Andy
> >
> >
> > On Tue, Jan 2, 2024 at 1:47=E2=80=AFPM Andy Chi <andy.chi@canonical.com=
> wrote:
> > >
> > > Hi Geraldo,
> > > Yes, this model is not yet publicly available, so I can't type the fu=
ll name on this patch.
> > >
> > > Kr,
> > > Andy
> > >
> > > On Tue, Jan 2, 2024 at 12:25=E2=80=AFPM Geraldo Nascimento <geraldoga=
briel@gmail.com> wrote:
> > >>
> > >> On Tue, Jan 02, 2024 at 10:49:15AM +0800, Andy Chi wrote:
> > >> > There is a HP ZBook which using ALC236 codec and need the
> > >> > ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make mute LED
> > >> > and micmute LED work.
> > >>
> > >> Hi Andy,
> > >>
> > >> I know Takashi in the name of smooth operation usually takes this ki=
nd
> > >> of simple patch, quickly, since it's a simple bugfix, unless there a=
re
> > >> any objections, so I must raise one.
> > >>
> > >> Which HP ZBook? Which model?
> > >>
> > >> Is this a still unreleased model Canonical has had access under a ND=
A
> > >> for example? Or perhaps there is some other reason why you cannot na=
me
> > >> the model yet?
> > >>
> > >> Either way, there is a need to publicly know the reason for the miss=
ing
> > >> model information.
> > >>
> > >> >
> > >> > Signed-off-by: Andy Chi <andy.chi@canonical.com>
> > >> > ---
> > >> >  sound/pci/hda/patch_realtek.c | 1 +
> > >> >  1 file changed, 1 insertion(+)
> > >> >
> > >> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_r=
ealtek.c
> > >> > index 7e9d8c1cedfc..1c8d5b58eb64 100644
> > >> > --- a/sound/pci/hda/patch_realtek.c
> > >> > +++ b/sound/pci/hda/patch_realtek.c
> > >> > @@ -9939,6 +9939,7 @@ static const struct snd_pci_quirk alc269_fix=
up_tbl[] =3D {
> > >> >       SND_PCI_QUIRK(0x103c, 0x8c70, "HP EliteBook 835 G11", ALC287=
_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
> > >> >       SND_PCI_QUIRK(0x103c, 0x8c71, "HP EliteBook 845 G11", ALC287=
_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
> > >> >       SND_PCI_QUIRK(0x103c, 0x8c72, "HP EliteBook 865 G11", ALC287=
_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),
> > >> > +     SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED=
_MICMUTE_VREF),
> > >>
> > >> Same questioning as above. "HP" is IMHO unacceptable without a clear
> > >> reason for the missing model information.
> > >>
> > >> Thanks,
> > >> Geraldo Nascimento
> > >>
> > >> >       SND_PCI_QUIRK(0x103c, 0x8ca4, "HP ZBook Fury", ALC245_FIXUP_=
CS35L41_SPI_2_HP_GPIO_LED),
> > >> >       SND_PCI_QUIRK(0x103c, 0x8ca7, "HP ZBook Fury", ALC245_FIXUP_=
CS35L41_SPI_2_HP_GPIO_LED),
> > >> >       SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16", ALC245_F=
IXUP_CS35L41_SPI_4_HP_GPIO_LED),
> > >> > --
> > >> > 2.34.1
> > >> >
> > >> >