Received-SPF: pass (google.com: domain of linux-kernel+bounces-14136-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Received-SPF: Pass (protection.outlook.com: domain of duagon.com designates
 194.38.86.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=194.38.86.34; helo=securemail.duagon.com; pr=C
Received-SPF: Pass (protection.outlook.com: domain of duagon.com designates
 20.79.222.204 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.79.222.204; helo=de2-emailsignatures-cloud.codetwo.com; pr=C
From: =?iso-8859-1?Q?Sanju=E1n_Garc=EDa=2C_Jorge?=
	<Jorge.SanjuanGarcia@duagon.com>
To: "davem@davemloft.net" <davem@davemloft.net>, "edumazet@google.com"
	<edumazet@google.com>, "kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>
CC: "s-vadapalli@ti.com" <s-vadapalli@ti.com>, "grygorii.strashko@ti.com"
	<grygorii.strashko@ti.com>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, =?iso-8859-1?Q?Sanju=E1n_Garc=EDa=2C_Jorge?=
	<Jorge.SanjuanGarcia@duagon.com>
Subject: [PATCH 0/3] net: ethernet: ti: am65-cpsw: Allow for MTU values
Thread-Topic: [PATCH 0/3] net: ethernet: ti: am65-cpsw: Allow for MTU values
Thread-Index: AQHaPVRZqj+KTd9jMEip8pNlXUYOqA==
Date: Tue, 2 Jan 2024 08:19:05 +0000
Message-ID: <20240102081825.14635-1-jorge.sanjuangarcia@duagon.com>
Accept-Language: es-ES, en-US
Content-Language: en-US
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=duagon.com;
X-Microsoft-Antispam-Message-Info-Original:
 9G6g1TPrwMitwDq+ZrxotPOVoypeIJ5tWdmX7cRrV7eMgNobMwjKxu5L3EsYpPRyb3SVf62o28Y0KXPsnO8M9annxr3DZ5p6qMeZhbeiqfleT0yVs8EykG9R13bkXQDUrgPm2P9TKQHa+XFRx90Vn7eroIGrXYVYcypq9lflT8E3M0mirFbqghIdzyE4m50C2V26aEtfETQqBXsT6kS0SnTKVLKG1P4D8Srm4li/GZnER4YEnJqyzKSQ8Dim5ODcLW4cRKCtmdj8hiFpo+0ico2hcrkY3VcNaFlovtQVI45L8/JRdyNSpyNZ0TA3goQZWBeyIBixIo51TFCOZA3RMALcozcHHo+NgfolKrRvu17rAWeMx4opCt8QcplsE6mOC1eoEWs8AeQpo+M9+SmSSleu4DBy5P4s8895etqO+2hfVeivByQ01fBoBrMguoyhi0Bqlbxtz4h2CYZwbR+G+rzewbe76fqFZpT4lI14lVK1AppzSmdwIVQgVlLQ+e9ZqWhTyVyUDcxpaHj5BgImFj0OhVXJr4PY6EWM8oYvypNWR2TjcfWYcFh/XauflCw3gYM+Kzy8fSDv6tZ9yNGpA93nHkl86WUxlslo7YURx3Ut1HSuBrRvWrYTGrkaf12y
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV0P278MB0516.CHEP278.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(136003)(39840400004)(366004)(376002)(396003)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(66899024)(2616005)(83380400001)(107886003)(26005)(1076003)(38100700002)(122000001)(41300700001)(8936002)(8676002)(54906003)(316002)(110136005)(4326008)(5660300002)(2906002)(478600001)(71200400001)(6506007)(6512007)(66446008)(76116006)(66556008)(66946007)(64756008)(91956017)(6486002)(66476007)(38070700009)(86362001)(36756003);DIR:OUT;SFP:1102;
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV0P278MB1093
X-CodeTwo-MessageID: 53b26e8b-600a-4bcc-a88c-74d222fe5878.20240102081907@de2-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 1
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM3PEPF0000A790.eurprd04.prod.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
 1dc2651c-b9a7-41b6-c422-08dc0b6b7c7f
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 CpaYO2Ekt9x0uiyoBHlo3BuDp1Sa84ySHs2bERuYbciCZCDw88EZNtpEDYgaKGOOnJ0oXoVUM7XJxyFoxUgptla2Z1KzN/W+Qnq+erRdPtO27vG/3I+W0NGhddxB3qEmjvZfr4vvL5FJ2UJPAhaBWdOd7nlOrfK+zszaQp0Bm31BirB4AKfcKhKPt/9C2aGw5gvyyifztZdZsgDreQrrcu/dnoySMCi/M4LQSbdkTC300OAJzU0kc39LIdcC9QrpXsD3W/XwmVQz5CMG8G+sFoHKnnzccG83OEo/R26PDexIcJcAGa9mAuHE6kAy7yE2HE02IW78vFYtNp4T7iJjRSgjoq21qWjctT7E7er19nrjLntEIHVMiTCmQu2ovFGa7eIS+qeP4OFEKFHuemtzPzQ+iGOWggVapizY2cNrkNjRPnVZOkIgYwyaOboYmCgRxSnxYNTNqR6w/bOhKyHHdXAfIEDpDxtKxUFOxif/rcEWZqWnbcVSq1xudFKLq6jr2pu4Pu8Mv3D5gEdzDJcmIwvAvGVj3fPktLlIBcliMOQCcHOnyHGEe3Odl4/2p7f6Wrx7MJV+6ITvVDOudICdUQIFqJmmnhptWO9L4EvNTewJPrDH/JANd3zegFnyNzYUj73jbzO6lQbNNqKjS5mVCJGA/JCWmueXP3k6IYwopToQeK8YzVqLwtPPoEMrzrWZLwAbTT08KIEKUGuzIRYlYw==
X-Forefront-Antispam-Report-Untrusted:
 CIP:20.79.222.204;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:de2-emailsignatures-cloud.codetwo.com;PTR:de2-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(136003)(39840400004)(376002)(396003)(346002)(230922051799003)(82310400011)(451199024)(1800799012)(64100799003)(186009)(46966006)(36840700001)(66899024)(2616005)(83380400001)(47076005)(107886003)(26005)(1076003)(7636003)(336012)(356005)(7596003)(41300700001)(8936002)(8676002)(54906003)(316002)(110136005)(4326008)(5660300002)(2906002)(36860700001)(478600001)(6506007)(6512007)(70206006)(70586007)(6486002)(86362001)(36756003)(40480700001);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV0P278MB1032
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5PEPF00014B8B.eurprd02.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	271b4999-df29-4ece-b12a-08dc0b6b812a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MtXVkmJJ85tpUS1wWbZ+uCFO7rTAA1pQe1VpS9BSDyZUpj2nF5aehgr9EYPhEsfqYUXW6clrga/0Y6o+hi4E5cYz/qcY7OBmOhNLRJ7yFF3EVk8Zb/Ylc2z0xhHHVg1vQvritD0xKFwXslrjL9ufE62jzokRDi7q0bUGZKZHyI595ra7/ZxpWL7BjjPUqds/e9Mkp/oiddOSiCr+j8SGPb+3PXAX/ZtB0tx8UvpW2lA3NcFJKrTZaYk6fGZnH+7D6XeMKpkL11Zr68fLGrbMlVyDjx9933w6JIRhiC6zXkQ5bSdfzmn8YtxvyhiSeWBGBdHfPxITAWFQRt/H/vlNT2N5Wpd4ygNXvpTsfp+yD3d4YyMgAoa9XbHQMxAUHhoGA7nzI8JRnWbEqL9ayPsfAguEzYQ0z0dLlBIkBI6jXo2z2FhGXunRk0jcn0KdhARHFYyxw9d4ryhlRhyzt3Q3h5luVj5bAaMAQ5SHZVC0WEZrzYM2MNtJ96TSuZsxK7WKY/RSyF+FxTQ1k696DkTzupBOzOrco35gFnQQwH8XiznVjLTCah21CR7smVQ5tFA5zlzCF90lSYwmqa5doSFXyxQ5WyGiVr6q0FOTdm4ZLy8lxZ1e8yEvCTKDfnJL55E1A2u0IYfPph4d802qKaLTfkVNGhCgRDxDIJhGq11JDMRsN1j38QSlt8Fkf4yXla7elPtjcOD1JiuJ7ILaha0ZIAY4n3Y6s3wwyru54XgOQVe8HRg0wAsM3GizqBxRcGGC
X-Forefront-Antispam-Report:
	CIP:194.38.86.34;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:securemail.duagon.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(136003)(39840400004)(376002)(396003)(346002)(230922051799003)(82310400011)(451199024)(1800799012)(64100799003)(186009)(46966006)(36840700001)(66899024)(2616005)(83380400001)(47076005)(107886003)(26005)(1076003)(336012)(81166007)(41300700001)(8936002)(8676002)(54906003)(316002)(110136005)(4326008)(5660300002)(2906002)(36860700001)(478600001)(6506007)(6512007)(70206006)(70586007)(6486002)(86362001)(36756003)(40480700001)(36900700001);DIR:OUT;SFP:1102;
X-OriginatorOrg: duagon.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2024 08:19:17.3152
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 457f0c84-23db-420f-f38b-08dc0b6b8388
X-MS-Exchange-CrossTenant-Id: e5e7e96e-8a28-45d6-9093-a40dd5b51a57
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5e7e96e-8a28-45d6-9093-a40dd5b51a57;Ip=[194.38.86.34];Helo=[securemail.duagon.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5PEPF00014B8B.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV0P278MB1078

The am65-cpsw-nuss driver has a fixed definition for the maximum ethernet
frame length of 1522 bytes (AM65_CPSW_MAX_PACKET_SIZE). This limits the swi=
tch
ports to only operate at a maximum MTU of 1500 bytes. When combining this C=
PSW
switch with a DSA switch connected to one of its ports this limitation show=
s up.
The extra 8 bytes the DSA subsystem adds internally to the ethernet frame
create resulting frames bigger than 1522 bytes (1518 for non VLAN + 8 for D=
SA
stuff) so they get dropped by the switch.

One of the issues with the the am65-cpsw-nuss driver is that the network de=
vice
max_mtu was being set to the same fixed value defined for the max total fra=
me
length (1522 bytes). This makes the DSA subsystem believe that the MTU of t=
he
interface can be set to 1508 bytes to make room for the extra 8 bytes of th=
e DSA
headers. However, all packages created assuming the 1500 bytes payload get
dropped by the switch as oversized.

This series offers a solution to this problem. First, the max_mtu advertise=
d on
the network device and the actual max frame size configured on the switch
registers are made consistent by letting the extra room needed for the ethe=
rnet
headers and the frame checksum (22 bytes including VLAN). Also, make the ma=
x
frame length configurable via a devicetree property to allow for MTU values
greater than 1500 bytes.

Jorge Sanjuan Garcia (3):
  net: ethernet: ti: am65-cpsw: Fix max mtu to fit ethernet frames
  net: ethernet: ti: am65-cpsw: Introduce rx_packet_max member
  net: ethernet: ti: am65-cpsw: Add device tree property to set max MTU

 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 26 ++++++++++++++++++------
 drivers/net/ethernet/ti/am65-cpsw-nuss.h |  3 +++
 2 files changed, 23 insertions(+), 6 deletions(-)

--=20
2.34.1