Received-SPF: pass (google.com: domain of linux-kernel+bounces-14150-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20230921090027.11136-1-Wenhua.Lin@unisoc.com> <20230921090027.11136-2-Wenhua.Lin@unisoc.com>
 <ZQwny/NO8qjPU7AH@smile.fi.intel.com>
In-Reply-To: <ZQwny/NO8qjPU7AH@smile.fi.intel.com>
From: wenhua lin <wenhua.lin1994@gmail.com>
Date: Tue, 2 Jan 2024 16:34:54 +0800
Message-ID: <CAB9BWheUgc6banjt_eui3SeTb6EkZtkX7dPxFvswQ9_O-a7LrQ@mail.gmail.com>
Subject: Re: [PATCH V2 1/4] gpio: sprd: In the sleep state, the eic debounce
 clk must be forced open
To: Andy Shevchenko <andy@kernel.org>
Cc: Wenhua Lin <Wenhua.Lin@unisoc.com>, Linus Walleij <linus.walleij@linaro.org>, 
	Bartosz Golaszewski <brgl@bgdev.pl>, Orson Zhai <orsonzhai@gmail.com>, 
	Baolin Wang <baolin.wang@linux.alibaba.com>, Chunyan Zhang <zhang.lyra@gmail.com>, 
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 21, 2023 at 7:25=E2=80=AFPM Andy Shevchenko <andy@kernel.org> w=
rote:
>
> On Thu, Sep 21, 2023 at 05:00:24PM +0800, Wenhua Lin wrote:
> > In the sleep state, Eic debounce has no clock and the clk of
>
> Eic --> The eic
>
> clk --> clock
>
> > debounce needs to be forced open, so that eic can wake up normally.
>
> > Fixes: 2788938b7946 ("gpio: eic-sprd: Make the irqchip immutable")
> >
> > Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
>
> The tag block mustn't have blank lines.
>

Thank you very much for your review.
I will fix this issue in patch v3.

> --
> With Best Regards,
> Andy Shevchenko
>
>