Received-SPF: pass (google.com: domain of linux-kernel+bounces-14160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <46fe66f7-dc3b-4863-96e8-7a855316e8bd@web.de>
Date: Tue, 2 Jan 2024 09:51:31 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [0/2] net/smc: Adjustments for two function implementations
Content-Language: en-GB
To: Wen Gu <guwen@linux.alibaba.com>, linux-s390@vger.kernel.org,
 netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
 "David S. Miller" <davem@davemloft.net>, "D. Wythe"
 <alibuda@linux.alibaba.com>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Jan Karcher <jaka@linux.ibm.com>,
 Paolo Abeni <pabeni@redhat.com>, Tony Lu <tonylu@linux.alibaba.com>,
 Wenjia Zhang <wenjia@linux.ibm.com>
References: <8ba404fd-7f41-44a9-9869-84f3af18fb46@web.de>
 <93033352-4b9c-bf52-1920-6ccf07926a21@linux.alibaba.com>
Cc: LKML <linux-kernel@vger.kernel.org>
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <93033352-4b9c-bf52-1920-6ccf07926a21@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:hUZsy6pPc3A=;VPcqsyEzMWFoDwN8lau7PvfZ5eV
 uJsNtOu7tQX40ByEzy+i5qrZPUPS3fB84Bzt6mRThI8mDe91NmbS3L0kwWbPlk6as9LJiZCi+
 mAfz7Yda9XCsQXX7lf8nm00MuHO1kouS1SwePHtlsMq0+tldGn8jkThJgPM5yBtQx99QrgXgZ
 Cm1+ttGCPU2F+SryubfZ1fitCsePnuDJtfMs4tg4AQWyxFM70xNFo6w/pPRj6hy4IAu/pXNzX
 2XY+AErPNAYpH5dxEk5K8pIIAHPxqz9FEtoahHcd71BaAce9icH+JvaVmD82nTDpV3iWeKxjR
 CiWdHgy3rr2Rds87Q5wTz8lfyQWS/3y/KOdZYrIkUiYcJQQ/MXTPtXGxx5n4fT0oqMhpJVSR1
 oeKfuP8nz8MkXpxRH0sp9AuBVHuCqz/3Md635hqWkQWHlvYQ3VYLa7IOF1ApuMT8yVC5JrJYm
 x+5nPt7OuBsQ1DuOCPe1MmTanja12B1SDflKHN+ZpHVfZRn9sPXb34DY9yUO/KejmIXoNbgSm
 YdJQC/b3mB74E8zeQhzwRbJv3aXQi0Av9mEeLtKQJEzyyzMMBqAcU2Fusxh7kUvlM6kHvVtEV
 0hAI+5PLlku1x17JrfCXIZMh6NO/2YnHV+anfX3ZnLOH/+KXA6lFcl1Qry6gDfBSEVWILkOme
 1dugcyiVIT1ENxKN2aWlD0JCcQ9plLgrzZE/5aohO/V9mNyrY5xdxv4O0JVozcfSqOScv4EUW
 KVLeU1lrzUu4iqhpWRCXcJHO5KmsNs0H8OFFsD04Cj9qVb8Yv5pxPVOd1YOfts9gSaCI+88F7
 uzKAeNw7LaV3P7vjtJJnlbUyuGRLknjZSx7SnLrtcACgZJ83x7bPEJDpGY73VQOZhPj9HdIte
 5ZQDwnAN37nTzFKXapV3+cXI0+cgDUDoKnG3px0DJjZ2V07j/8WnaGcRo04oWKN0fJndKTVTk
 dNuvaA==

=E2=80=A6
>> A few update suggestions were taken into account
>> from static source code analysis.
=E2=80=A6
>> =C2=A0=C2=A0 Return directly after a failed kzalloc() in smc_fill_gid_l=
ist()
>> =C2=A0=C2=A0 Improve exception handling in smc_llc_cli_add_link_invite(=
)
>>
>> =C2=A0 net/smc/af_smc.c=C2=A0 |=C2=A0 2 +-
>> =C2=A0 net/smc/smc_llc.c | 15 +++++++--------
>> =C2=A0 2 files changed, 8 insertions(+), 9 deletions(-)
=E2=80=A6
> I see you want to fix the kfree(NULL) issues in these two patches.

I propose to avoid redundant function calls at various source code places.


> But I am wondering if this is necessary, since kfree() can handle NULL c=
orrectly.

Would you prefer only required data processing in affected function implem=
entations?

Regards,
Markus