Received-SPF: pass (google.com: domain of linux-kernel+bounces-14168-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <3260e806-a708-4462-9d4e-346e54143a65@linux.intel.com>
Date: Tue, 2 Jan 2024 11:08:47 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Oops in hdac_hda_dev_probe (6.7-rc7)
Content-Language: en-US
To: Takashi Iwai <tiwai@suse.de>,
 Dominik Brodowski <linux@dominikbrodowski.net>,
 Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
 alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
 pierre-louis.bossart@linux.intel.com, kai.vehmanen@linux.intel.com,
 ranjani.sridharan@linux.intel.com, linux-kernel@vger.kernel.org,
 regressions@lists.linux.dev
References: <ZYvUIxtrqBQZbNlC@shine.dominikbrodowski.net>
 <87sf3lxiet.wl-tiwai@suse.de> <ZY7kosArPqhlCfOA@shine.dominikbrodowski.net>
 <874jg1x7ao.wl-tiwai@suse.de> <ZY_Gb8-rncuOjRq-@shine.dominikbrodowski.net>
 <87plyovwg7.wl-tiwai@suse.de>
From: =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>
In-Reply-To: <87plyovwg7.wl-tiwai@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 30/12/2023 12:03, Takashi Iwai wrote:
> On Sat, 30 Dec 2023 08:27:43 +0100,
> Dominik Brodowski wrote:
>>
>> Am Fri, Dec 29, 2023 at 06:11:43PM +0100 schrieb Takashi Iwai:
>>> On Fri, 29 Dec 2023 16:24:18 +0100,
>>> Dominik Brodowski wrote:
>>>>
>>>> Hi Takashi,
>>>>
>>>> many thanks for your response. Your patch helps half-way: the oops goes
>>>> away, but so does the sound... With your patch, the decisive lines in dmesg
>>>> are:
>>>>
>>>> 	sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:2:0-57864
>>>> 	sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:22:1 Kernel ABI 3:23:0
>>>> 	sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered
>>>> 	sof_sdw sof_sdw: snd_soc_register_card failed -517
>>>> 	sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered
>>>> 	sof_sdw sof_sdw: snd_soc_register_card failed -517
>>>> 	platform sof_sdw: deferred probe pending
>>>>
>>>> With a revert of the a0575b4add21, it is:
>>>>
>>>> 	sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:2:0-57864
>>>> 	sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:22:1 Kernel ABI 3:23:0
>>>> 	sof-audio-pci-intel-tgl 0000:00:1f.3: Topology: ABI 3:22:1 Kernel ABI 3:23:0
>>>> 	sof_sdw sof_sdw: ASoC: Parent card not yet available, widget card binding deferred
>>>> 	sof_sdw sof_sdw: hda_dsp_hdmi_build_controls: no PCM in topology for HDMI converter 3
>>>> 	input: sof-soundwire HDMI/DP,pcm=5 as /devices/pci0000:00/0000:00:1f.3/sof_sdw/sound/card0/input14
>>>> 	input: sof-soundwire HDMI/DP,pcm=6 as /devices/pci0000:00/0000:00:1f.3/sof_sdw/sound/card0/input15
>>>> 	input: sof-soundwire HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:1f.3/sof_sdw/sound/card0/input16
>>>>
>>>> Maybe this helps a bit further?
>>>
>>> Thanks for quick testing.
>>> It shows at least that my guess wasn't wrong.
>>>
>>> The problem could be the initialization order in the caller side.
>>> Can the patch below work instead?
>>
>> Unfortunately, no:
>>
>> sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:2:0-57864
>> sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:22:1 Kernel ABI 3:23:0
>> sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered
>> sof_sdw sof_sdw: snd_soc_register_card failed -517
>> sof_sdw sof_sdw: ASoC: CODEC DAI intel-hdmi-hifi1 not registered
>> sof_sdw sof_sdw: snd_soc_register_card failed -517
>> platform sof_sdw: deferred probe pending
> 
> Hm, then it might be the logical failure of that commit.
> Peter?
> 
> Without a fix in the next few days, we'll have to revert it before
> 6.7.

The fix for this was sent early December:
https://lore.kernel.org/linux-sound/20231207095425.19597-1-peter.ujfalusi@linux.intel.com/

It had the correct Fixes tag but it did not made it to 6.7-rc while
a0575b4add21 did made it.

Mark, Takashi, can you pick the fix for 6.7 (it is in -next)? I think we
might have time for it to land?

-- 
Péter