Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6437992rdb; Tue, 2 Jan 2024 01:35:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IFAf8ohUFj3eeFqaUywZoIgRjE+G42YwFzXAodDtHMmK0qFIePEbbNBS7R6ZXK2+/lvIT7Y X-Received: by 2002:a05:6512:12d2:b0:50e:9d32:fa62 with SMTP id p18-20020a05651212d200b0050e9d32fa62mr771895lfg.97.1704188149474; Tue, 02 Jan 2024 01:35:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704188149; cv=none; d=google.com; s=arc-20160816; b=DcdVpTQRfsCw6qj+jl9dwcYB6uig5LoILP4Ut+KXlo4ok7KX/JvHvEMbwKORI+5o+G XFiLIXm4Ilx7CmCFwh747BaR0o5HJUTu3YPYKIHTxWj/s+LYjuhP/cwj2Avl9bRD/Mob 4cOu/21+mEif3eHlVKw0o1lSJMbLX6i/QzuWbPA9I0wBqqZPBi62ShDX3Q+fC1bVNYar eKpDN66obAjifDlWSnoi2Hchx9+BCY1vpZSoWmUi0bEv8LI+OnWzaG0EP2+f7A0OmrUs g8rJQkYI8h4xGC0TdQc4vmxnoXG6zpQr5r3JCpaEET45umEcW/tVZJ8i9DOLgmY2PX1u JfKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=ZAVdSeO/v1c4+IKUKJw8vUW2JZIgB44WbsoyMyG7ln0=; fh=YXjNZSBjY8m8p0mwll7WN7QkxnSMuiJNJSjMnAAfAWs=; b=UPVEE8KwCHHgaU/6qOI0he1ZnQ0/ks/siCdfqgwZzvbWlIKw4MACmsux4nYnH3hLfU s+C5u5W64npxHj21wcER2lP2zwy2Dc4eo8YgJy4DtmIfhy8CRU1zOuV3ln87LzKP01HN KsX5oYFwHw2ZcGsBUKSKj8YXKpr06UMbTzErwCA+6VBFGruE//1RNF1cjUeraNJ70LyJ FHVChYF1jXXgkhdX7v+WfHBvm4mpzwHT5fWTtLv8rB6L8hjdXGpTrjY6a5izN9OklH88 L8hro9qQZMEhuyZpT2gR9VOwShufAVUixIbkeetGI7DqGp5o7xwc9Hjo+9Qg5gOwPThT TCpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=Udm2tBP4; spf=pass (google.com: domain of linux-kernel+bounces-14192-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14192-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id h13-20020a056402280d00b0055338ce8e90si11324036ede.610.2024.01.02.01.35.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 01:35:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14192-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=Udm2tBP4; spf=pass (google.com: domain of linux-kernel+bounces-14192-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14192-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 36BBF1F220F2 for ; Tue, 2 Jan 2024 09:35:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 22346CA66; Tue, 2 Jan 2024 09:35:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="Udm2tBP4" X-Original-To: linux-kernel@vger.kernel.org Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A10ED2E4; Tue, 2 Jan 2024 09:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1704188118; x=1704792918; i=markus.elfring@web.de; bh=tSNyrdvOrmxmScfoESQeoGJjZVGUwhPYL8i1sd6cwWM=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=Udm2tBP4J/pdhzcrUlquYZ/Ml4NaW2Z5Hka8bruypnqytiTwG7Nf8eqcwNJXe8lZ iz8dMSFTjAJpZEHCPH5Nd18iA2dYcFkq15GFaE7M2DhnXI9epg5/IfxH6hQCkAr/o 5f8BS6DQrr3yCjozlTMN7EyROVMS8KoJeU3Nmu+CrcQS2ErLfRggjGW0Yf/rFjBgp bSbeN+UC/GgBQYTSdGvyDXYYvjUy0sxPN0hkOvwOt7woeBaZzwk06qPZREErcazLL swGkqMY+Ev/Bb3Y6jxBq8pVzApGH57IDcfxbXTXq7IS47mkQkz3J/wZ9ZO/uzkTmu OWqODwJ6knAT0NBCzw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.91.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MIc7N-1rPqVf0ZZl-00EZ1s; Tue, 02 Jan 2024 10:35:18 +0100 Message-ID: <691350ea-39e9-4031-a066-27d7064cd9d9@web.de> Date: Tue, 2 Jan 2024 10:35:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [2/2] virtiofs: Improve error handling in virtio_fs_get_tree() Content-Language: en-GB To: Matthew Wilcox , virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org Cc: Miklos Szeredi , Stefan Hajnoczi , Vivek Goyal , LKML References: <5745d81c-3c06-4871-9785-12a469870934@web.de> <54b353b6-949d-45a1-896d-bb5acb2ed4ed@web.de> From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:WoH4l/kfnG/D1YD+yV/7PtW8vygvEXgrYZtTCzrEtR8rGb9nxd1 d2KCgCErE3OUiwfidxwk5zEYEyBK3fQnMJclRQNSL2tLRTtVqBWurw9IKowTgr/wKU18Lgz Pyq6fdyUTgT9bnpQKXz+EtFKA1pGV1KS1Gbm91FBfLm4hyYpmn5IWu3PZt7uPZgfNin6AJF 4KZy3HwzXsjySVAtkDofA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Cbq+ZiV+SZY=;Jt3xakHM8aRBkoWFImzl9NKcJMc Jt61HqtLCDFYLCp0v/8MdPdAs8HNbzVdui4BKaK/9i9/8NwiMp2ciQ/uDrdLcxs4QL5AjfjaV Sogs1IW0o69j9NWQPFZ5XkJfGL0oC5Pq2vWOmMFU34GT77pMbtKSKwKmrZCDOrC20ueIWJsvc +GS1UM/dYfPgMCLMu+f3G2pWvYRfT+0mxEMSl4elkSydgQ3MAbcHt0Sq5i1qFb94PrFgVsNC3 jsd9iTcKEe02bfabtUrT2uQR+en9ZTamWsEJdCBZb3OtfruBvuFaL3C/sAQK2y3WkjPc+8gwB Mb2s0xrA0gDA0BAiDij6xeTCgGDUFLe1HxkouFj5xoMlYjqEctBDMtc8JyiZCSXOJWtPqZcqr 4JlwO7FPw8n/lnrLZygREIQx/ODLs3mIN75vvgFX/aXXkHEc5d2/B5wPt4envf2PVuL4O1rU7 P7E+EyrWBK4NXmXc6rVyVJq+0+SPRSIKqX4u4pK6+oMTtxT2sLawUlXJrYvHJwC9BAH/S1r3j b/l/DSSdMzoeQ9bfnsUeqm8ab4BZKIPcRLtQIasrG5lsl/LiS0wKH21Avgi5+RpSQSna48Pq/ q2Rmn6anSCzcn0QohSbUXP1mmakNf8z0kTmhqPQfl4wyqoTa+u+SHZqooywxt8+IXRxCPXntL ZMurQ2W5DVhHha4v+0+d7HNcLd3T507P6MNE18vEeD75hJd25FCby1WwNlzhnPLxd5d9krc1I HDKHNKtvK+B6pTrsEw/pRwJ2ESrqFvL31Wlf2XZ8K7335Fe5775Hs3NVW2Rp8XAbmrkBmTF1w TmaZYDZL5hAqrJt7W/X6wJBHr7faUIZBhBE2IDYnyUs/6RS3+4CjGlRhN9DhlpvB9MeeTwfvS SHrnQrz3Hdo3EyW5yNYP/IBs6cIBNlM8ExDxkIZLaqkTwUZaBenMFAOr+l2c1S1AAGAj+t8HN YkO4Bg== >>> So what? kfree(NULL) is perfectly acceptable. >> >> I suggest to reconsider the usefulness of such a special function call. > > Can you be more explicit in your suggestion? I hope that the change acceptance can grow for the presented transformatio= n. Are you looking for an improved patch description? Regards, Markus