Received-SPF: pass (google.com: domain of linux-kernel+bounces-14200-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <0bfa27e8-c173-4a2a-b453-9289f2eb1926@collabora.com>
Date: Tue, 2 Jan 2024 10:41:45 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] clk: mediatek: fix cppcheck error for uninitialized
 variable
Content-Language: en-US
To: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com,
 kishan.dudhatra@siliconsignals.io
Cc: Chen-Yu Tsai <wenst@chromium.org>, Tom Rix <trix@redhat.com>,
 linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
References: <20231225152806.3716898-1-user@falcon>
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20231225152806.3716898-1-user@falcon>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Il 25/12/23 16:28,  ha scritto:
> From: Kishan Dudhatra <kishan.dudhatra@siliconsignals.io>
> 
> cppcheck reports below warning
> 
> clk/mediatek/clk-fhctl.c:206:27:
> error: Uninitialized variable: pll_postdiv [uninitvar]
> if (postdiv && postdiv < pll_postdiv)
> 
> This is due to uninitialization of variable pll_postdiv,
> which is now initialized as part of this patch.
> 
> Signed-off-by: Kishan Dudhatra <kishan.dudhatra@siliconsignals.io>

This is a false positive... the pll_postdiv variable is *always* used
and *only if* postdiv > 0.

P.S.: There was some problem with your email, as the From entry is empty.

Regards,
Angelo

> 
> diff --git a/drivers/clk/mediatek/clk-fhctl.c b/drivers/clk/mediatek/clk-fhctl.c
> index 33b6ad8fdc2e..b0e71e4fd938 100644
> --- a/drivers/clk/mediatek/clk-fhctl.c
> +++ b/drivers/clk/mediatek/clk-fhctl.c
> @@ -186,7 +186,7 @@ static int fhctl_hopping(struct mtk_fh *fh, unsigned int new_dds,
>   	struct fh_pll_regs *regs = &fh->regs;
>   	struct mtk_clk_pll *pll = &fh->clk_pll;
>   	spinlock_t *lock = fh->lock;
> -	unsigned int pll_postdiv;
> +	unsigned int pll_postdiv = 0;
>   	unsigned long flags = 0;
>   	int ret;
>