Received-SPF: pass (google.com: domain of linux-kernel+bounces-14210-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <MN2PR12MB44863139E562A59329E89DBEB982A@MN2PR12MB4486.namprd12.prod.outlook.com>
 <CANn89iKvG5cTNROyBF32958BzATfXysh4zLk5nRR6fgi08vumA@mail.gmail.com>
 <MN2PR12MB4486457FC77205D246FC834AB98BA@MN2PR12MB4486.namprd12.prod.outlook.com>
 <CANn89i+e2TcvSU1EgrVZRUoEmZ5NDauXd3=kEkjpsGjmaypHOw@mail.gmail.com>
 <cdf72778-a314-467d-8ac8-163d2007fd70@leemhuis.info> <20231227083339.GA6849@unreal>
In-Reply-To: <20231227083339.GA6849@unreal>
From: Eric Dumazet <edumazet@google.com>
Date: Tue, 2 Jan 2024 10:49:58 +0100
Message-ID: <CANn89iK_Q38g1ieEb1MVvmVgiKQxmv9Hzngu_pCcXcwGs7cPLQ@mail.gmail.com>
Subject: Re: Bug report connect to VM with Vagrant
To: Leon Romanovsky <leon@kernel.org>
Cc: Linux regressions mailing list <regressions@lists.linux.dev>, Shachar Kagan <skagan@nvidia.com>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>, "kuba@kernel.org" <kuba@kernel.org>, 
	Jason Gunthorpe <jgg@nvidia.com>, Yishai Hadas <yishaih@nvidia.com>, Ido Kalir <idok@nvidia.com>, 
	Topaz Uliel <topazu@nvidia.com>, Shirly Ohnona <shirlyo@nvidia.com>, 
	Ziyad Atiyyeh <ziyadat@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 27, 2023 at 9:33=E2=80=AFAM Leon Romanovsky <leon@kernel.org> w=
rote:
>
> On Fri, Dec 15, 2023 at 10:55:05AM +0100, Linux regression tracking (Thor=
sten Leemhuis) wrote:
> > On 08.12.23 11:49, Eric Dumazet wrote:
> > > On Thu, Dec 7, 2023 at 2:03=E2=80=AFPM Shachar Kagan <skagan@nvidia.c=
om> wrote:
> > >>>> On Thu, Nov 30, 2023 at 2:55=E2=80=AFPM Shachar Kagan <skagan@nvid=
ia.com> wrote:
> > >>>>
> > >>>> I have an issue that bisection pointed at this patch:
> > >>>> commit 0a8de364ff7a14558e9676f424283148110384d6
> > >>>> tcp: no longer abort SYN_SENT when receiving some ICMP
> > >>>
> > >>> Please provide tcpdump/pcap captures.
> > >>>
> > >>>  It is hard to say what is going on just by looking at some applica=
tion logs.
> > >>
> > >> I managed to capture the tcpdump of =E2=80=98Vagrant up=E2=80=99 ste=
p over old kernel and new kernel where this step fails. Both captures are a=
ttached.
> > >> The tcpdump is filtered by given IP of the nested VM.
> > >
> > > I do not see any ICMP messages in these files, can you get them ?
> > >
> > > Feel free to continue this exchange privately, no need to send MB
> > > email to various lists.
> >
> > Here this thread died, so I assume this turned out to be not a
> > regression at all or something like that? If not please speak up!
>
> No, it wasn't fixed and/or reverted. Right now, Vagrant is broken and
> all our regressions around nested VM functionality doesn't run.
>
> Eric, can you please revert the bisected patch while you are continuing
> your offline discussion with Shachar?
>

This is not how things work.

I have not received any evidence yet, only partial packet dumps with
no ICMP messages that could be related to the 'Vagrant issue'

Patch is adhering to the RFC.

If an application wants to have fast reaction to ICMP, it must use
appropriate socket options instead of relying on a prior
implementation detail.