Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6451978rdb; Tue, 2 Jan 2024 02:17:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDmZpZF3FhTutuQYYLNOWOhXj08yAQ1mP6QD2n5tMeD1aoofQ7uv4TIL1LZ1RwaeY5CCLA X-Received: by 2002:a05:6358:999e:b0:173:836:23cd with SMTP id j30-20020a056358999e00b00173083623cdmr11602471rwb.26.1704190661204; Tue, 02 Jan 2024 02:17:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704190661; cv=none; d=google.com; s=arc-20160816; b=PqDAbz9Nra2LBbZa0Jz2J3+FMEBeL0DP1Arr0Dl6WufWs/ZfTF+ci0pr2t5Q5MLW3M rbMdR3M+WtSNyhBVqiWLyjVKWuEKumnT46HepWGCcEG2+0B9Wsh3TeKglgrlGjiDYtSn u1W22rB6F13pZ1aKN4jPGNsFTCZw2Pl/8El9etCHkD+hguekDaL8r5wfPZoDurhBB6A+ Hbi26NfU5ZAwUcoUNWx+qAwVwK/YDjJxmOwYH82VsagLq/UEkImuG2FWnNEqUJpiIMkU TMHohXaTFUiaLU/Vf7E7gsWH9Kk4E8+gHIV514WUvaPPojbcoqMakWSUtgn4wjoRQCHF 6VRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9XzDx6zZ6qJD2AqPIsRJuoeK0l+mVQ9Fy8pq/VyTgQM=; fh=XBbqqbjR4GSvHAHDNJgFyWZ8SAzjGmTEgS58s1j/Tr4=; b=Ecmzxwq/4ThGBfVbrQ4vJJaTk/dcuFT+ksyTlWqfupmJNt9qkqfBd+4XrtrXqFmiIc yjuk24Ig2hTqO4ZpZQXa1WmaQ/bjeXUWsnVkwL6KZoesaW1nni18DB+w4bjT/E/1K4ia iXTO9zoPGA7CnR6wW4qxXuZPPgiyOqwdKHLv6oyCwYfyYcnaTrNWVLiau5hb4Eph2zvw QEhz3ALBWtxtzWGV+GABXG0JVzeBPKp+gVtMf5bfVEUJS0RmcqnPTosBfMQ6OVtr8O2F 70sPNZVZY6CMJMkrcouUzB4Bi6Mx5gwBin/QgeSTYD8k57G43yDwnXajk21w6PZmMOUv cPqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=sb5aHNMh; spf=pass (google.com: domain of linux-kernel+bounces-14229-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14229-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id sh7-20020a17090b524700b0028c65b770d1si13464544pjb.167.2024.01.02.02.17.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 02:17:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14229-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=sb5aHNMh; spf=pass (google.com: domain of linux-kernel+bounces-14229-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14229-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D451F282E48 for ; Tue, 2 Jan 2024 10:17:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 28CD0D2FD; Tue, 2 Jan 2024 10:17:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sb5aHNMh" X-Original-To: linux-kernel@vger.kernel.org Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFCE2D268; Tue, 2 Jan 2024 10:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9XzDx6zZ6qJD2AqPIsRJuoeK0l+mVQ9Fy8pq/VyTgQM=; b=sb5aHNMhiZ0qDUzXBTFXlfZcgu kobm8NLF+hVBiee4q3GhgkRaQw8wzIsvH0uynPzXhfimS7OvE8R/GpYmSKUrKOMgGyEZvRx+yfRkF SAGfiyTOF/GTApBL3R8noyyhQVD60PFSovEXGXz0VrUimOwv1qpe7nepDDPrenMJTOScCdNz7mtbs ogJnopbaKSLIhGgjab4Ew8nZRv0f1YgRajZ5vgy//W8a4pZbzpmnONzOgxhA+tOfC98J3bh61eqeQ 7LArNYPuQGCu52EePosEYuW37VF+nkHKtOjiWdYFLgLFFf7iAyNMFhatIf4KmoEvU89SZTiCi8QdC BMpIMftg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rKbpo-009y51-79; Tue, 02 Jan 2024 10:17:20 +0000 Date: Tue, 2 Jan 2024 10:17:20 +0000 From: Matthew Wilcox To: Markus Elfring Cc: virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org, Miklos Szeredi , Stefan Hajnoczi , Vivek Goyal , LKML Subject: Re: [2/2] virtiofs: Improve error handling in virtio_fs_get_tree() Message-ID: References: <5745d81c-3c06-4871-9785-12a469870934@web.de> <54b353b6-949d-45a1-896d-bb5acb2ed4ed@web.de> <691350ea-39e9-4031-a066-27d7064cd9d9@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <691350ea-39e9-4031-a066-27d7064cd9d9@web.de> On Tue, Jan 02, 2024 at 10:35:17AM +0100, Markus Elfring wrote: > >>> So what? kfree(NULL) is perfectly acceptable. > >> > >> I suggest to reconsider the usefulness of such a special function call. > > > > Can you be more explicit in your suggestion? > > I hope that the change acceptance can grow for the presented transformation. > Are you looking for an improved patch description? Do you consider more clarity in your argumentation?