Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6459368rdb; Tue, 2 Jan 2024 02:39:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IF20XKFzE1rTZ8cg07JH7n0X942TF2W5/VD+vVbpK60N+28abjCa1b6gKVN+Xax5ZlCs8oL X-Received: by 2002:a17:90a:46cf:b0:28c:6ef:c086 with SMTP id x15-20020a17090a46cf00b0028c06efc086mr8354485pjg.60.1704191946466; Tue, 02 Jan 2024 02:39:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704191946; cv=none; d=google.com; s=arc-20160816; b=BQ5jXhDJpyBfWNH/F4EBfp+UQATiO1uGW6Y0XNbiL6sQM/ERCqJjOlQ7mUM3iHAXZH 6hF4ksnZME49SHo88T4vljsvu2ENeV1oioeoldnXweNWWUOdDwuQtgjzz0JgwETvsJ0p ZZ/ap5PoCM3BXORkbiZaQpM29ZeZ64BVO+XLViPkuKItwhWNpD4EokvPQTWUdX2ojL/D NlxLFCtVP8QEHNQykJUc4WJ06Hg8uqtjduZh3sxEX73FkVGCs3bTdqm6b00CmTiwq2En uxZVx01ybHHBCDQN1rAJZigW/7R4iN+ILhgPth79kGtyObnq4hNTvKaGdyzalA9hXkDP qYrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature; bh=dD/7vrp7PobLXT38gn14ZFy05WSFmJZV0dJfDmvXWWw=; fh=7qMSPsGL3VA+UOfHZl36Fh0ESduI56qOSuPYNEdtYLk=; b=mXLlmprai574hn3bWFB8NovlQ9ubkfKo9oBTXE8ZiJbvfzxPq6lvZQw6keEXfA5LUl bOwGGqUCXCmzejaKRfFDoNewimUDRMC4MtITcdIVSRmc+QCftfIIRus5pt21GDnxr82O VOAUAZeV4R6rqHV2YGmhEjOKqmbUURTdUm0tnmtsgB/aNvwhnobxvRp41x/4gbf+jBEQ JyLXBPlxczY3Og3+dtrkOnRAgCsjE2KAQ+GHH5rCWiTqwS7g4h9+otp0cezxo3ytYvO2 GCJ0VkjCYn97rMZUugZLwJrw4uNpLOibwwGU0xOvZLUiV86y7iPvbq66BgDjcEoHK98J f5gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="MkugAq/n"; spf=pass (google.com: domain of linux-kernel+bounces-14256-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14256-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d9-20020a170902cec900b001d489431171si9015950plg.488.2024.01.02.02.39.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 02:39:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14256-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b="MkugAq/n"; spf=pass (google.com: domain of linux-kernel+bounces-14256-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14256-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7D8E7B21DB6 for ; Tue, 2 Jan 2024 10:38:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9F90BEAF6; Tue, 2 Jan 2024 10:38:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="MkugAq/n" X-Original-To: linux-kernel@vger.kernel.org Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D659DF78 for ; Tue, 2 Jan 2024 10:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id BA2D21BF207; Tue, 2 Jan 2024 10:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1704191889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dD/7vrp7PobLXT38gn14ZFy05WSFmJZV0dJfDmvXWWw=; b=MkugAq/n3uM4OqEQwTq+Sdy2Wq4rqMTOHhKGGp05cyzvbwP+BIGAaG1BkXK6/vcArPorrx FoGa92KcNRVU2jiAmr5qQhCxO57rNuu4rC1WAl7gWYGFYgFIjQ4qKTRZUSePnfDOaJzWeq 9/s94EXdNPWOHtgjLV9nmnkwUPdGZoPY7ZLFCxxxgEf0w/bSKyqLRODjx9N162eVa1LNeO M8M+NXzadTH3aQkBaYijCWjjUYSl8aLeoYXAXuJIHNmJ3DO7pZgL6JtHCtVvehb5dr033b zE6JUPzC7PNAwY+F1SYJ1CPabqqlLLrUmxV9qX07QLFqVeZePzLVl/f6BN3fYA== Date: Tue, 2 Jan 2024 11:38:06 +0100 From: Miquel Raynal To: Elad Nachman Cc: , , , , , Subject: Re: [PATCH] mtd: rawnand: marvell: fix layouts Message-ID: <20240102113806.3fa88503@xps-13> In-Reply-To: <20231231174950.3272727-1-enachman@marvell.com> References: <20231231174950.3272727-1-enachman@marvell.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Elad, enachman@marvell.com wrote on Sun, 31 Dec 2023 19:49:50 +0200: > From: Elad Nachman >=20 Please fix your mailer because this paragraph is way too small (<50 chars!). > Check in nand_base.c, nand_scan_tail() : > if (ecc->steps * ecc->size !=3D mtd->writesize) > Fails for some NAND chips. > Remove entries which cannot create integral > multiplications, and adjust the number of chunks > for entries which fails the above calculation to > calculate correctly (this was previously done > automatically before the check). I'm okay with that. > Also fix spacing of the said table. No, please don't do this in the same commit, it becomes totally unreadable. Please keep the spacing as it is, or if you want to change the spacing, keep additional spaces so that it is easily readable by keeping clear columns. >=20 > Fixes: 68c18dae6888 ("mtd: rawnand: marvell: add missing layouts") Please add: Cc: stable@vger.kernel.org > Signed-off-by: Elad Nachman > --- > drivers/mtd/nand/raw/marvell_nand.c | 27 ++++++++++++--------------- > 1 file changed, 12 insertions(+), 15 deletions(-) >=20 > diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/m= arvell_nand.c > index a46698744850..21f4469b5cda 100644 > --- a/drivers/mtd/nand/raw/marvell_nand.c > +++ b/drivers/mtd/nand/raw/marvell_nand.c > @@ -285,21 +285,18 @@ struct marvell_hw_ecc_layout { > =20 > /* Layouts explained in AN-379_Marvell_SoC_NFC_ECC */ > static const struct marvell_hw_ecc_layout marvell_nfc_layouts[] =3D { > - MARVELL_LAYOUT( 512, 512, 1, 1, 1, 512, 8, 8, 0, 0, 0), > - MARVELL_LAYOUT( 2048, 512, 1, 1, 1, 2048, 40, 24, 0, 0, 0), > - MARVELL_LAYOUT( 2048, 512, 4, 1, 1, 2048, 32, 30, 0, 0, 0), > - MARVELL_LAYOUT( 2048, 512, 8, 2, 1, 1024, 0, 30,1024,32, 30), > - MARVELL_LAYOUT( 2048, 512, 8, 2, 1, 1024, 0, 30,1024,64, 30), > - MARVELL_LAYOUT( 2048, 512, 12, 3, 2, 704, 0, 30,640, 0, 30), > - MARVELL_LAYOUT( 2048, 512, 16, 5, 4, 512, 0, 30, 0, 32, 30), > - MARVELL_LAYOUT( 4096, 512, 4, 2, 2, 2048, 32, 30, 0, 0, 0), > - MARVELL_LAYOUT( 4096, 512, 8, 5, 4, 1024, 0, 30, 0, 64, 30), > - MARVELL_LAYOUT( 4096, 512, 12, 6, 5, 704, 0, 30,576, 32, 30), > - MARVELL_LAYOUT( 4096, 512, 16, 9, 8, 512, 0, 30, 0, 32, 30), > - MARVELL_LAYOUT( 8192, 512, 4, 4, 4, 2048, 0, 30, 0, 0, 0), > - MARVELL_LAYOUT( 8192, 512, 8, 9, 8, 1024, 0, 30, 0, 160, 30), > - MARVELL_LAYOUT( 8192, 512, 12, 12, 11, 704, 0, 30,448, 64, 30), > - MARVELL_LAYOUT( 8192, 512, 16, 17, 16, 512, 0, 30, 0, 32, 30), > + MARVELL_LAYOUT(512, 512, 1, 1, 1, 512, 8, 8, 0, 0, 0), > + MARVELL_LAYOUT(2048, 512, 1, 1, 1, 2048, 40, 24, 0, 0, 0), > + MARVELL_LAYOUT(2048, 512, 4, 1, 1, 2048, 32, 30, 0, 0, 0), > + MARVELL_LAYOUT(2048, 512, 8, 2, 1, 1024, 0, 30, 1024, 32, 30), > + MARVELL_LAYOUT(2048, 512, 8, 2, 1, 1024, 0, 30, 1024, 64, 30), > + MARVELL_LAYOUT(2048, 512, 16, 4, 4, 512, 0, 30, 0, 32, 30), > + MARVELL_LAYOUT(4096, 512, 4, 2, 2, 2048, 32, 30, 0, 0, 0), > + MARVELL_LAYOUT(4096, 512, 8, 4, 4, 1024, 0, 30, 0, 64, 30), > + MARVELL_LAYOUT(4096, 512, 16, 8, 8, 512, 0, 30, 0, 32, 30), > + MARVELL_LAYOUT(8192, 512, 4, 4, 4, 2048, 0, 30, 0, 0, 0), > + MARVELL_LAYOUT(8192, 512, 8, 8, 8, 1024, 0, 30, 0, 160, 30), > + MARVELL_LAYOUT(8192, 512, 16, 16, 16, 512, 0, 30, 0, 32, 30), > }; > =20 > /** Thanks, Miqu=C3=A8l