Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6486454rdb; Tue, 2 Jan 2024 03:50:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+ooyAbi8s96bofGX+zz7871UxWck6m3TZOsp1C335Ipe8wjS8dEL3xteaQ+JlaecO3vpD X-Received: by 2002:a17:906:a3c7:b0:a23:6c99:403a with SMTP id ca7-20020a170906a3c700b00a236c99403amr6973365ejb.124.1704196248571; Tue, 02 Jan 2024 03:50:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704196248; cv=none; d=google.com; s=arc-20160816; b=olOyBrLI/EMJhtYWctg3pTbDcZbtGHmBaT+ji5TNKA2SpF/ypQ3jL26Za8KskDy816 F+VTeyOLejuywUjG3gNsz0NbX1qx8fYDmZ9ITPZMKXMGcBOPGhQeWKdHqZgxjM0oFgGC OynTY4rHW+YgEJNB7zIuT2vmHDeuN5nDuLLAnefqQhysnzOCZItYLu4B3r4lPpKqKWkg aBTfZGYzRd387+H7/jNYsLDdnNXqtUkiZF+iGLUncPkiZC9Aug1aPdkM3C5qLvhuD1lY qHYE3v0UZQ4fe+ZluSje+ysIOXo6taj8geOEbixc88Mgqnai1tPsvCcZdMl7rhRdrPM9 53Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=c4TSuFiFOOo9FkY+Aknv57saIRU7nXw1AKJdpOYp6bU=; fh=WcjzOf0xhz+M81/rkY6LJffFu8e7+kIY2pdrQoytcng=; b=N6tb7lnYfbxrkGBlxM2L2maVU6cEq+IxhaY/SafjOyP9/IFyTnIT2hbM4YM0g1imbM RLWQ4/QZs74nrZJSdLAGLByJSlgrohew3p67P7Ll7Igi6cdxjFmSUULsNJ0qDDr5BXZ/ aUiAB44J0pjLOsLgSlFKCaJaEPjwiosnxSYXstSh9bJqLFnk6qXIwmDg3MnKfcjtSNik wf7D1qRMYwB9alC8kSq83S8Rm6WJo8cyRGd1kyDll9xlQuWb7WqmYQ2Inn3lgN5WXi24 YlrJ8KcmBm3RU4WtTDTuS0AEyHdbZnnOBEScKkADc5mRoLY82//FcqK4mANVfiOplJDC nEPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=nhQYPxq8; spf=pass (google.com: domain of linux-kernel+bounces-14311-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14311-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id js18-20020a170906ca9200b00a27e2b27455si1853947ejb.1024.2024.01.02.03.50.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 03:50:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14311-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=nhQYPxq8; spf=pass (google.com: domain of linux-kernel+bounces-14311-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14311-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4EEBE1F21327 for ; Tue, 2 Jan 2024 11:50:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1CB19EEC6; Tue, 2 Jan 2024 11:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="nhQYPxq8" X-Original-To: linux-kernel@vger.kernel.org Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7833EAD6; Tue, 2 Jan 2024 11:50:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1704196212; x=1704801012; i=markus.elfring@web.de; bh=c4TSuFiFOOo9FkY+Aknv57saIRU7nXw1AKJdpOYp6bU=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=nhQYPxq8uh/DsiJfbSD/ZPWYUxY5BYviPSL00BaXEsbLfe7JvmJMOMkj9OcILX15 817sRbxkylDOgrszH8R0ws/p6HMkxVdnjGaV/bOVB1m/JLMoNVI31OPkzay9QX+Oh o19QLFZWeE7/QckgWesRsXK7stwrom1UVU1LRn8MJGSFNIeafjFfzfJYmCTSYvi1O svgQpGrWYdJ9mz01AEJOLQ8zCvbDIkpHRT++oJQ7jiSCjVc3oS3mii7tTjfbI5VEm 4jKjLPYOor5vOfHWmmZnX7k7B8ZBh1pngSrguVXGpIDDrmu8KNPTdZ3cuU7s6qNBq 7sEFUbkO1Irof+6Tkg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.91.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MbCE0-1qnUOS0Qfo-00bkVR; Tue, 02 Jan 2024 12:50:12 +0100 Message-ID: <96b9d2b8-3f44-4880-a33d-dc281ca70161@web.de> Date: Tue, 2 Jan 2024 12:50:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [0/2] net/smc: Adjustments for two function implementations Content-Language: en-GB To: Wen Gu , linux-s390@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, "David S. Miller" , "D. Wythe" , Eric Dumazet , Jakub Kicinski , Jan Karcher , Paolo Abeni , Tony Lu , Wenjia Zhang Cc: LKML References: <8ba404fd-7f41-44a9-9869-84f3af18fb46@web.de> <93033352-4b9c-bf52-1920-6ccf07926a21@linux.alibaba.com> <46fe66f7-dc3b-4863-96e8-7a855316e8bd@web.de> From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:fL22ir/94IlqNcjBk73dNW87D7iDSGg7z9ik73BWj7mqMtrTvxh j+V9tmvjN/oBHQTcXKjyUlbz3eVckEpzjzWYSCgCStu4IH79TjDwOhFqMshus/jKKTSgGIY rqXC07CnQD7oPULw0+ZLswbR+d/b/VBPwTupByi9JreZXuUA3i3T0dGgOyA8KXB+bawOhJ4 RrrxHyhx+OYjJU0q/VPqQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Bon9xkLkqc8=;BnGmEViRLyUtFIXl3mCxKGATLqw pg2MakC/MQKfjCQ+3t0bzwv7sHnRbqUIiozRqCB8o86tq4YWYnIgcWMcpyk15T0OBMDVrlZ2w llH6+NCrXeDIIE/GdpEcPZKnFL3zW8EfGWLhDB202qTStn3fb5IyThYL0pUkurRXSwceT4gzl K2I6YaCW1L/ydJCsYcSHFUbMIrTIlemhKQyJR9pD0PX///iXL92dE8g0Wxu3pZhzdzfcURp7q MZ53REf/aWHcI5jlyk8qoPseJBR9x3Ayp9zl+ptbHBKLJR2uYq4HmroOW+dYBX62RGlOp656t W+P8ZadbS1FViPLO/hw/vOcYQShrMo/meWOLTk689yhtzOq2LcRe2YzsIRnMNM/uXm46BGjIU 5DjzCqTcElqHEeTNBKLrVmp/7W44TuBW8iheLNgMyCeY3cxfrCGhAC0a+Z+a9tLm8c40dNjn2 +n14/PePywSVpsEhKAef0Pfu9kwnizTnTlPVklgnbQePWpMjO5wNMfdN9NqZcOKG+KUOw6GF0 rE7ps+C0dKhKjbePgohzTtTbL9A369WIvUaVRCIQ2v9xDO/aoHVaG8Zm1PWTCRNiDhibr1td2 Z+Kc/pfIqKUdH0tIr5SRnZaqjpqLwMEplazIJfjAlpwKWTUfFR79mhD1XmSXS/W56+ZTbLP8s jg6O3r/TT41is4GxocTX1xL/SadkD9Ty063dQX8yZBE7rHYtG0HR82t5Ht+9V6W8Scpu2QdYK BEDmZbaUZy1OrFJvjvojzS91W9cPfVj3bLOlFJ9CxnLwBYSdpz596XdttJdO5fezssb5UL0nY ckjjslAnhdvWJDRy5DG+Y0gh3kcyZUN/eC5h5+HuZOK0wAAWSTf/tpXM1nKx3ctaHuSvCmiUG 39J0FlLtvb75LZm9jRRhrMCQLPeNh/gsg2crET3gd7RJXKoBf9hkFGpKW1eZhMJKHWeAeneAu jbHFQIvsIoCsgrAWxOMBCZ+1u88= > But it is not very attractive to me since the calls occur on low-frequency paths > or unlikely condition, resulting in limited performance loss and the current > kfree() usage is fine and common. The prioritisation of development activities influences progress in related areas. > So what is the benfit? * Source code clarity * Nicer run time characteristics See also: https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources > I noticed that some other discussions are on-going. It seems like you are trying > to change other similiar places. I would appreciate if improvements can be achieved also for similarly affected software components. Regards, Markus