Received-SPF: pass (google.com: domain of linux-kernel+bounces-14344-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <f572489d-cdd7-4582-a355-ba0a917cf1f8@redhat.com>
Date: Tue, 2 Jan 2024 13:31:12 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86/intel/pmc: make lnl_d3_fixup static
Content-Language: en-US, nl
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, irenic.rajneesh@gmail.com
Cc: david.e.box@intel.com, ilpo.jarvinen@linux.intel.com,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
 Abaci Robot <abaci@linux.alibaba.com>
References: <20231229020808.55840-1-jiapeng.chong@linux.alibaba.com>
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20231229020808.55840-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Jiapeng,

On 12/29/23 03:08, Jiapeng Chong wrote:
> The lnl_d3_fixup are not used outside the file lnl.c, so the
> modification is defined as static.
> 
> drivers/platform/x86/intel/pmc/lnl.c:503:6: warning: no previous prototype for ‘lnl_d3_fixup’.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7811
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Thank you for your patch, but this has already been fixed
in the current version of the code, see:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/tree/?h=for-next


Regards,

Hans

> ---
>  drivers/platform/x86/intel/pmc/lnl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/pmc/lnl.c b/drivers/platform/x86/intel/pmc/lnl.c
> index 88b35931f5df..f18fdc68fd94 100644
> --- a/drivers/platform/x86/intel/pmc/lnl.c
> +++ b/drivers/platform/x86/intel/pmc/lnl.c
> @@ -500,7 +500,7 @@ const struct pmc_reg_map lnl_socm_reg_map = {
>   * Set power state of select devices that do not have drivers to D3
>   * so that they do not block Package C entry.
>   */
> -void lnl_d3_fixup(void)
> +static void lnl_d3_fixup(void)
>  {
>  	pmc_core_set_device_d3(LNL_IPU_PCI_DEV);
>  	pmc_core_set_device_d3(LNL_NPU_PCI_DEV);