Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6507733rdb; Tue, 2 Jan 2024 04:33:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHd66bq9yEh0ebnvFOJ3N/dzTu+sv1FAHaYiN8fSYiK46dvlHLjjzZwVxxxrmzU8H3v4lCB X-Received: by 2002:a62:e903:0:b0:6d9:bb58:fe30 with SMTP id j3-20020a62e903000000b006d9bb58fe30mr5013478pfh.23.1704198789223; Tue, 02 Jan 2024 04:33:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704198789; cv=none; d=google.com; s=arc-20160816; b=EOjEQHrVYW2DFFPTUuls1vdT5TLQtIgiBTLIzwHAwxcBd+aT5jpPgpobItEWII7DpP Cq5OfDPZUeIpoxkJRHjAg2X5D9mnIcodmk2gil153SWrIThjMxYeS5o3eEVSApb7nvlq Di8MyM4hWXMy0yZFHPY0+fVsVy+cKlzaKeR5SzgiCzVlXE+58E+Zi3L1C5mZrx9MnTin GYZfKy8G0fsPMIbekUqHoSbA1aYx/09GNDTLfE5TLEhhkkI49bNZ2BzOsHZDGMSy7oug atLJhI68yq63HKIvMlLm0guFvh64IgqmHYOqRjQHnfCoq+PX/UeZT+ZF1GpGGUC3Lm9S G8lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZHxpMl7RDbETrERTXnhnaCC4nYMHBRO8LgTCdUl7ypU=; fh=V0tmMrXZuorSCkrvLEH17wGExRBePH7OF7KE1O+h2YE=; b=iytwQmG6f2lPczDivjDDc6oyP4hDxdPliu8w2mck9Kx8a/qNkPIwbF5NnMbYyzISW6 NvWE7galqrRdh3TfhGnncOMLWv0AobSuh9GR2Qb09qJ1cPmqvTewnCE4ZjQfi533b8TI Zp8bQr2YxVfHZx8cw4qmT6OI4vC4I3kIl526ozxCsvGkICKk5uvn8F6AOMVYlOK2yKZI Yok69oteGOzV8bJaZvOLuAtTElWiDtCuShVr7CfAPyXQO2D/Hg3cQL2B0ZKjGlHP6dZU dd5A8dvzbw5+MPP2d4Mku38bf5xy0XPu7e3rXYhlGpGN9CfzmdZod0q+ms4TOzljClsY kfag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CQUGF7Kl; spf=pass (google.com: domain of linux-kernel+bounces-14346-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14346-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s8-20020a056a00178800b006c0e02cdadcsi13994833pfg.208.2024.01.02.04.33.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 04:33:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14346-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CQUGF7Kl; spf=pass (google.com: domain of linux-kernel+bounces-14346-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14346-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D467D282E84 for ; Tue, 2 Jan 2024 12:33:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 67DBFF9C4; Tue, 2 Jan 2024 12:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CQUGF7Kl" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E641F4FC for ; Tue, 2 Jan 2024 12:33:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704198780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZHxpMl7RDbETrERTXnhnaCC4nYMHBRO8LgTCdUl7ypU=; b=CQUGF7KlclpXzeXkZPtSJV6Ta2f4Wy1DtINyV4cErM83DU8oBPzRKbG8ZCFU8hwA24j0dS RbTyDEH4zZfkiG9Sus/fbmc/zcydiymtVb/1lJqgWkZFnCjGsc2iPJ2bMadqcd7qJEWkfw SnT49x1CF2BwWAGEeflmkrFwKjyf/3Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-2JJY42rrOWKMMqv9dgT_qw-1; Tue, 02 Jan 2024 07:32:57 -0500 X-MC-Unique: 2JJY42rrOWKMMqv9dgT_qw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AC21A85A58F; Tue, 2 Jan 2024 12:32:56 +0000 (UTC) Received: from [100.85.132.103] (ovpn-0-5.rdu2.redhat.com [10.22.0.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89A6B51D5; Tue, 2 Jan 2024 12:32:55 +0000 (UTC) From: Benjamin Coddington To: Markus Elfring Cc: linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org, Anna Schumaker , Trond Myklebust , LKML Subject: Re: [PATCH] rpc_pipefs: Replace one label in bl_resolve_deviceid() Date: Tue, 02 Jan 2024 07:32:54 -0500 Message-ID: <8032551C-BB6C-43AE-B9A3-125B9E5D6D36@redhat.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 On 29 Dec 2023, at 7:45, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 29 Dec 2023 13:18:56 +0100 > > The kfree() function was called in one case by > the bl_resolve_deviceid() function during error handling > even if the passed data structure member contained a null pointer. > This issue was detected by using the Coccinelle software. > > Thus use an other label. > > Signed-off-by: Markus Elfring Reviewed-by: Benjamin Coddington Ben