Received-SPF: pass (google.com: domain of linux-kernel+bounces-14434-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 02 Jan 2024 14:43:24 +0100
Message-Id: <CY49JOEDOEZX.1KNYT91GHL3MX@fairphone.com>
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Konrad Dybcio" <konrad.dybcio@linaro.org>, "Dmitry Baryshkov"
 <dmitry.baryshkov@linaro.org>, "Bjorn Andersson" <andersson@kernel.org>,
 "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski"
 <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>,
 "Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
 <cros-qcom-dts-watchers@chromium.org>,
 <~postmarketos/upstreaming@lists.sr.ht>, <phone-devel@vger.kernel.org>,
 <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 0/3] Fairphone 5 PMIC-GLINK support (USB-C, charger,
 fuel gauge)
References: <20231220-fp5-pmic-glink-v1-0-2a1f8e3c661c@fairphone.com>
 <8d042095-1e09-45cc-9762-909fe8d663a9@linaro.org>
 <CXTU5MLN0YDS.29PPV8KZF8G9R@fairphone.com>
 <CAA8EJpoD3x=kVLu4x2yLtAqCp=wmGSU4ssq5Oj_SD5VQ=GyAYQ@mail.gmail.com>
 <d2007240-2779-4881-8e9d-1c4f5daa55e5@linaro.org>
 <CXU22OZNAH2H.24YIQWBA4KE3C@fairphone.com>
 <2024010227-darn-litmus-4ddf@gregkh>
In-Reply-To: <2024010227-darn-litmus-4ddf@gregkh>

On Tue Jan 2, 2024 at 2:36 PM CET, Greg Kroah-Hartman wrote:
> On Thu, Dec 21, 2023 at 02:45:26PM +0100, Luca Weiss wrote:
> > On Thu Dec 21, 2023 at 1:53 PM CET, Konrad Dybcio wrote:
> > > On 21.12.2023 11:34, Dmitry Baryshkov wrote:
> > > > On Thu, 21 Dec 2023 at 09:33, Luca Weiss <luca.weiss@fairphone.com>=
 wrote:
> > > >>
> > > >> On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote:
> > > >>> On 20.12.2023 11:02, Luca Weiss wrote:
> > > >>>> This series adds all the necessary bits to enable USB-C role swi=
tching,
> > > >>>> charger and fuel gauge (all via pmic-glink) on Fairphone 5.
> > > >>>>
> > > >>>> One thing that could be made different is the pmic-glink compati=
ble.
> > > >>>> I've chosen to use qcm6490 compatible for it and not sc7280 sinc=
e
> > > >>>> there's plenty of firmware variety on sc7280-based platforms and=
 they
> > > >>>> might require different quirks in the future, so limit this PDOS=
 quirk
> > > >>>> to just qcm6490 for now.
> > > >>>>
> > > >>>> If someone thinks it should be qcom,sc7280-pmic-glink, please le=
t me
> > > >>>> know :)
> > > >>> IMO it's best to continue using the "base soc" (which just so hap=
pened
> > > >>> to fall onto sc7280 this time around) for all compatibles, unless=
 the
> > > >>> derivatives actually had changes
> > > >>
> > > >> Hi Konrad,
> > > >>
> > > >> I think at some point I asked Dmitry what he thought and he mentio=
ned
> > > >> qcm6490. Even found the message again:
> > > >>
> > > >>> well, since it is a firmware thing, you might want to emphasise t=
hat.
> > > >>> So from my POV qcm6490 makes more sense
> > > >>
> > > >> But yeah since it's likely that sc7280 firmware behaves the same a=
s
> > > >> qcm6490 firmware it's probably okay to use sc7280 compatible, wors=
t case
> > > >> we change it later :) I'll send a v2 with those changes.
> > > >=20
> > > > Worst case we end up with sc7280 which has yet another slightly
> > > > different UCSI / PMIC GLINK implementation, but the compatible stri=
ng
> > > > is already taken.
> > > > I still suppose that this should be a qcm6490-related string.
> > > Right, let's keep qcm then
> >=20
> > Ack from my side also. Thanks for the feedback!
>
> This doesn't apply to my tree, where should it be going through?

As far as I can see the dependency for the driver commit 1d103d6af241
("usb: typec: ucsi: fix UCSI on buggy Qualcomm devices") was applied to
Bjorn's qcom tree, so 2/3 should also go there then.

Patch 3/3 (arm64 dts) definitely also Bjorn's qcom tree.

So that leaves patch 1/3 which Bjorn can probably pick up as well but
looking at git log you also picked up some for that file in the past,
dunno.

Regards
Luca

>
> thanks,
> greg k-h