Received-SPF: pass (google.com: domain of linux-kernel+bounces-14481-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Bhavin Sharma <bhavin.sharma@siliconsignals.io>
To: mchehab@kernel.org,
	kieran.bingham@ideasonboard.com
Cc: bhavin.sharma@siliconsignals.io,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2] media: adv7180: Fix cppcheck warnings
Date: Tue,  2 Jan 2024 19:57:29 +0530
Message-Id: <20240102142729.1743421-1-bhavin.sharma@siliconsignals.io>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?pzzECu0HdDpx48bMLq5+ScYKcmYQzdvnfzh96haP/DRqZSMIkiloyfyZ56oh?=
 =?us-ascii?Q?RWqBeiCuV/ANaGpW/3InrzmkFE8oiXjsgvtXhoa5BYHsag/utJe343jJ92j6?=
 =?us-ascii?Q?Fa2shhIWwKxiy7dUed/fMIjqNrhEdtveGr2SBJJtgMMR8Y3Ul6beVbXHwp9Q?=
 =?us-ascii?Q?0IFu8z0Dprhe+6IwZ6gyYKmOSVSt+qcXK/Zc7t8/51P1JaQlAMtFGRSy3ucs?=
 =?us-ascii?Q?3xpDSPpFw1x41yes6sjxur8ut1CT+wFOLnGVRtss9Nd0gMAgRkP5YZzRYt6C?=
 =?us-ascii?Q?inMiLBWyOQGcdyN4BOV6NpiNDm7eD6RJZzDDldFfJMMCI0MztWPrKfRhHDs7?=
 =?us-ascii?Q?poy/w2RVSFnD4WdXXJVY6vI0utMKI9JaYAMPQWELsPkA+EPgDfv5OfbJysrE?=
 =?us-ascii?Q?xxHjVR0UQrAa840H1X+1H9w4mbOdxVTsioQcVG4aUrftZDqBLjuJqrVtEqwb?=
 =?us-ascii?Q?VPbaitOI29p97wQTPglekipZKJqemtq6jX4HYqRdOLFVIuSIqPwS5yz3z+vQ?=
 =?us-ascii?Q?nmpv4HQEpTrcJ7uejb7uz+SCjQJR7q1qIpHFBl5FE5v7Ok/GQ7BoPXH4/LR5?=
 =?us-ascii?Q?TD+5eT7D3ORf46kdKqP9nmP7ycLuIDhGZ8S6GFoYrMYMDTbEXK01Vli9hyhZ?=
 =?us-ascii?Q?kSg9LWteGbidWJgnPr5T7Bt6csrzH0EDe7TucNv2YdTPNZs9i8U2mXI0PywD?=
 =?us-ascii?Q?cxXU1H4IbVO7gkA2kln/bMTDqt4LJGP0ivHA1N9o80ZJgJX4OqobyKRK85TW?=
 =?us-ascii?Q?WlMDpg9pMlsm6USxgpm/32gVOEV7E/4WKejTY+NMukXGYTJaD3GqdgnAgr9O?=
 =?us-ascii?Q?utaHwt+P5qkGMPOb+AyJYzZR3A6mSf0nrQupV3l2HIgFPZzIWx2E7XG24Tpy?=
 =?us-ascii?Q?x55OaHr2iI1mTI2zM1qFWSDVl3yPjwLsAx2ZvEeYFFdFEWv52fwOvvurJtNm?=
 =?us-ascii?Q?cnel5qw6vuBXj7sOoQl62DUp/hI7cVxy5S1YynokIVAE5oMn+BS5nHE4+bJs?=
 =?us-ascii?Q?PXRHdMrERwiA2JpxVqxs26yQkowgYYHSLONHs2KVGkxWqqBYj/3u60SQd8Ul?=
 =?us-ascii?Q?7Krq72vZSnY1/5cNY3LsLTUIXTHrwytQa4VJhsQXPE7qyD4rA1wyqjEbjOrg?=
 =?us-ascii?Q?z8N23L1+WrT5Gu3yh1TQAXZl4oH8M0Mm3vr6HmrEj6t86Zc+piDDs0ELZ6Wi?=
 =?us-ascii?Q?Oy3GnTLiynifp8SJpTjPfAQdWC+V2jPBrs60Mb8NAbkbG04ABFVMcIhNAnYO?=
 =?us-ascii?Q?tQ8qRUU7ICbLqtxHi6AebkFmAL+1DjtkpFqBtxHbog4QDsq0760JIw9P9rom?=
 =?us-ascii?Q?BRrgr2g854vY5Ob8lKzO4AWWGR9/o679HTt3ghfIr3i/IxFOpNejPTd2Q9nG?=
 =?us-ascii?Q?OhZRv8h+GXWrwsurR1A2/ucDRyF6PHPq7UWFnkiVmjbp7gITVLPUsrvh2URx?=
 =?us-ascii?Q?sLFgL1SShQG6HP5Dau7AWGCCTut/O8Ra9y1aDd307M1Mo2ZEanwfSu5R9A25?=
 =?us-ascii?Q?LoWga+lvOyoCqn77gDiyDXy8pgOdAvJvDE7rlZwBdOxvxb6g6f0IF+xiNCce?=
 =?us-ascii?Q?q8cx3xjq+j+2/eH8W1f225zMw4EKQgkrd0naSQcwUe1jkT4UUaw/oI+OwVge?=
 =?us-ascii?Q?QJ6KVGOOGYbhWIgt0kjgAiY=3D?=
X-OriginatorOrg: siliconsignals.io
X-MS-Exchange-CrossTenant-Network-Message-Id: 1159943e-68b9-4f90-7b34-08dc0b9f0713
X-MS-Exchange-CrossTenant-AuthSource: MAZPR01MB6957.INDPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2024 14:28:02.7227
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3WyOjNtAdzEVhK1G/2huPuaDxapL5ledk3quuXFsrGUM2lOWxzAK97EmylaOS0yEh/We4TlbwTyGfo4WYxAKMIrAaUGbUrB+TtPTbZtjdDo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0PR01MB9723

WARNING: Missing a blank line after declarations

Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io>
---
 drivers/media/i2c/adv7180.c | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
index 54134473186b..0023a546b3c9 100644
--- a/drivers/media/i2c/adv7180.c
+++ b/drivers/media/i2c/adv7180.c
@@ -335,8 +335,9 @@ static u32 adv7180_status_to_v4l2(u8 status1)
 static int __adv7180_status(struct adv7180_state *state, u32 *status,
 			    v4l2_std_id *std)
 {
-	int status1 = adv7180_read(state, ADV7180_REG_STATUS1);
+	int status1;
 
+	status1 = adv7180_read(state, ADV7180_REG_STATUS1);
 	if (status1 < 0)
 		return status1;
 
@@ -356,7 +357,9 @@ static inline struct adv7180_state *to_state(struct v4l2_subdev *sd)
 static int adv7180_querystd(struct v4l2_subdev *sd, v4l2_std_id *std)
 {
 	struct adv7180_state *state = to_state(sd);
-	int err = mutex_lock_interruptible(&state->mutex);
+	int err;
+
+	err = mutex_lock_interruptible(&state->mutex);
 	if (err)
 		return err;
 
@@ -388,8 +391,9 @@ static int adv7180_s_routing(struct v4l2_subdev *sd, u32 input,
 			     u32 output, u32 config)
 {
 	struct adv7180_state *state = to_state(sd);
-	int ret = mutex_lock_interruptible(&state->mutex);
+	int ret;
 
+	ret = mutex_lock_interruptible(&state->mutex);
 	if (ret)
 		return ret;
 
@@ -399,7 +403,6 @@ static int adv7180_s_routing(struct v4l2_subdev *sd, u32 input,
 	}
 
 	ret = state->chip_info->select_input(state, input);
-
 	if (ret == 0)
 		state->input = input;
 out:
@@ -410,7 +413,9 @@ static int adv7180_s_routing(struct v4l2_subdev *sd, u32 input,
 static int adv7180_g_input_status(struct v4l2_subdev *sd, u32 *status)
 {
 	struct adv7180_state *state = to_state(sd);
-	int ret = mutex_lock_interruptible(&state->mutex);
+	int ret;
+
+	ret = mutex_lock_interruptible(&state->mutex);
 	if (ret)
 		return ret;
 
@@ -436,8 +441,9 @@ static int adv7180_program_std(struct adv7180_state *state)
 static int adv7180_s_std(struct v4l2_subdev *sd, v4l2_std_id std)
 {
 	struct adv7180_state *state = to_state(sd);
-	int ret = mutex_lock_interruptible(&state->mutex);
+	int ret;
 
+	ret = mutex_lock_interruptible(&state->mutex);
 	if (ret)
 		return ret;
 
@@ -466,8 +472,9 @@ static int adv7180_g_std(struct v4l2_subdev *sd, v4l2_std_id *norm)
 static int adv7180_g_frame_interval(struct v4l2_subdev *sd,
 				    struct v4l2_subdev_frame_interval *fi)
 {
-	struct adv7180_state *state = to_state(sd);
+	struct adv7180_state *state;
 
+	state = to_state(sd);
 	if (state->curr_norm & V4L2_STD_525_60) {
 		fi->interval.numerator = 1001;
 		fi->interval.denominator = 30000;
@@ -828,8 +835,9 @@ static int adv7180_get_mbus_config(struct v4l2_subdev *sd,
 				   unsigned int pad,
 				   struct v4l2_mbus_config *cfg)
 {
-	struct adv7180_state *state = to_state(sd);
+	struct adv7180_state *state;
 
+	state = to_state(sd);
 	if (state->chip_info->flags & ADV7180_FLAG_MIPI_CSI2) {
 		cfg->type = V4L2_MBUS_CSI2_DPHY;
 		cfg->bus.mipi_csi2.num_data_lanes = 1;
@@ -857,8 +865,9 @@ static int adv7180_get_skip_frames(struct v4l2_subdev *sd, u32 *frames)
 
 static int adv7180_g_pixelaspect(struct v4l2_subdev *sd, struct v4l2_fract *aspect)
 {
-	struct adv7180_state *state = to_state(sd);
+	struct adv7180_state *state;
 
+	state = to_state(sd);
 	if (state->curr_norm & V4L2_STD_525_60) {
 		aspect->numerator = 11;
 		aspect->denominator = 10;
-- 
2.25.1