Received-SPF: pass (google.com: domain of linux-kernel+bounces-14503-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Jack Allister <jalliste@amazon.com>
To: <dave.hansen@intel.com>
CC: <bp@alien8.de>, <dave.hansen@linux.intel.com>, <hdegoede@redhat.com>,
	<hpa@zytor.com>, <jalliste@amazon.com>, <juew@amazon.com>,
	<len.brown@intel.com>, <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
	<pdurrant@amazon.com>, <peterz@infradead.org>, <rafael.j.wysocki@intel.com>,
	<rafael@kernel.org>, <tglx@linutronix.de>, <usama.arif@bytedance.com>,
	<x86@kernel.org>
Subject: Re: [PATCH v4] x86: intel_epb: Add earlyparam option to keep bias at performance
Date: Tue, 2 Jan 2024 14:46:46 +0000
Message-ID: <20240102144646.44355-1-jalliste@amazon.com>
In-Reply-To: <bcd1b113-94b7-41a9-a3f6-fde1dd54fc74@intel.com>
References: <bcd1b113-94b7-41a9-a3f6-fde1dd54fc74@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

> Jack, I'd really appreciate if you could please slow down.

I'm sorry about this, I'm still extremely unfamiliar with the open-sourcing conventions/
workflow when working with mailing lists & the upstreaming to the Linux kernel. I have
taken this feedback & have started to look through the maintainer tips & docs for
guidance.

Also sorry for the delay in actual response here too, general work responsibilities & the
holiday period has had an affect here.

Before I go ahead with posting up a revision 5 with all of your queries/suggestions I do
have a few questions I'd just like to clarify.

> We could, for instance just support this pair:
>	intel_epb=auto		(default, will hack performance=>normal)
>	intel_epb=preserve	(leave it alone)

With the suggestion above you mentioned implementing this, if this was to be implemented
do you think keeping it `intel_epb_restore_default` as a bool is still worth it? e.g:

```
static __init int intel_epb_no_override_setup(char *str)
{
	if (!str)
		return 0;

	if (!strcmp(str, "preserve"))
		intel_epb_no_override = true;
```

Or do you think it would be worth actually removing `intel_epb_no_override` and creating
a module variable `intel_epb_restore_default` which is an enum of the performance values.

Doing so would then allow for expansability in the future which you had already alluded to
e.g setting to other values such as EPB_INDEX_BALANCE_POWERSAVE/PERFORMANCE.