Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6599240rdb; Tue, 2 Jan 2024 07:10:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYF2fHpvxbBdEjYaOUTBTVAcYxZUCz0e/DWJgBfN1/sAgef/OlXvCPWBmeaOvdJGjhuacy X-Received: by 2002:a05:620a:4142:b0:781:623d:5544 with SMTP id k2-20020a05620a414200b00781623d5544mr12987092qko.8.1704208209767; Tue, 02 Jan 2024 07:10:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704208209; cv=none; d=google.com; s=arc-20160816; b=OmzGFY95lKgc+C+nXO3bm+jA1KkxtS9FJudA7+Gzg/juG7+oAquURFqvgoGJZt22yf VvyJHs6u+6j9lzwDThZmAzngN2+pReYbsqhOcIm070xs8VoI5iqxbVfT4L8cW49ClKGO i2jMPP4CrkiN23ggfJz8qMTFXPtnP9P2jjPdQeaErlIWP3X0J/HoXNLt9Do2LLJlgT+4 UUcyaaqt7TmaGD0VrCt4y9g18F8ApvZbvnKR6QbZSrYG2ubo0H/K6qTHbmiuaigScDPE rERYav5G4chOCorpAib0XuUAqdOzH7Jq4zTO/eOv/s+x4g9SC/onNrsP1oOEpJ/M2hNK lq3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=duogIAsWfLLTjlKSOD5IRkYgSnz9YZeIiibGjV6bB40=; fh=0njMj+W0LxRZoM+7iq9Q0s+3z99Fkz9QT3yJq93mfus=; b=H6y5lSGE/XoJC8a1PFv0dBrHF4uN9m33PuOJGKW0hEuDh/So3VweyNkj7wPWXzlwI9 kiFDot0hZhQ5aAiQ6/c4xdq7tnrSkR8iSZYOECMpdj9VrPoeAOO8JYGwMFrcn2nOGv4i pSX17m2CzrKoeB07b0QexGKKQqpWw3DRr52pqp0UgpHQ3F/U6ON/qiEBq31w87v93cAQ 2ZG87KuR+BIfCLHTxoQ0hdMDWkOk4N+yWSKvWXSLo41IlVN0BBZYZyRdFA77MDp+j0FG 7gldcZsqTAULQ20YHJjhTPRh0dVMZ10XVTeZyigSqP4D2EFRR6OllBcGpjPScgeZDWxr 4eZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PARfsgOa; spf=pass (google.com: domain of linux-kernel+bounces-14535-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14535-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e3-20020a05620a014300b007815612003dsi15776361qkn.282.2024.01.02.07.10.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 07:10:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14535-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PARfsgOa; spf=pass (google.com: domain of linux-kernel+bounces-14535-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14535-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 805C51C20A08 for ; Tue, 2 Jan 2024 15:10:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 38A0213AC5; Tue, 2 Jan 2024 15:09:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PARfsgOa" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88E4814F61 for ; Tue, 2 Jan 2024 15:09:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704208185; x=1735744185; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mGV8n8qUGRSbJeFC+7guJT/ck5cMQBUkKlRBuzXfyY8=; b=PARfsgOaXkPUAWRwmGdv1xGnSNNO052SJ3H33H2KozxR7fexpIx174fB v1+WDltarLbLmEA5h1rbEy6CXJW5QdkTzbQR7R5AEahZdg+cO6Ulk9kM2 fuCnzY4ep0QstydIHRDzIbkXQuOx+BLkxlVf+95a1uxKXD3J85h01UbIH nmCzjiEplxxHcnO2u12TXyIyS+WqEk+CqsoZMtj6jlmtyqwESvCoju0M+ 2LGuclMZgipMlZx0sW2IUA6uCL/G3G/qljmTWus49qebaZTgAkjP+OuxC 4ACSLUbezR3hlTcSmofCS8u+IIrg53LzMEQDFK5o9dbIm1KdmStGcv7Am Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="395768700" X-IronPort-AV: E=Sophos;i="6.04,325,1695711600"; d="scan'208";a="395768700" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2024 07:09:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,325,1695711600"; d="scan'208";a="28084700" Received: from issamoha-mobl1.amr.corp.intel.com (HELO [10.251.10.81]) ([10.251.10.81]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2024 07:09:43 -0800 Message-ID: <83431857-7182-471a-9ff1-9dac37e5a02f@intel.com> Date: Tue, 2 Jan 2024 07:09:42 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] x86: intel_epb: Add earlyparam option to keep bias at performance Content-Language: en-US To: Jack Allister Cc: bp@alien8.de, dave.hansen@linux.intel.com, hdegoede@redhat.com, hpa@zytor.com, juew@amazon.com, len.brown@intel.com, linux-kernel@vger.kernel.org, mingo@redhat.com, pdurrant@amazon.com, peterz@infradead.org, rafael.j.wysocki@intel.com, rafael@kernel.org, tglx@linutronix.de, usama.arif@bytedance.com, x86@kernel.org References: <20240102144646.44355-1-jalliste@amazon.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240102144646.44355-1-jalliste@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/2/24 06:46, Jack Allister wrote: > With the suggestion above you mentioned implementing this, if this was to be implemented > do you think keeping it `intel_epb_restore_default` as a bool is still worth it? e.g: ... > Or do you think it would be worth actually removing `intel_epb_no_override` and creating > a module variable `intel_epb_restore_default` which is an enum of the performance values. > > Doing so would then allow for expansability in the future which you had already alluded to > e.g setting to other values such as EPB_INDEX_BALANCE_POWERSAVE/PERFORMANCE. You should leave 'intel_epb_restore_default' as a bool unless there is some compelling reason to change it. A _possible_ future need for more settings isn't compelling.