Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6602084rdb; Tue, 2 Jan 2024 07:14:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHf+lLZnPFAFhRxts7C2s1YrcyLXhWRmr6l3IGJZ0SYXGGdMZu7yqCaOOLF8xh0agkQZpin X-Received: by 2002:ad4:5d63:0:b0:67e:ee3f:8128 with SMTP id fn3-20020ad45d63000000b0067eee3f8128mr23562484qvb.37.1704208461605; Tue, 02 Jan 2024 07:14:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704208461; cv=none; d=google.com; s=arc-20160816; b=JynVOefo2JhiBZnYyXHsOG4T890THFSM1pLdrP1oxbkx69YIWEwOgm/0jl1hc28nTD /rFNnCB8AQmUNvqjgqOYMF5Qwx/lsknAnrwHZ2doAWRPrneApDYKhmwU+s5e+oOvFmBK 44rCyuZnRV8a2cV/WDpIxA4x2BvdV/sTP18/B1aO8lwvZnSYXpFiNJMEH6onDBxOiQW5 tSTlzSDgYEZRcb28NuEcY+GdfhWVTCrURz470Y04KE2k6Hj/cuaSHO7RsCm7akkaATmg 04oGEj55sQfaMCHVBjZV2138NhmMbKuWEuwBE3tSniIPDGNW/gLgEVNxqyBcwN2/NZSR ee3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=TUdv89+10yklMjPsza0WXTAvELBmUvyltBHX/qzH/LI=; fh=riCH1a7MGtyzSeB02F8SlF2uEr9WDBiuUNXTuA3Gauo=; b=jUjvX5cIh7OcvMbPkPVMDBmVy1rY31plP7lXBtlZkxoA1QyPgZDmmHm5IvWpjQO2B8 CqElOnO6VXCaTiS+VCcvFhb12dIsEBlHiD0D1aL88pAxTlv3kgGfTHrvbBzxE7Vp0oLe hPVPhbEa6FKxTj6A1ODX/Yg4Nw3/ScoqRy5jR0A9VyuxEA3BIF+WUim55kmjZtwLVBze 1EBALDmeyeaLie/RsY0aoQqOoSGZXs3Uxzimor44Tl5y3hyTdlEW+SinuDspi2h0Qdtk hGDAa6d3H2JHbumeImuQafskv8ATQoTYNvOGqrNbkYF7mjylgsKaoYfb5woLLHGKhpZz Hhvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YO5nrjdi; spf=pass (google.com: domain of linux-kernel+bounces-14545-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14545-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f1-20020a0562141d2100b006803463703bsi18797763qvd.129.2024.01.02.07.14.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 07:14:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14545-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YO5nrjdi; spf=pass (google.com: domain of linux-kernel+bounces-14545-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14545-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4FE0C1C2246A for ; Tue, 2 Jan 2024 15:14:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B050413AF4; Tue, 2 Jan 2024 15:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YO5nrjdi" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7C8612E6B for ; Tue, 2 Jan 2024 15:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704208451; x=1735744451; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=v3Sh6Y7e9vOZv5mhYoK7t29HW5eJyXXW7J7oBoCgDWU=; b=YO5nrjdilhrzJmA/u4rBuqQwTq4R5/vqkM5MYrg08SQHX5s2Xn2GzL5Q maGSLDff172ls+qmYxkNZ6Ih4syhUnYHPIc+RG4SCME83a5ZllweudNYe Ylo07U7jNF8p2+uKdHOlrRa7VyHrb3gtZ1nPWZXQoMaNGw0u8keT9tV6V GW9CyKisBzQKgkY+RuWIu5ddyQMQDdu8xmaxffi/2t4ClpSN5NBRye8if 1NK9D4DPlP4dxQgRuqR5TdrnGtzZKxpo1pokaerm+ZvBMBhOQbKgPfKZk 7m8r+SmPpqx11H8ejkT+uxnWLQvIKuonia8otuOUfgwNXT3GSJznzHVlq A==; X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="463290312" X-IronPort-AV: E=Sophos;i="6.04,325,1695711600"; d="scan'208";a="463290312" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2024 07:14:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10941"; a="903134075" X-IronPort-AV: E=Sophos;i="6.04,325,1695711600"; d="scan'208";a="903134075" Received: from issamoha-mobl1.amr.corp.intel.com (HELO [10.251.10.81]) ([10.251.10.81]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2024 07:14:10 -0800 Message-ID: <098a3e0a-eb84-4604-95a8-8b4e8a2e7a4b@intel.com> Date: Tue, 2 Jan 2024 07:14:10 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/split_lock: add split lock counter Content-Language: en-US To: Maksim Davydov Cc: den-plotnikov@yandex-team.ru, tony.luck@intel.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, x86@kernel.org References: <20231215140113.57173-1-davydov-max@yandex-team.ru> <195da6ff-3086-4eff-9b91-b28918a11af9@intel.com> <039b8ba2-09c8-487d-b2ef-f74d6ab4e489@yandex-team.ru> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <039b8ba2-09c8-487d-b2ef-f74d6ab4e489@yandex-team.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/16/23 02:56, Maksim Davydov wrote: > On 12/15/23 21:16, Dave Hansen wrote: >> On 12/15/23 06:01, Maksim Davydov wrote: >>> Provides per task split locks counter to monitor split locks rate >>> in the system. It can be helpful in split locks monitoring to get a >>> clear >>> sense of which process causing split locks and how many of them have >>> happened by the moment. For instance, it might be used by cloud >>> providers >>> who can't control guest executable code and want to make decisions based >>> on the rate value like ratelimiting or notifing the split lock origins. >> Have you considered doing this with tracing instead? >> >> It seems a _little_ silly for everyone to pay the cost of having that >> counter around. > No, it just seemed like a good idea to make a simple machine-readable > interface based on the existing flag (reported_split_lock). > What if this interface is made together with the appropriate CONFIG flag > (default false)? Thus it won't affect those who don't need it. Distributions (effectively) run a single kernel config. They turn on almost everything. Using a config option would subject all distro users to the overhead.