Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6629587rdb; Tue, 2 Jan 2024 08:02:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFH30hnKnefb0xLD/AbgIgzci7CTqnWKvmJYqOxAv4g3TPWS6ZJcu/UdTY2wg/xVlkNlAc+ X-Received: by 2002:a05:6a20:4329:b0:196:efd1:447f with SMTP id h41-20020a056a20432900b00196efd1447fmr5488832pzk.90.1704211375001; Tue, 02 Jan 2024 08:02:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704211374; cv=none; d=google.com; s=arc-20160816; b=WuMYt7zCvFFgIcJwlrlB60Fw8zpFWq9kve6UMvox37aDHlu+xxFZ7gDbNCXfZNSByL SezES0rMarS4utq4i5FU1CE8FpHfCrcO+7SNnYOigxsox4PV8Et3UdtQSIBg1JCYiwHI /Rd84ihsZMIjdveyEAGT7jjMCH0EfN4rSh1pMGxpnoo/9pxexuYO5B++Tpz1PJALm58o B5XouWDNk8cHR2zAa4WFmV7HrYq3bizD3EWwFJ5vl8moyn9CJ6w/85a5s0WVUM62O7wI U6Yic3Hwzho8Xo0SmDdUIvqc5AlyhYwQYEQbbCgsSy5IKJkCgD7+YOa2bcQ0QTVHdWvm eZKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xUUx10JM/QXz+WD4wAqY/DPOtl2ZD4SIOFbVeJmn4KM=; fh=6XI6TRpaVtNvBXo476K2wn/Nd/exSHXg8A2aoS2oSsI=; b=GYd+GtGhUj/NoXDBnoLXIKjcFoTttQERFScAg1XW3dw6ShW2XJr5LYLRd7CA9d8XjN UoCygoGsl8BHphXe108lNUS5QUby1Hpmcxtxz+fGTlTfb/yt9RCeRhV2kcT3x645GQRN YZ+udQIPlxgblzFoWgZM2sr4V93CB8RgCKQnh4UcYz3+tB4GMSCMD54tnJcxmXflx6lK ZkzoiPmnZrn7yXDdkjbCD78A2iMukgNnankKg/pRsM9/b6FT4GSPOAaQr2CF0aYL8xYM 6OVyMtMgcSYpzAVvAx492DU2Bw785ByCMZZ9qJSJX81645XOX9ZVgtStApTFlJJwWFcQ V42Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q++PqW+D; spf=pass (google.com: domain of linux-kernel+bounces-14582-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14582-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id eb16-20020a056a004c9000b006d9bea29d57si13841859pfb.144.2024.01.02.08.02.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 08:02:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14582-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q++PqW+D; spf=pass (google.com: domain of linux-kernel+bounces-14582-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14582-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EA4EDB220A7 for ; Tue, 2 Jan 2024 16:02:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A7B8E14F6C; Tue, 2 Jan 2024 16:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q++PqW+D" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8CAE14F60; Tue, 2 Jan 2024 16:02:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54F99C433C8; Tue, 2 Jan 2024 16:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704211362; bh=1WCpt4WMSN+7nb/VCtM29y9fDFeJOuj/TwxVBcmMSeA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q++PqW+DLdK8rkggKBBNJJxu56dzpDJ6vhoL7bAOt9uQnzVby6DreF6yfT7hKrlKm 4yvY3ZcwpUkzoK/7rcsT6VyuYJiITABJQlZj0eKT2ADhgFzfZ3onC1BThNRiFX6i04 zE/rfa5kboGt3l/tzAT6IdQoekAPI23ZvtSUlAWCI2vGfqMOa+SSTvy+njqhKH8ZlR 4oyxN3iUdVZ+eInmBND2fPMiyZwD8SLbfcgd9FlNYsXfgS+B+22yKP60gowx4uwJMK BfMOnK2i4mCmKxNIvvBd0iU0Nukit1ZQfkDfwrHCONgqAPaY1o+vwXE2KPM3fSJ+iz 8O7HYxZ4fjBhA== Received: (nullmailer pid 2928996 invoked by uid 1000); Tue, 02 Jan 2024 16:02:40 -0000 Date: Tue, 2 Jan 2024 09:02:40 -0700 From: Rob Herring To: Mark Hasemeyer Cc: Rob Herring , Konrad Dybcio , Sudeep Holla , Raul Rangel , Tzung-Bi Shih , Frank Rowand , Andy Shevchenko , AngeloGioacchino Del Regno , LKML , devicetree@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v3 20/24] of: irq: Remove extern from function declarations Message-ID: <170421133956.2927980.11503215748681788966.robh@kernel.org> References: <20231226192149.1830592-1-markhas@chromium.org> <20231226122113.v3.20.I319e781c11e6352eb5b6c408dc20bd54a720edbf@changeid> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231226122113.v3.20.I319e781c11e6352eb5b6c408dc20bd54a720edbf@changeid> On Tue, 26 Dec 2023 12:21:24 -0700, Mark Hasemeyer wrote: > The extern keyword is implicit for function declarations. > Remove it where possible and adjust the line wrapping accordingly. > > Signed-off-by: Mark Hasemeyer > --- > > (no changes since v2) > > Changes in v2: > -New patch > > include/linux/of_irq.h | 35 +++++++++++++++++------------------ > 1 file changed, 17 insertions(+), 18 deletions(-) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed. Missing tags: Acked-by: Rob Herring