Received-SPF: pass (google.com: domain of linux-kernel+bounces-14598-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 2 Jan 2024 08:23:12 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
	<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>
CC: Ard Biesheuvel <ardb@kernel.org>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, "Ira
 Weiny" <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>, Yazen Ghannam
	<yazen.ghannam@amd.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>
Subject: Re: [PATCH 1/4] acpi/ghes, cxl: Create a common CXL struct to handle
 different CXL CPER records
Message-ID: <6594387015431_151dc12949a@iweiny-mobl.notmuch>
References: <20240102150933.161009-1-Smita.KoralahalliChannabasappa@amd.com>
 <20240102150933.161009-2-Smita.KoralahalliChannabasappa@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240102150933.161009-2-Smita.KoralahalliChannabasappa@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iZ/RNu5p2Rl8eXkXx1QZy0/SIAo3q1VTqHGx0od45DNSuFnLTFV7opH2bRol?=
 =?us-ascii?Q?jHRRtkn0TiEcPn/DCz7rS1E/QPMTUUAW74FUWFwm68rX1B81ByRldCcBGl+T?=
 =?us-ascii?Q?UR9j5MKDwC3zCN2pRbXSsyuOUA5Zfhd0MLfcJxbzG8pSUH1s/GJPvCI8kJ+5?=
 =?us-ascii?Q?m9xduQegi38E5Zl5Qps2u1cFeZRWx4FIe6D47wRMJ4T17owM6GdI6OCsBkOK?=
 =?us-ascii?Q?zAU2OR2C6P+CEXpNhGE1EIGZZedPRXh6fdY6wu6gdV5nXsHDX//XjxCUHzyj?=
 =?us-ascii?Q?oGQ7u/LQBa//wZk6O7+GZYRmMakwVqW1reZ6AMMCw20Rwx15Z5E1bPLIG2z9?=
 =?us-ascii?Q?le032jpHJVuzsJCQULOdVo08g0aoC3n403LdAclLjkr1BbTKCvVBKW0lN31i?=
 =?us-ascii?Q?PS9c1HG5nPT0vGGjhTRQJAv7VF1nbZbp3a5SbaPvUxBTP+vbIFYw/d+7n6p+?=
 =?us-ascii?Q?JIcKuYkWXBrFebUV6+oMz3/UaO/spce3uH5IG7F/6FCfemb6ntpSK+OStdwr?=
 =?us-ascii?Q?s3bh6HL46W/85OOBLWxXztZv7lFpiU8vyhvjwQKOUG7Z2ZWMzQXjEDiOK17a?=
 =?us-ascii?Q?SRvKA60JKyCKn2q7U7OGWACVkw879Mcxjd8el8PKffIghcyIjx304qA3Sa/F?=
 =?us-ascii?Q?NxlmBuC+OMNI66irNEmO2GNnL2Z1a25rWzJMGEOzXrugUt8v7qjb41Pzez4B?=
 =?us-ascii?Q?D7w2J6/4TLBqmeN36wnbBVTE0GYiM+XdjIafy3oGdtD3p+GVJSr6mtMUxwah?=
 =?us-ascii?Q?Vf1CE+4+YlLd01RhHCLyyKhAbtNu57b4ulVaqJcgXkfhNpNk1wrdKVRHOHbG?=
 =?us-ascii?Q?38sYvgwmAl9OKCywFt/N5z1RP69BTu2BtRveZfwurWgsZBBWKuUzyzWb6WjH?=
 =?us-ascii?Q?ifC/Q16lVpqoTuYs00visiP0wAS84dvnB/fcFw32p60+3fzLvsAX+APghRi3?=
 =?us-ascii?Q?k742ATN+lBRmeh5zInv70GLNwFRP6E8C0OJIOptJiZ8dfKmOOOl4pOzFuHA1?=
 =?us-ascii?Q?oXNBQgzubxPlzwL6vwxEsIntYc9PJzGWtYTevjpoPNu0pqvkvkfvHdhjpqRi?=
 =?us-ascii?Q?rC37sFZ8Iz1PUF06yotDSjap06AzWXVjzpTGyCp8eg404ghiKH4On8OPBV1H?=
 =?us-ascii?Q?BN/uvWolHqtBAXICtexoMBtf3+Go35iSlVBeBg+oZMOabS2G1GXDvRnMskj/?=
 =?us-ascii?Q?cF1XbMrejq9WbecNeu1mvekms1CghZdZfzkG88RJX9MgnAXQu4XJUPEB/B7l?=
 =?us-ascii?Q?RxgNkNyF043AgnM/w6cCbP/mmG4MunQnF10I4GYBbRV0401bIpUsSa1mH5yB?=
 =?us-ascii?Q?8hlLjYcmvRXAv/6rnEOGEhzAKaZk6HaOoEYn9G2U/g9bx9lSvsLS8jcN/JK/?=
 =?us-ascii?Q?ymXDk6pXeerGm+cx1zvonKlHlTLmtklGIlxqVWCaSytAbep2kEOtvcSr25qk?=
 =?us-ascii?Q?B+Xi95VcaMIb9u9+fkPIrXPQrN5Qo6hHutj/wGslPiIyG6KnZwqbd84R0ucY?=
 =?us-ascii?Q?+F0+VnCCeo3vNu4+70YN6M8wUPdlxg5Zht6caZ7RCft1FH5TFuT3jvKu7fK1?=
 =?us-ascii?Q?zfs9QTHW0gmPNeyio8MZLEJMA+0RcyyIvhDhmanB?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4038b4fc-3248-4abb-a6df-08dc0baf1f7e
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2024 16:23:15.6930
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 42DMYIz/R+UYOOZX2nn7Oe2tzISSlUwCy0dCUrvKGGm4J56y3Yuqd5Vu1pgX/QoyWx5JVeRP5xMH5XsznyiROQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7802
X-OriginatorOrg: intel.com

Smita Koralahalli wrote:
> Currently defined cxl_cper_callback interface between CXL subsystem and
> GHES module is just confined to handling CXL Component errors only.
> 
> Extend this callback to process CXL Protocol errors as well. Achieve
> by defining a new struct cxl_cper_rec_data to include cxl_cper_event_rec
> and other fields of CXL protocol errors which will be defined in future
> patches.
> 
> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>

[snip]

>  
>  static int __init cxl_pci_driver_init(void)
> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> index 17eadee819b6..afa71ee0437c 100644
> --- a/include/linux/cxl-event.h
> +++ b/include/linux/cxl-event.h
> @@ -141,8 +141,12 @@ struct cxl_cper_event_rec {
>  	union cxl_event event;
>  } __packed;
>  
> +struct cxl_cper_rec_data {
> +	struct cxl_cper_event_rec rec;

NIT: I would call this something like event to distinguish it from other
record data.

Other than that this seems reasonable to me.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

[snip]