Received-SPF: pass (google.com: domain of linux-kernel+bounces-14606-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 2 Jan 2024 08:30:21 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
	<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>
CC: Ard Biesheuvel <ardb@kernel.org>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, "Ira
 Weiny" <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>, Yazen Ghannam
	<yazen.ghannam@amd.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>
Subject: Re: [PATCH 2/4] efi/cper, cxl: Make definitions and structures global
Message-ID: <65943a1da3368_151dc1294c2@iweiny-mobl.notmuch>
References: <20240102150933.161009-1-Smita.KoralahalliChannabasappa@amd.com>
 <20240102150933.161009-3-Smita.KoralahalliChannabasappa@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240102150933.161009-3-Smita.KoralahalliChannabasappa@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6SuKvZvbER0z0Vg8Sy+bwNUqiz5eKicb97m49xmoK5xGiOak0s0XP8Rksdlj?=
 =?us-ascii?Q?/SNjHV57cn5DvCsULWJu/8JTLQbEpncrAjWPlRPv0bUQYRK2Rpi/3zwLLxgi?=
 =?us-ascii?Q?p1ZxI0B+/+7PjLUm46s1ZB79CvTcDzYaj0Y5qlqJyr6E+MEJH5s1BepTNm/S?=
 =?us-ascii?Q?yXZN2ryVdfFskGLq8EcRVQ1LWqjtN24GLpo22r3YFPtD1IMQ5L3TxjtfhY8I?=
 =?us-ascii?Q?3ZYvRdk+DC5B6oBnOc+bM+8F7ANAtj3drGGG0PY9oXo1MezrWKCltzYwzagF?=
 =?us-ascii?Q?qbH95/PdyUvBZVBoH1Xz8CMS+DuH2Vh6eDnIqEqxoUoBivFWvNzjPJo5LaR4?=
 =?us-ascii?Q?qgCO/gT78k27fLAYczQs+FNk1smjhuQIgygJ9ZFq2hTuMxA6GARd/AW7CfgS?=
 =?us-ascii?Q?wmqOK13wieWNu68AebhI+JSGt4u/j9yXsehwnQ/Kvr+kGno/dZB7lptW820i?=
 =?us-ascii?Q?msw+FpH6j0ujXk90c9oO9OgnbciI15ID0QyDciaNl1+bU1IeruOYR/EkJRL3?=
 =?us-ascii?Q?8n+4HldxmzFFs9HKLR04Cc6pDLX6nL1bt8fTjUh/a2NMo0QueXRhUF5OY455?=
 =?us-ascii?Q?K+F+BbHihXmDv1ot5A6MUrtnmxSc3n2F/BlIRPLFhR9UmTyI5EQ+5d0klJyn?=
 =?us-ascii?Q?K+fO+u9gNS///W9wQ/KNpmJesnMlq75k3EPs8okcJya3Dj6YR+ijxVSZHO7D?=
 =?us-ascii?Q?uvgSA5HcyBb54kUVp/eITLbgrUYjkL9uhNp81fhcWIPn1ydvqkg3MbqTLjtQ?=
 =?us-ascii?Q?9egtDGiIi/ojQWh882UTSNv2KnZmPmZE7dCc1fnMGJJf+sTr9/ZGkw/QP9EF?=
 =?us-ascii?Q?QmbcSzuqqryWFYA5zAEnDLl9ZkytQWKhGmobzj4gopcMyOk1x6zGnmmvQvgX?=
 =?us-ascii?Q?fLlYoZufpEU2d+7wE6xf64UjEUP1HGjULqonCKSAVH1KoEPP9sISE6lpg+dU?=
 =?us-ascii?Q?+UXzv3SxeljZDfJATB+co8TACv5Sqxh2YVTzTfDxB8xDRMOosdtMm20LARnI?=
 =?us-ascii?Q?xylC0Sj2a+fZv/8iXPsOWDc4ZHVLmMygvonQgXUJv61uzA6cjJQFB0DcxIPA?=
 =?us-ascii?Q?XNiqKR/uct4Bpuo+Kc7WP5UMgIpQoGfhrCCEGzYLB6ojv6Fbh4+FL/Bje+aD?=
 =?us-ascii?Q?dsQFMB/ppkj/inkzYb9cJC+ytKo1YT0IN9GBMDcGHE4xZx+3AQg9jtmYl7yI?=
 =?us-ascii?Q?/5+n5vJw5d3tDn2pZjl3/XidAyPoWRQH4RddKhZArl1I/ll9fbS56gFlvXtH?=
 =?us-ascii?Q?EE6oBTXlXF/3ASkPB2dcxmJF/3guIIISxeoWXf6Yd421M0Hf31kr+bWtCYsv?=
 =?us-ascii?Q?KZQrHHbl6hTrXy99jGMwzUj+3/Zn0FfIz/rSgIll0wB3Djs1+F5eBIwDlbC6?=
 =?us-ascii?Q?e6y42XW8fzC04JE+nyDQRgOWLAUlsGoOWWTl63OgvxNUKb9operNbMt+CK4t?=
 =?us-ascii?Q?dgY8t6wn/xVo7KIevJMDjh83sxjH8yBzahcNjDQXiRRPJcNLh9a/G6CCmD3P?=
 =?us-ascii?Q?S14UbdGM9t6Z/Q/o2m69j9ohJKdNxetmQuZucyQCLzNTjFZ4xINWhrK7Bkt/?=
 =?us-ascii?Q?31GRBi/RrpQ3uKoRWTFdDZKbzrqtRW8YGlgoW6Rx?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 465936ef-7ee1-490f-6a50-08dc0bb01f74
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2024 16:30:25.2279
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BMNMn3gqlj9Ig4ZdNKtnZ6fB+l3F0GncwLNMXxTf1d470NeEFc6foKxERcP6Y0ibxEq5UIGiQSqKoOIdcLivxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8142
X-OriginatorOrg: intel.com

Smita Koralahalli wrote:
> In preparation to add tracepoint support, move protocol error UUID
> definition to a common location and make CXL RAS capability struct
> global for use across different modules.
> 
> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>

[snip]

> diff --git a/drivers/firmware/efi/cper_cxl.h b/drivers/firmware/efi/cper_cxl.h
> index 86bfcf7909ec..6f8c00495708 100644
> --- a/drivers/firmware/efi/cper_cxl.h
> +++ b/drivers/firmware/efi/cper_cxl.h
> @@ -7,14 +7,11 @@
>   * Author: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
>   */
>  
> +#include <linux/cxl-event.h>
> +
>  #ifndef LINUX_CPER_CXL_H
>  #define LINUX_CPER_CXL_H
>  
> -/* CXL Protocol Error Section */
> -#define CPER_SEC_CXL_PROT_ERR						\
> -	GUID_INIT(0x80B9EFB4, 0x52B5, 0x4DE3, 0xA7, 0x77, 0x68, 0x78,	\
> -		  0x4B, 0x77, 0x10, 0x48)
> -
>  #pragma pack(1)
>  
>  /* Compute Express Link Protocol Error Section, UEFI v2.10 sec N.2.13 */
> diff --git a/include/linux/cper.h b/include/linux/cper.h
> index c1a7dc325121..2cbf0a93785a 100644
> --- a/include/linux/cper.h
> +++ b/include/linux/cper.h
> @@ -89,6 +89,10 @@ enum {
>  #define CPER_NOTIFY_DMAR						\
>  	GUID_INIT(0x667DD791, 0xC6B3, 0x4c27, 0x8A, 0x6B, 0x0F, 0x8E,	\
>  		  0x72, 0x2D, 0xEB, 0x41)
> +/* CXL Protocol Error Section */
> +#define CPER_SEC_CXL_PROT_ERR						\
> +	GUID_INIT(0x80B9EFB4, 0x52B5, 0x4DE3, 0xA7, 0x77, 0x68, 0x78,	\
> +		  0x4B, 0x77, 0x10, 0x48)

Is this shared with code outside of GHES?  I did not need my GUID defines
outside of ghes.c and further becuase the events are defined as UUID's I
chose to keep the GUID definition as local as possible to ghes.c.

Can you do the same with this define?

The rest looks good,
Ira

[snip]