Received-SPF: pass (google.com: domain of linux-kernel+bounces-14614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <112f5047-5a5e-42cc-90b5-f9c2711fa5db@amd.com>
Date: Tue, 2 Jan 2024 10:47:12 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] virt: sev-guest: Convert to platform remove callback
 returning void
Content-Language: en-US
To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
 "Borislav Petkov (AMD)" <bp@alien8.de>,
 Dan Williams <dan.j.williams@intel.com>,
 Dionna Glaze <dionnaglaze@google.com>
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org
References: <cover.1703596577.git.u.kleine-koenig@pengutronix.de>
 <52826a50250304ab0af14c594009f7b901c2cd31.1703596577.git.u.kleine-koenig@pengutronix.de>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <52826a50250304ab0af14c594009f7b901c2cd31.1703596577.git.u.kleine-koenig@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aGt4c0ttWkN0YjczTWdoWDhsRnFGTzN2ZnQveWN1M01rZEwxUE9rakFPMlBR?=
 =?utf-8?B?OXJJZHNvU3hQdmlseU1zVUVVa0tpT1EwTWtBM0k4Mmk3Ym9uVi9IWWxYZGox?=
 =?utf-8?B?V2N6SlRwNG9LeGpnYk1ITlNSZFdoaHNZM3lnQUlXY2xCVVZScHppOTJXOXF0?=
 =?utf-8?B?M0FFVlFPZE9tR0tGMWRuTzBOSkRyQURyL2ZieGVVVFBGS0k4M0kyTTM2V0tm?=
 =?utf-8?B?R1JFNDRMaHJGajFvVStHcTVncEQ5UW9KRk5SYlVXeitqQ2ZPeDVhM3Vob05t?=
 =?utf-8?B?bXNMMzRZcmRwV1pRRDlGWU5URFRaSms5Y2VYaGpYOGg0ejgyVTBVVjdTS0VX?=
 =?utf-8?B?b2p1NEM1eEhNczlTT0pITmlEVnJ6bnVZRElGWFd5WnorZFcvZE9xWkRTY0dh?=
 =?utf-8?B?dkRrY1hLanNlUmpwYkNnelBnc0tpd1FHbEw1dkxlSVZtcjl3Q2pwWVVXakRP?=
 =?utf-8?B?Qm5hYWxXS3plMnpQdFd4WkFVV2RzNitxTHVSWmkrMTRKalR4ZTNnMnF3cGhm?=
 =?utf-8?B?MjdlQ0E0TU1DL1dCV3g2OVIvV1NxSm8xZHBOd3AwaFdQZVV2amFua0lsNCtk?=
 =?utf-8?B?TDJxWjc0T1FFV1VlOWp3VmFnTkNlMHNqaEdYdHBaR3lseXU4TUtEeE9mNTBV?=
 =?utf-8?B?WWx4QmVUbURyYXRxSlJMWWhZejdFZ1g4QmhQUWVTdFFLQ0FJNFFFTlNUZzZj?=
 =?utf-8?B?RFJJZ0loZyszOUMzejVGbWQ0VXhnOE44b2lPTGo1MGpOUDdiSm9wSzRVai9m?=
 =?utf-8?B?NnNHL2lab3J0N21tTnIyQ3hXdlFwZ3VVa1RFeXpEZExXTzF2VkU4MDgvdEdV?=
 =?utf-8?B?dHE2YTRpcGQ1SFJ2cEI2TGFkOUxkZDdNUUp5b0lsZ0k4YlVFSFd6Q2tXMHJs?=
 =?utf-8?B?RGxlSUNNbHR5bTBsUGd3MWQwSGN2RlB5Z1BpZ1MrdnVZcjBlQzhNWmRMM3Qr?=
 =?utf-8?B?cFhDdGRDaEc5d0ROMFU5SHJVMTh5RXV3MGVzZ3drbFhsUzdqWkN4eDREQUtr?=
 =?utf-8?B?QnkzcHFtNzZIN2RiaG91N2NzeFI2VURDMnI5UFN1enZreGxDQ1AvVFl6WEpz?=
 =?utf-8?B?eEJaa1BVaUJvQU1ZdlEwWFBhZWk3S2ZUWGo5aVlpMXRKMHN4aWFXZDZ0ekp3?=
 =?utf-8?B?eFJVbkptcVp5Nm9RRXZwa2xZbEZNWXhTOWFoTVI1Z2tLNGZsYTN6UFVNRWJN?=
 =?utf-8?B?eS9qaFdJM2U0OHVpTXJCcDU4WjlsTkdIOEJzSk55bkE1OXRmMHYwcjZIcmpx?=
 =?utf-8?B?elArTkNjajBnTDdpVlA3V0dIejU3ZkFjUk0vWVptNms0VUZXSEpyRS9IckNJ?=
 =?utf-8?B?eGlab2FSTGN3L1FWci9tc0NNWXVzTnI3aTY0V0xuZElvU3hIekFmdlJvUWcz?=
 =?utf-8?B?dkJORDMrOVpTaHpJZGd3NFFaMUlaOHNVRnY5U1VlZ3ZiYVdSY2VvbkFyUmV0?=
 =?utf-8?B?SjJxSWRvOFFKZ0o3VDVCNC9uWU1OTlB4Q1Ftb0tocEZBMFNBU3h3aUpaUmZ3?=
 =?utf-8?B?Zkd0RXViUXJtSzFLOHRYeS9KTnpmeDdsS21FeFBHRkxQajkwUi9KM0xyQi9E?=
 =?utf-8?B?UW1hUlQ0TzNNbEQ1b1J1M01aYjZrWUdpdWlUZmxIbFpaZEdjS3V4THhaaVg4?=
 =?utf-8?B?N3JmZjZwTE9oaWwrWEpzb2NmNXRTbVZHSHYzT0c1eW5mTmNDemtvOC9uRnRV?=
 =?utf-8?B?UHREa0hzWE82bm1XQ055RC9mVHVFTHRzbnhNQUgzTExpSlJWMVNpQnRLVVJ5?=
 =?utf-8?B?emhWV0c0eDZ5VUxQT2Q4dS95RnIzVXM2RFZ1NVlzcDFmSkNOZXgwTlBaR0E2?=
 =?utf-8?B?N3grd2RweGpCWHp2bVd1WDhDV0RjeEJFcS9oajN4MkloSy8vT0pMMEZjQkp1?=
 =?utf-8?B?dUpOd0ZOVWkzZnhUWE5xZVhRai9mWTFmWmVLeFEvNmYxNzgxT0E1Qnk4Sm9h?=
 =?utf-8?B?R2d3ak80cXF2MUQxWGNVbW55d3BTUmJqZGlnWTd5NXJFQTBvSXRsSjlubXdQ?=
 =?utf-8?B?RGhTN1VzcHFyeEtISkxkWHJmaUhEZHVlMHN5WnBDM0Z5YzhhT1lMaCtEZWpa?=
 =?utf-8?B?UExnOHRMYjkwQUxZMklmVXlIK0NON0hvc05sbHEvRjJ5T2c4ajlPTk50M1hF?=
 =?utf-8?Q?hOa8sx5Ta2ViItGS1fZnmdaBv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39a3e8c0-e858-46ee-5a54-08dc0bb27932
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2024 16:47:14.6710
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FikzZoLyIQSrnBXM+GkkvmpXFCLzgmmb81gsDNgcNYOJUtJnrup5L8OSXTSVCpa4wm/q2beJlEJwI4DDw/rXqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4202

On 12/26/23 07:28, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   drivers/virt/coco/sev-guest/sev-guest.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
> index bc564adcf499..87f241825bc3 100644
> --- a/drivers/virt/coco/sev-guest/sev-guest.c
> +++ b/drivers/virt/coco/sev-guest/sev-guest.c
> @@ -994,7 +994,7 @@ static int __init sev_guest_probe(struct platform_device *pdev)
>   	return ret;
>   }
>   
> -static int __exit sev_guest_remove(struct platform_device *pdev)
> +static void __exit sev_guest_remove(struct platform_device *pdev)
>   {
>   	struct snp_guest_dev *snp_dev = platform_get_drvdata(pdev);
>   
> @@ -1003,8 +1003,6 @@ static int __exit sev_guest_remove(struct platform_device *pdev)
>   	free_shared_pages(snp_dev->request, sizeof(struct snp_guest_msg));
>   	deinit_crypto(snp_dev->crypto);
>   	misc_deregister(&snp_dev->misc);
> -
> -	return 0;
>   }
>   
>   /*
> @@ -1013,7 +1011,7 @@ static int __exit sev_guest_remove(struct platform_device *pdev)
>    * with the SEV-SNP support, it is named "sev-guest".
>    */
>   static struct platform_driver sev_guest_driver = {
> -	.remove		= __exit_p(sev_guest_remove),
> +	.remove_new	= __exit_p(sev_guest_remove),
>   	.driver		= {
>   		.name = "sev-guest",
>   	},