Received-SPF: pass (google.com: domain of linux-kernel+bounces-14760-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 2 Jan 2024 14:06:13 -0500
From: Gregory Price <gregory.price@memverge.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Gregory Price <gourry.memverge@gmail.com>, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	x86@kernel.org, akpm@linux-foundation.org, arnd@arndb.de,
	tglx@linutronix.de, luto@kernel.org, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, mhocko@kernel.org,
	tj@kernel.org, corbet@lwn.net, rakie.kim@sk.com,
	hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com,
	peterz@infradead.org, jgroves@micron.com, ravis.opensrc@micron.com,
	sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com,
	seungjun.ha@samsung.com, Johannes Weiner <hannes@cmpxchg.org>,
	Hasan Al Maruf <hasanalmaruf@fb.com>, Hao Wang <haowang3@fb.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Michal Hocko <mhocko@suse.com>,
	Zhongkun He <hezhongkun.hzk@bytedance.com>,
	Frank van der Linden <fvdl@google.com>,
	John Groves <john@jagalactic.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v5 00/11] mempolicy2, mbind2, and weighted interleave
Message-ID: <ZZRepTEFNFC17fjT@memverge.com>
References: <20231223181101.1954-1-gregory.price@memverge.com>
 <87frzqg1jp.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <ZYqEjsaqseI68EyJ@memverge.com>
 <87le98e4w1.fsf@yhuang6-desk2.ccr.corp.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87le98e4w1.fsf@yhuang6-desk2.ccr.corp.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?5yEkyGLYQqosncnR8cLJoKkCkOl/Vjd5T8TqR38eWfxL/22srXbwGxInJ33g?=
 =?us-ascii?Q?qiinAWqICPwmifrx6ha82NsNs6hXJEFo48319AZy+WObMSJvmAXy0OyHJi2R?=
 =?us-ascii?Q?Ij1Kv+qzVK8LgGQQ92d/JHz/naLM44HmdKmIO2bVpPhlGb2HHd2BHzZVRGC7?=
 =?us-ascii?Q?2st0aaD6roel1tgBsKV1FwFMS5Lz1TuSfczkGzGIAsZyAOml3cvm6856+H7f?=
 =?us-ascii?Q?EQv6FnexhPCXgo4C+48jTEziyefbaduYJJq85Z1vtyehtki+33L4cpcwTzIK?=
 =?us-ascii?Q?c7GgS6hNmUUhbEmb/Hgssd6EPA/mZgwvSfr0n1hPxBVNi8P+xPL5i4MKwklL?=
 =?us-ascii?Q?JWXvyPX1Xr4l5aEYasDX5nbPZRdXSgR8XziMm+daAijH/zhwuDBuFT+oyvkN?=
 =?us-ascii?Q?Qvek6DKyM+RIdaxwVhTUy270gN2kmNNWJPgL9FY4J6VHK+/cVibC0fjV4DaY?=
 =?us-ascii?Q?Ctp4FyDLW2rNzsesf7lppNwDeg77Vz8tJL4N7V7s/jFsmX+lXTjgTob1UkpM?=
 =?us-ascii?Q?FauHtWATRroKxq4nyK6tVlR1lM4RErQVDJyK50dAHYPmzhFoISr0x2WNXEYp?=
 =?us-ascii?Q?nAHVsjU66JShrXhPt2I3krSL87zj+/BSvePBvNshCW7qC7CmxCHwks8EkP1e?=
 =?us-ascii?Q?Y0ZohNmzaU/Vl/jwHZ9Cc6MCrBILWam4iE+NcT6Lt7Z1mejTzSUxBYyIeqsM?=
 =?us-ascii?Q?9iFm6/pBurPXZJUKgLOSVPwg/BeKJUbxgQi2fyL/S4UXmENOEYiu/j56IzXp?=
 =?us-ascii?Q?Ny6BVcu1qBJM0ih4CGk2vRoCWQCPuDGvSOuYg+vZ0KQnhZ+5+X/ud+/aRY+x?=
 =?us-ascii?Q?Xu32p8bgyoV4BM968iS4ImHPI0ZrlH7DeRZRTdUEUX0L4Q/Wl2Nsl/iFbRN/?=
 =?us-ascii?Q?X+9je+sQqrWVaJeRL1sa1Y4uK0JP6vwfRKgfP5RQikpyAlc16y9bydfDh+Qi?=
 =?us-ascii?Q?5I8deEs3Tb2HQKrMz+vpxUWurGzkw5516VyPa9eRAcov32FsbN+T/Cdr5nTK?=
 =?us-ascii?Q?IRqv6BzsswSo5nYH25RqB+2KkjIOEgvI2jxILy5G/yHlhDTLRlHHr4WXNgxo?=
 =?us-ascii?Q?6o3ZzC5m0sZbBU6TAg/e9+8LlVzbcM3XUN22+1kBQWSWl4HQzoqIDNz+MOhy?=
 =?us-ascii?Q?q/SfyPyXEeiF3v1HsjgEWJuvBUts81g5M9psvw9yFywhDOe+6K5YaWf+ZhVQ?=
 =?us-ascii?Q?mX2XRndKp3UcPmPh3thYqeWDjR9OBRXciMsLpe24Yau9/q+SWFNMkXEEvTea?=
 =?us-ascii?Q?QrTVpJ+r0/CbTyLieqiEg6isL2NdwacRgirpR9IzIqIHMcrwZVI6z7ek8dRA?=
 =?us-ascii?Q?1R4Ud6UV5MkF2n/VonfKSx8RrPKvKr63yJMtPXxdOnUnUPqhYTZIb53d67tu?=
 =?us-ascii?Q?poNq7y5/F6PUmGFTynJNHGxIzxeN7Gx7h539hxUL8V1Qdnoc65zkSwaGuUD/?=
 =?us-ascii?Q?osdUfvi+VEBLMQ0OwhV28IL6+oV6GzGRoNzyQgTdRhjRvgwXD9t92Pam64Gc?=
 =?us-ascii?Q?Fo+x03t1iClLOqzeMxaz1klAOFVGkSfP2tY0tz6svQquD2DBtpkZB0rARAfj?=
 =?us-ascii?Q?1K7POzUAumX9G556IS+m9wHJ2wSRx4A3IbZ4lDZx+t3sKzV9hy524nKfzyfR?=
 =?us-ascii?Q?0w=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b500ee09-a7a8-42a9-28dd-08dc0bc5e944
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2024 19:06:23.1960
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8dm4HAPPVPcJsxV3WxgLwpGV9t91gXyZ34mX/t47ESF6gDKavAYbLowTa8GWwc8LqI5B0ykHAwZUaBs67RZsmSyMuvN0O9FG5m3Xh23+J8E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR17MB6373

> >> > struct mpol_args {
> >> >         /* Basic mempolicy settings */
> >> >         __u16 mode;
> >> >         __u16 mode_flags;
> >> >         __s32 home_node;
> >> >         __u64 pol_maxnodes;
> >> 
> >> I understand that we want to avoid hole in struct.  But I still feel
> >> uncomfortable to use __u64 for a small.  But I don't have solution too.
> >> Anyone else has some idea?
> >>
> >
> > maxnode has been an `unsigned long` in every other interface for quite
> > some time.  Seems better to keep this consistent rather than it suddenly
> > become `unsigned long` over here and `unsigned short` over there.
> 
> I don't think that it matters.  The actual maximum node number will be
> less than maximum `unsigned short`.
> 

the structure will end up being

struct mpol_args {
	__u16 mode;
	__u16 mode_flags;
	__s32 home_node;
	__u16 pol_maxnodes;
	__u8  rsv[6];
	__aligned_u64 pol_nodes;
	__aligned_u64 il_weights;
}

If you're fine with that, i'll make the change.
~Gregory