Received-SPF: pass (google.com: domain of linux-kernel+bounces-14772-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <17a2c694-2c48-46dc-b028-68793a31a984@gmail.com>
Date: Tue, 2 Jan 2024 12:29:58 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iproute2-rc 1/2] rdma: Fix core dump when pretty is used
Content-Language: en-US
To: Leon Romanovsky <leon@kernel.org>,
 Stephen Hemminger <stephen@networkplumber.org>
Cc: Chengchang Tang <tangchengchang@huawei.com>,
 Junxian Huang <huangjunxian6@hisilicon.com>, jgg@ziepe.ca,
 netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linuxarm@huawei.com,
 linux-kernel@vger.kernel.org
References: <20231229065241.554726-1-huangjunxian6@hisilicon.com>
 <20231229065241.554726-2-huangjunxian6@hisilicon.com>
 <20231229092129.25a526c4@hermes.local>
 <30d8c237-953a-8794-9baa-e21b31d4d88c@huawei.com>
 <20240102083257.GB6361@unreal>
 <29146463-6d0e-21c5-af42-217cee760b3f@huawei.com>
 <20240102122106.GI6361@unreal> <20240102082746.651ff7cf@hermes.local>
 <20240102191701.GC5160@unreal>
From: David Ahern <dsahern@gmail.com>
In-Reply-To: <20240102191701.GC5160@unreal>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 1/2/24 12:17 PM, Leon Romanovsky wrote:
>>
>> Part of the problem is the meaning of pretty mode is different in rdma
>> than all of the other commands. The meaning of the flags should be the
>> same across ip, devlink, tc, and rdma; therefore pretty should mean
>> nothing unless json is enabled.
> 
> I was very inspired by devlink when wrote rdmatool. It is supposed to
> behave the same. :)

You need better inspirations :-)

It was a mistake to merge devlink source code into iproute2 without a
commitment to bring it inline with other iproute2 commands.