Received-SPF: pass (google.com: domain of linux-kernel+bounces-14775-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 2 Jan 2024 11:31:17 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kernel-janitors@vger.kernel.org, Ahelenia =?UTF-8?Q?Ziemia=C5=84ska?=
 <nabijaczleweli@nabijaczleweli.xyz>, Li kunyu <kunyu@nfschina.com>, Michal
 Hocko <mhocko@suse.com>, Sebastian Reichel
 <sebastian.reichel@collabora.com>, Suren Baghdasaryan <surenb@google.com>,
 Zhang Zhengming <zhang.zhengming@h3c.com>, Zhou Kete <zhou.kete@h3c.com>,
 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: relay: Improve exception handling in
 relay_create_buf()
Message-Id: <20240102113117.b2b4ffa2998eb51b674b0304@linux-foundation.org>
In-Reply-To: <ef8b36bf-d9d7-46a4-9648-7cc8aaa8a980@web.de>
References: <ef8b36bf-d9d7-46a4-9648-7cc8aaa8a980@web.de>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 31 Dec 2023 10:38:10 +0100 Markus Elfring <Markus.Elfring@web.de> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 31 Dec 2023 10:26:25 +0100
> 
> The kfree() function was called in one case by
> the relay_create_buf() function during error handling
> even if the passed data structure member contained a null pointer.
> This issue was detected by using the Coccinelle software.
> 
> Thus use another label.
> 
> ...
>
> --- a/kernel/relay.c
> +++ b/kernel/relay.c
> @@ -161,14 +161,15 @@ static struct rchan_buf *relay_create_buf(struct rchan *chan)
> 
>  	buf->start = relay_alloc_buf(buf, &chan->alloc_size);
>  	if (!buf->start)
> -		goto free_buf;
> +		goto free_padding;
> 
>  	buf->chan = chan;
>  	kref_get(&buf->chan->kref);
>  	return buf;
> 
> -free_buf:
> +free_padding:
>  	kfree(buf->padding);
> +free_buf:
>  	kfree(buf);
>  	return NULL;
>  }

kfree(NULL) is an OK thing to do, and is a well-known pattern.  Can we
arrange for Coccinelle to understand this?