Received-SPF: pass (google.com: domain of linux-kernel+bounces-14803-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 2 Jan 2024 15:32:13 -0500
From: Gregory Price <gregory.price@memverge.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Gregory Price <gourry.memverge@gmail.com>, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	x86@kernel.org, akpm@linux-foundation.org, arnd@arndb.de,
	tglx@linutronix.de, luto@kernel.org, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, mhocko@kernel.org,
	tj@kernel.org, corbet@lwn.net, rakie.kim@sk.com,
	hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com,
	peterz@infradead.org, jgroves@micron.com, ravis.opensrc@micron.com,
	sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com,
	seungjun.ha@samsung.com
Subject: Re: [PATCH v5 03/11] mm/mempolicy: refactor sanitize_mpol_flags for
 reuse
Message-ID: <ZZRyzRjHCkbqpSTv@memverge.com>
References: <20231223181101.1954-1-gregory.price@memverge.com>
 <20231223181101.1954-4-gregory.price@memverge.com>
 <87y1dgdoou.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <ZYp7P1fH8nvkr4o0@memverge.com>
 <ZYq9klTts4yg8RhG@memverge.com>
 <871qb0drto.fsf@yhuang6-desk2.ccr.corp.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871qb0drto.fsf@yhuang6-desk2.ccr.corp.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?KJn7bGMwi4NR3gerqH6sgWdcAwFm77ubDpolHCFdSZwkCmlUvfrwfh88nmo+?=
 =?us-ascii?Q?MPRDC+3WE04OI6gvynlxeMNP0B4SSMcVyYgfy5Cm5fjsJsRMW0emT0WPNQMl?=
 =?us-ascii?Q?SNNGw96ezUOW4aL0w0Rw6DBBii3spyIrfm5TOjfznqibRd7dNZi5G+X3TraT?=
 =?us-ascii?Q?IMUtkxuoYNv7dG0ZUZile/RlDRiLTCS4eYGOXmo7SRUVLQ7Fm58jlgR+s18M?=
 =?us-ascii?Q?kk29UUDj712ArEts1Qg+50T4fjW9MSY/CdoHZMlTvaRkrb82WkP0UE9g2GjW?=
 =?us-ascii?Q?KHTFDNaZIvOeTtSIbXgH4d89UnkpX+RWu/y0XuPX5cYM11QWMhO4lZL91nVi?=
 =?us-ascii?Q?gSpTGQYsHHMWKXEmKtHXqJbFbaJXCaNMAQgq+GGFb88hXgGb2IjSlAqwd6fM?=
 =?us-ascii?Q?ffaXyRogeGVlLSQP7Vdps3PgBpoxZsZScujssoIlb4H0m6R0bjXac0YVeiOp?=
 =?us-ascii?Q?aLMJgzCm3+BcWYSljQ7+5qECjBjAmHEI5es5ZfAKa/ri22kgH5kCHuVsyf7y?=
 =?us-ascii?Q?e7zlXQJmvp/1eN3ICw2neHepjh4j/kkRsHNS80W1bo2bD88mxZ0tOWdcmQgm?=
 =?us-ascii?Q?zkj1rLvP9XfKvyoldjeCrnyw0ayVef6LxvuTQ8Dv+hvrqj8SHfxlM0A9B4/7?=
 =?us-ascii?Q?jSvGwEetessHTiVcwKqWMzeIH2opyW+G92s0GLZum0LtKvzwO5oz0PqWGaK2?=
 =?us-ascii?Q?PCSbiJiCFDp5+72BYYtd7Tic6jV9C0zrQXH2woNbCq5fUH2IkwzyS2cgWOLM?=
 =?us-ascii?Q?uR/a40LfJ+bF9dDmZGcPrIj1EAo0LW6RRiHjMMWGJxAZF4MWShZ0Lbf+jnXK?=
 =?us-ascii?Q?/108csTJv7cuXp7f9wy4NoiL1pC8RKUCGKWlnsEe3oNsInXU0QnRT98rWD1t?=
 =?us-ascii?Q?AYPFclla26zPBkUHEPWbkOWy6Hgxm2cmAtVT3TG1Sv5NM6gFvYDVsw/TmA7h?=
 =?us-ascii?Q?CVWwQylincPB8fe/yP6teks0cVcB1tcdDcV4wd8unI0MqfkUTsgqn0Yc+cwo?=
 =?us-ascii?Q?pM/U85UL7IHwoGQZNnTS3Ex3UQIBSx3pBppIK4xYzzuyYzpMFagurOdajfXy?=
 =?us-ascii?Q?PKhw8UpTLzghBsk0kyFYicX6zzqgZwZZjWA3FZuiYbj0wIAoPykA71kv4kdP?=
 =?us-ascii?Q?fXaHzlKrWXzQ2wIFUKsAYC9G/1V/ku1TdR8ISNXJJ/MM4V+Ajy4GeTgeqlq4?=
 =?us-ascii?Q?DDa5YhTS04JCwc+wWAqLl6ZZNrj6FydABwxIEUTXlGbXFaSTcCd7+ON5CYBV?=
 =?us-ascii?Q?5XP68TJCnFnsPFPyZXsKwijIZrs8HBOEFPYfvc8VtcD89n2Y+7V5qeDSnNi0?=
 =?us-ascii?Q?mlW8DgaL81tdH9Hn78v1rYH5lCx6/TBZgJ1H+9R9Q/PJ32ZohqbaMd3oDYD/?=
 =?us-ascii?Q?eISPFGf9jkcAThgUrg1EgzV1FPLoz3Hn92dVZTjyqvSzKTs4OwBWfHb0yXty?=
 =?us-ascii?Q?sehl6bI9u5CMLpSRf3nTRKj7A9FJ8UCdtlicgCW7UoggWTtRt4rTTyihz6zT?=
 =?us-ascii?Q?TZ75ac+oI5yD5fLlhk9eBYlQZ5HOYW0RvgWvFBoLNDWBI5j3qoIvYiwVAI8M?=
 =?us-ascii?Q?rnwLQhaQACAK+Pt5JGlBuZYpGnSrH+ZO4KjyK3EHIoJg9YQwDMtAd3RSZtKr?=
 =?us-ascii?Q?Fg=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78023ec1-06d1-45dc-daad-08dc0bd1ea14
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2024 20:32:18.4318
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KcQxF1DYDcLEy6VmAkpWQUcaknbpQ4B7Zai+qWD4pKNpqk8esZUZ77HzXt+jZgJHdV8n0tWJ0Rwa+Ecd7jOEIWLQIhiNWfL/qvCS0bq5Lz8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR17MB5123

On Tue, Jan 02, 2024 at 05:09:55PM +0800, Huang, Ying wrote:
> Gregory Price <gregory.price@memverge.com> writes:
> 
> > On Tue, Dec 26, 2023 at 02:05:35AM -0500, Gregory Price wrote:
> >> On Wed, Dec 27, 2023 at 04:39:29PM +0800, Huang, Ying wrote:
> >> > Gregory Price <gourry.memverge@gmail.com> writes:
> >> > 
> >> > > +	unsigned short mode = (*mode_arg & ~MPOL_MODE_FLAGS);
> >> > > +
> >> > > +	*flags = *mode_arg & MPOL_MODE_FLAGS;
> >> > > +	*mode_arg = mode;
> >> > 
> >> > It appears that it's unnecessary to introduce a local variable to split
> >> > mode/flags.  Just reuse the original code?
> >> > 
> >
> > Revisiting during fixes: Note the change from int to short.
> >
> > I chose to make this explicit because validate_mpol_flags takes a short.
> >
> > I'm fairly sure changing it back throws a truncation warning.
> 
> Why something like below doesn't work?
> 
> int sanitize_mpol_flags(int *mode, unsigned short *flags)
> {
>         *flags = *mode & MPOL_MODE_FLAGS;
>         *mode &= ~MPOL_MODE_FLAGS;
> 
>         return validate_mpol_flags(*mode, flags);
> }

was concerned with silent truncation of (*mode) (int) to short.

*shrug* happy to change it

~Gregory