Received-SPF: pass (google.com: domain of linux-kernel+bounces-14905-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240102212716.810731-1-almasrymina@google.com> <20240102212716.810731-2-almasrymina@google.com>
In-Reply-To: <20240102212716.810731-2-almasrymina@google.com>
From: Shakeel Butt <shakeelb@google.com>
Date: Tue, 2 Jan 2024 13:54:17 -0800
Message-ID: <CALvZod43P7r1Ak=Og2ssXN1Jg1A25AYKDTP4j+qJj1z4DxucRw@mail.gmail.com>
Subject: Re: [RFC PATCH net-next v4 1/2] net: introduce abstraction for
 network memory
To: Mina Almasry <almasrymina@google.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jason Gunthorpe <jgg@nvidia.com>, 
	=?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, 
	Yunsheng Lin <linyunsheng@huawei.com>, Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 2, 2024 at 1:27=E2=80=AFPM Mina Almasry <almasrymina@google.com=
> wrote:
>
> Add the netmem_ref type, an abstraction for network memory.
>
> To add support for new memory types to the net stack, we must first
> abstract the current memory type. Currently parts of the net stack
> use struct page directly:
>
> - page_pool
> - drivers
> - skb_frag_t
>
> Originally the plan was to reuse struct page* for the new memory types,
> and to set the LSB on the page* to indicate it's not really a page.
> However, for compiler type checking we need to introduce a new type.
>
> netmem_ref is introduced to abstract the underlying memory type. Currentl=
y
> it's a no-op abstraction that is always a struct page underneath. In
> parallel there is an undergoing effort to add support for devmem to the
> net stack:
>
> https://lore.kernel.org/netdev/20231208005250.2910004-1-almasrymina@googl=
e.com/
>
> Signed-off-by: Mina Almasry <almasrymina@google.com>
>

I think you forgot to update the commit message to replace netmem_ref
with netmem. Also you can mention that you took the approach similar
to 'struct encoded_page'. Otherwise LGTM.

Reviewed-by: Shakeel Butt <shakeelb@google.com>