Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6832900rdb; Tue, 2 Jan 2024 15:35:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFj3JNOJjnjOuke9FKm63b/6M89M2ysmymGdfW25WGe21sC53QmaGwcW38X+C7G1tBYHf0B X-Received: by 2002:a05:620a:190c:b0:781:73c2:a98c with SMTP id bj12-20020a05620a190c00b0078173c2a98cmr392677qkb.17.1704238558388; Tue, 02 Jan 2024 15:35:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704238558; cv=none; d=google.com; s=arc-20160816; b=LOc9qNECYiF0PVBFw7g1oANl2AzRY4mCv6XxmVHE8L5QzYtkZOdcosMWfjY8mQHR4B FRB6ooCJt6eTkimJl7ixHzFs2bduEXDQRDyPDEd8JyJHhCcriPX+dlwaZ2dNm2ZUoeyx gkFZvBbcCy2jcJdsCyCHktHy9mgl0M7W3ahrDm2fkvZCkhXm+FJrKOTtyJw/v1aaumKO /GZRgdgIcz9qniihBysiC7LHISzizXmJVSEnZ3weP5A3ehbOodsSWv9jGaqJMAiM/lN9 SHhZAuuKW9tTtH1tI/tFC2Fu+eB2jMhzXw3Kloc7VnvuMNd7gyxDxFspvgnMTn63Z837 vYIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=jGIOJXrvvChtd3kXkdGkivUkr5LtREPdSYUSnQwkSpM=; fh=TnCO0FnL4rX5GkG87UY3xkoQlkJjXCHstT7zxXoHOAw=; b=L37BRVr8jdlFuXjfu9noo1UOjJytwmXosUAIjLVGFhdsER1nb8KYDcv/A9IIhsK7Wt 1Y2zfCZRmgy5P5b5X18jrcDS0H1alTf7SpE43eCYAwd2zsBImbkhVVZUzbWkYyUSmIpT jLKPcIuUMbxEYKPGAyA1rkxzyXo+80sj+NfkLNANz7va99Td/8jIHOz85hqG4pBXnHrm IF5cmDjRyymHe+cm1CV9bNnBhCVPDMFcQWgwG7UjCN/l5gTtLnrTtTapoSotNRTxvGaC rqvpTZF99eYgsO9S4bRhwXjuyHU2D5pszevvT7IfdCViTxQZe5wQhHn4p6RswL2l9av8 OpnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BqOgyMUV; spf=pass (google.com: domain of linux-kernel+bounces-14977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14977-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o20-20020a05622a139400b004281dd38d60si5701440qtk.331.2024.01.02.15.35.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 15:35:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BqOgyMUV; spf=pass (google.com: domain of linux-kernel+bounces-14977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14977-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2AA391C22BDC for ; Tue, 2 Jan 2024 23:35:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 02A6D17983; Tue, 2 Jan 2024 23:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BqOgyMUV" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37BF517980; Tue, 2 Jan 2024 23:35:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47A8FC433C8; Tue, 2 Jan 2024 23:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704238548; bh=hPu6xGK4IX3QhKTJdbUzW4NhfenDBEDddhD2itm8rE4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BqOgyMUV8ZKFmw42r/kPMmuUgOGQrEkBFgDc8WE8vjdWmoeGdCAFRlCDEnwh+uZd9 7yc62NTPyEEf6s2JivYwkJjJXM9oGMS2Gm8m+cpIBzqtOYQ/ALCWJodPdiHT8TFbbc JrDeeKVkq8KShE0hJ3fAPnkerYgtPAhbUheU0T0MgkuaOa7XK9FA1nMLdetrEputKk L87ZymlWhxS3qBqTG/IVibNaI7PVK9AifnkHRSmLoewOHSgeNKKfL7gO7IdtOjG3yO 6IVDF+QIOmzAT49BhQL30M+CZfG/ccd4MCFTX3mwrtd/6dTkHnj0hmhQoGgPXePpa+ yw5vpFGfQNNGA== Date: Tue, 2 Jan 2024 15:35:47 -0800 From: Jakub Kicinski To: Ilias Apalodimas Cc: netdev@vger.kernel.org, linyunsheng@huawei.com, Jesper Dangaard Brouer , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] page_pool: Rename frag_users to pagecnt_bias Message-ID: <20240102153547.58b23d35@kernel.org> In-Reply-To: <20231220080147.740134-1-ilias.apalodimas@linaro.org> References: <20231220080147.740134-1-ilias.apalodimas@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 Dec 2023 10:01:46 +0200 Ilias Apalodimas wrote: > - long frag_users; > + long pagecnt_bias; IDK :( pagecnt to mean suggests this is related to page refcount, not page pool specific refcount. More importantly bias is the large number by which we increment. This counter counts how many of the bias references we actually consumed. So how about bias_consumed? bias_used? bias_issued? frags_alloced?