Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6836435rdb; Tue, 2 Jan 2024 15:47:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHd129TDmhbCoCY8cNJS5Lbjl0k+olPo6TjtxSJFU97mpsAUJx6Byu5QAUALiNYk4d+Xvvj X-Received: by 2002:a50:9b09:0:b0:54c:bb9c:4b88 with SMTP id o9-20020a509b09000000b0054cbb9c4b88mr204462edi.5.1704239246299; Tue, 02 Jan 2024 15:47:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704239246; cv=none; d=google.com; s=arc-20160816; b=kMirJSZZInMNAeLfcqU3so7o8z8RJBe5JlMaaSqmd7DK1cZf2JbTDVxGnLvhS79gMA t0uOtDbUPWuRLYCmW/OfpDdw+xUgw2dMpCnu19srCdt5dQQRgRwhjKSd+U5fbXVNNc5C l3qRbHYyJcjmJr29WZjkVGIchHMMMrX7oxu3qtXLurTrLwK13iL9dqFsnCPvVRofqMVr IV1BL9Dw6FRJYm3g6UkIIJnbk/mLpY57tfSzaeLOaZtvwphgvhUKKSt/eiWIuB+muBsM TUT2EFFW0WIoqGzKN17aMIw1TdjBS1uEk0XJ46b7w5x7vnT42y8WZb6RRnUhkCdsHN0p jK/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:date:to:cc:from:subject:references:in-reply-to :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:dkim-signature; bh=CZ2SLviVIOPK+w/RCmlYzrNM6ShsUO9iGFjmEfntgB0=; fh=fytWEyHcFpsjprnM8Kjlfeq6GLtTbzEt4kg/h2Mnjv4=; b=mrz5YFAHsUhhRxH1oeyyw7l3dE29spaOsk2EuFO0d/raTsaCOZP6/g3gguisSKbKu6 shoxgLa6M6uE9Q2hj5K3ldmuSE5thbk9iFXw5kOpM4Sitcq/Q+HX1ED+yYBsWtrc+oEN BY/RY/o5YC+Ux6l3GFjlcvOGChJ/wsi79a5vmHTgVz8iF8izkYR4ff2Sn7CD5OMhNhon oIZr9pvsv/sKWB2b0v3Q+SOBWjsgOgfYPR3axAinpbjW8Pm0FK3UA6QqoL0RsuEBBeXi kNIm2UF9lgqvSX7sY1I+AwQAaXz6a920gETozlQxdxApW1PIo2EGlXaDA0tzCOJvpP7w eIMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FP8lB1/k"; spf=pass (google.com: domain of linux-kernel+bounces-14984-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14984-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id dz21-20020a0564021d5500b005569c453055si946108edb.9.2024.01.02.15.47.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 15:47:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-14984-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FP8lB1/k"; spf=pass (google.com: domain of linux-kernel+bounces-14984-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-14984-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 10F881F227CB for ; Tue, 2 Jan 2024 23:47:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DD1D817996; Tue, 2 Jan 2024 23:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FP8lB1/k" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 107AF17985; Tue, 2 Jan 2024 23:47:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61034C433C8; Tue, 2 Jan 2024 23:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704239232; bh=CZ2SLviVIOPK+w/RCmlYzrNM6ShsUO9iGFjmEfntgB0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=FP8lB1/kk6nY0Zr06Xne+pu4Q10+zqNFW7PN9ts5upxtbHxZpmExa3uDU4gsAXVJi 2gEgFVvquWlyL8SF2znEwyCuXWP28zgv7TceWoxRDiwRz1jr0RR1GMlbBYtC2zCI7C kYDyYA8Mgt0Drve6TyA2wLWel6hL2DjsD407tRdBOPloDGCaSBVl1coKRUzr+VPlvL 7EyTKnOgswXDWBfJjEZTsNmrRVRzwVyVWQdGZKPmpOYtmWVetAkFmEUaoJin57E+5d hVNNZCF/RwZ+njrDa7TFUfGG7/8D7F3BphXb3i/W6Ijopxd8cNN+IoZq9BTkhNUsYL kr1pRPVMNtjGA== Message-ID: <24c6c928b1714490360f534fe30c55df.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20231218-mbly-clk-v1-0-44ce54108f06@bootlin.com> <20231218-mbly-clk-v1-3-44ce54108f06@bootlin.com> Subject: Re: [PATCH 3/5] clk: eyeq5: add controller From: Stephen Boyd Cc: Vladimir Kondratiev , linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Tawfik Bayouk To: Conor Dooley , Gregory CLEMENT , Krzysztof Kozlowski , Michael Turquette , Rob Herring , Thomas Bogendoerfer , =?utf-8?q?Th=C3=A9o?= Lebrun Date: Tue, 02 Jan 2024 15:47:10 -0800 User-Agent: alot/0.10 Quoting Th=C3=A9o Lebrun (2023-12-27 08:30:20) >=20 > I went ahead with a V2, feeling it would be more productive to come up > with something and gather comments on concrete stuff. There were many > other things to address anyway. >=20 > I've addressed this point by declaring a dummy fixed-clock in the > devicetree that gets fed to the GIC timer. It is pretty much the same > thing as using `clock-frequency` which this specific clocksource uses > if `of_clk_get(node, 0)` fails. With the sent approach we have the > timer appear in the clock tree as a consumer. If the frequency is fixed then this seems fine to do always.