Received-SPF: pass (google.com: domain of linux-kernel+bounces-14988-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 2 Jan 2024 16:58:15 -0700
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: David Heidelberg <david@ixit.cz>, Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Manivannan Sadhasivam <mani@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: opp: switch inner and outer min/maxItems
 rules for opp-hz
Message-ID: <20240102235815.GA3700567-robh@kernel.org>
References: <20231229191038.247258-1-david@ixit.cz>
 <2c9e91c7-8588-4260-8f5d-22c822019f62@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2c9e91c7-8588-4260-8f5d-22c822019f62@linaro.org>

On Sat, Dec 30, 2023 at 03:17:21PM +0100, Krzysztof Kozlowski wrote:
> On 29/12/2023 20:10, David Heidelberg wrote:
> > Fixes issue as:
> > ```
> 
> Drop, it's not RST, but commit msg.
> 
> > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: opp-table: opp-200000000:opp-hz:0: [200000000, 0, 0, 150000000, 0, 0, 0, 0, 300000000] is too long
> > ```
> > 
> > Fixes: 3cb16ad69bef ("dt-bindings: opp: accept array of frequencies")
> > 
> > Signed-off-by: David Heidelberg <david@ixit.cz>
> > ---
> >  Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> > index e2f8f7af3cf4..86d3aa0eb435 100644
> > --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> > +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> > @@ -55,10 +55,9 @@ patternProperties:
> >            to relate the values to their clocks or the order in which the clocks
> >            need to be configured and that is left for the implementation
> >            specific binding.
> > -        minItems: 1
> > -        maxItems: 32
> >          items:
> > -          maxItems: 1
> > +          minItems: 1
> > +          maxItems: 32
> 
> This does not look like correct fix. The original code looked fine -
> only one item is allowed in each sub-element (array).

This one is special being 64-bit values so we have an exception in 
property-units.yaml. The constraints here don't get used in decoding the 
dtb and the default way of 1 outer element is used.

It doesn't look like opp-hz needs to be a matrix as it is really just an 
array. Perhaps it should just be changed to an array type. 
Alternatively, adding 'items: { maxItems: 1 }' to the definition in 
property-units.yaml fixes the issue as well.

Though we can fix this, I'm looking into if we have other cases where we 
need this to work as-is. There's probably some room for improvement in 
how matrix dimensions are handled.

Rob