Received-SPF: pass (google.com: domain of linux-kernel+bounces-15037-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 3 Jan 2024 12:27:34 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Dave Airlie <airlied@redhat.com>
Cc: DRI <dri-devel@lists.freedesktop.org>, Andrzej Hajda
 <andrzej.hajda@intel.com>, Linux Kernel Mailing List
 <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the drm tree
Message-ID: <20240103122734.16b29e09@canb.auug.org.au>
In-Reply-To: <20240103121911.4ec8f237@canb.auug.org.au>
References: <20240102111222.2db11208@canb.auug.org.au>
	<20240103121911.4ec8f237@canb.auug.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/mWzhyXl4eKqLAEr+LnzDcYY";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/mWzhyXl4eKqLAEr+LnzDcYY
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

On Wed, 3 Jan 2024 12:19:11 +1100 Stephen Rothwell <sfr@canb.auug.org.au> w=
rote:
>
> On Tue, 2 Jan 2024 11:12:22 +1100 Stephen Rothwell <sfr@canb.auug.org.au>=
 wrote:
> >
> > After merging the drm tree, today's linux-next build (x86_64 allmodconf=
ig)
> > produced this warning:
> >=20
> > In file included from include/drm/drm_mm.h:51,
> >                  from drivers/gpu/drm/xe/xe_bo_types.h:11,
> >                  from drivers/gpu/drm/xe/xe_bo.h:11,
> >                  from drivers/gpu/drm/xe/compat-i915-headers/gem/i915_g=
em_object.h:11,
> >                  from drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h=
:15,
> >                  from drivers/gpu/drm/i915/display/intel_display_power.=
c:8:
> > drivers/gpu/drm/i915/display/intel_display_power.c: In function 'print_=
async_put_domains_state':
> > drivers/gpu/drm/i915/display/intel_display_power.c:408:29: warning: for=
mat '%lu' expects argument of type 'long unsigned int', but argument 5 has =
type 'int' [-Wformat=3D]
> >   408 |         drm_dbg(&i915->drm, "async_put_wakeref %lu\n",
> >       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~
> >   409 |                 power_domains->async_put_wakeref);
> >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >       |                              |
> >       |                              int
> >=20
>
> In file included from include/drm/ttm/ttm_resource.h:34,
>                  from include/drm/ttm/ttm_device.h:30,
>                  from drivers/gpu/drm/i915/i915_drv.h:37,
>                  from drivers/gpu/drm/i915/display/intel_display_power.c:=
8: =20
> drivers/gpu/drm/i915/display/intel_display_power.c: In function 'print_as=
ync_put_domains_state':
> drivers/gpu/drm/i915/display/intel_display_power.c:408:29: error: format =
'%u' expects argument of type 'unsigned int', but argument 5 has type 'inte=
l_wakeref_t' {aka 'long unsigned int'} [-Werror=3Dformat=3D]
>   408 |         drm_dbg(&i915->drm, "async_put_wakeref %u\n",
>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~
>   409 |                 power_domains->async_put_wakeref);
>       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                              |
>       |                              intel_wakeref_t {aka long unsigned i=
nt}
>=20
> I don't understand how the above patch can change the compilation like
> that.  I must be missing something obvious.  Maybe my compiler is
> strangely broken?

OK, the only thing I can find is that there are 2 intel_wakeref.h files
that have different definitions for intel_wakeref_t:

./drivers/gpu/drm/i915/intel_wakeref.h:typedef unsigned long intel_wakeref_=
t;
./drivers/gpu/drm/xe/compat-i915-headers/intel_wakeref.h:typedef bool intel=
_wakeref_t;

and the two compilations above seem to use different include paths, but
how the single character change causes that is beyond me.
--=20
Cheers,
Stephen Rothwell

--Sig_/mWzhyXl4eKqLAEr+LnzDcYY
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmWUuAYACgkQAVBC80lX
0GzqGggApfYV/oSvb4o1uSyi6JfdCPy2T1rN/bO5A7JxQLPkaClTa9dhLP3FdI2c
CjqYziggHdybTtasqbdkQcYfxeCEbm3020sCO0oCkhcK37J871SPJPk0SAlvp1pv
Y315uuFb6fDURfPIs6YDmNfCTYc3qPNdYLOMsMKlRnFJrpea8iJ7uDwsV7qrkOP7
yAPUzS5NI6ekp2MrZyE+SMupjGUUsktSjZdntYejg4ie++v04GnH/+/v6Vi1mDtv
00M8OC6tLvTH+R+dpqi/NRXBye1aJ3CJOiY1S1klQ4PYhGBMKcP4UkRsntOjbPP5
7pjWhOYJ+QNr/o/KNvK2eCuAVCqlEQ==
=6LLK
-----END PGP SIGNATURE-----

--Sig_/mWzhyXl4eKqLAEr+LnzDcYY--