Received-SPF: pass (google.com: domain of linux-kernel+bounces-15087-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 2 Jan 2024 21:46:38 -0500
From: Gregory Price <gregory.price@memverge.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Gregory Price <gourry.memverge@gmail.com>, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	x86@kernel.org, akpm@linux-foundation.org, arnd@arndb.de,
	tglx@linutronix.de, luto@kernel.org, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, mhocko@kernel.org,
	tj@kernel.org, corbet@lwn.net, rakie.kim@sk.com,
	hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com,
	peterz@infradead.org, jgroves@micron.com, ravis.opensrc@micron.com,
	sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com,
	seungjun.ha@samsung.com
Subject: Re: [PATCH v5 01/11] mm/mempolicy: implement the sysfs-based
 weighted_interleave interface
Message-ID: <ZZTKjn3kngYPYXo0@memverge.com>
References: <20231223181101.1954-1-gregory.price@memverge.com>
 <20231223181101.1954-2-gregory.price@memverge.com>
 <877cl0f8oo.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <ZYp3JbcCPQc4fUrB@memverge.com>
 <87h6jwdvxn.fsf@yhuang6-desk2.ccr.corp.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87h6jwdvxn.fsf@yhuang6-desk2.ccr.corp.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VqogLsjiCk2qnKiB1YtVyxkzuTcEaT8B1pa/JYsGIYG+4ealg6zNu3ibFIuM?=
 =?us-ascii?Q?FmTPBOpm52Ow4iaac+XI+YXubtCExosqR2CvwE2gat1UMsoF4ED2obmE3rHQ?=
 =?us-ascii?Q?SWk09i7ARKuMl2SdHvl2W0LXB5rig91HCe0C8I3E2KnVCLtvsmOMaPOox5hC?=
 =?us-ascii?Q?Y/hOMiz3vlrA6LS4rF0Gc7cgOuqqZyYfhg1R9wQ2APnI17u9svwDFWq8Yptm?=
 =?us-ascii?Q?iKuWaew/noPy+PAAdklCZjF71Wfpv30NqgM+LXYB0dBAO7cBtLitCLsnuw+w?=
 =?us-ascii?Q?JRBZjQI9fPG7rkX0kTG8Rw394LIzVFZUoO62LZF9llS4KnhM5px0kvbOtGr7?=
 =?us-ascii?Q?Y+hsaZEnLbTd3wGab3uy1VYCTAdWaR3bdk8agFSEmAa+wBURzBDuG0YCxC7h?=
 =?us-ascii?Q?1NXwl6VTKy96TOY0CJlRvi5l3jd7htn5QOxHc1HzD1YFaQiao9OcN+iX8SRJ?=
 =?us-ascii?Q?JbacBf9RKQ4dcx0awtQq50bdBM/f/ir//V8zOSI2xqWzN/8iuaC0Fhccen7x?=
 =?us-ascii?Q?p1ZWfCmRWjtO1Xn1LzbIjeqNnQTDp6QDNQG7esSAguYQsmq40vjINAmBPabY?=
 =?us-ascii?Q?r2uA7ScYzmeLs4sfeLyYm07nxJf7fluPBASaPdhlSV0byGTTEkEUumQdzfXp?=
 =?us-ascii?Q?2/ONhWsgqRzb48YO9bIWi0GBH13ft8kMD5udkJqNliEn5NbRWe3ojs5TeVdE?=
 =?us-ascii?Q?y7GshFQ/aqp9so96I5ONPAKCUJLspKaAvG0C3QPaOfAzDKpsiZEBiABg+Kgc?=
 =?us-ascii?Q?iarka/NTITIj+eVmfXEiFUvNIXD2Bl+77FN9LFSnLVEwDB3ujOxnGVpIf5wc?=
 =?us-ascii?Q?AigAoC7/+xpIhlNa+Qb1OTlYfB7lLa2LRjPyKFiYmRZm/JnC29VGxSlIYQJg?=
 =?us-ascii?Q?Daz/tutIZRY9l+f8j4yWaMPYrMz2pFlFgaWIiH4nLWklxvZ5rePtcO1IwcMO?=
 =?us-ascii?Q?izuweh36UzdDpzyJltcPaDJArMoLOOZ1OEb+2LVRBT6o3r/FWET06ThTZUA3?=
 =?us-ascii?Q?KiAXKBEKLPE4GhtoUgUxma06C4qP4jCUvSjUJ6dXpnSz2zvUGeIGultU87SL?=
 =?us-ascii?Q?h/8AX1jSfcfKph0V5jVadxedLfCKjz6fNGBzKpV2I9NwfxWS8FE3mIkP/Unj?=
 =?us-ascii?Q?k+qOdTgjWH9W4yZzBxzAvd/y2C2G6WYloKp/+3/IDWBWALbXak7T3Gqu2VUj?=
 =?us-ascii?Q?37Tm1HLwkjY4N1kE8uEGu80uj/TX9PBZsS7n0WAAVLbxmrOt3Uf4pOjhn7Zd?=
 =?us-ascii?Q?rFJcYB13qD1/im6sVo23iE3b1Pw2qw9zeyqMAPiX4/roS+jlbVXXcOnI/BN0?=
 =?us-ascii?Q?9dbbBP3kITt6f2QzjVO0wiRgU1c2oQxH6K7UHwhWj8wIeTlDmeRy1ld9gVxH?=
 =?us-ascii?Q?Q9GlcxwtZxqDgiWCo/oomtqkvu92Oyg7bWM+J7E9peJqBmfwim89qFiLOkAj?=
 =?us-ascii?Q?MEtA5pUTDgOLdReaEQYLkyqP+intOEKYTiCM5dNNbk+95pKfricw1B1g98uv?=
 =?us-ascii?Q?LSPFQq/s2V93uoTtyykGi6Y5tywZzXvCtYm8VH8WNNAGw4mnV13yzNlPmfaW?=
 =?us-ascii?Q?rmChVyVpkfdXl98iYlZDlQbjkRzAHOWx/CFdfCYXVeWQPnFPSS3ugPy+m3TL?=
 =?us-ascii?Q?Uw=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3baadcf-84ab-4071-7f4a-08dc0c063b14
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 02:46:48.2370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lJQhAfnQRNInSCiB6D3W6Vshr0rHpCA19HGR/I8VUasX1RODI4hW98pt9PK37a+5uJRUBgnCDU3IWRHjGwy1IjnBBEQp8EHXizh15m8t8FE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR17MB6563

On Tue, Jan 02, 2024 at 03:41:08PM +0800, Huang, Ying wrote:
> Think about the default weight value via HMAT/CDAT again.  It may be not
> a good idea to use "1" as default even for now.
> 
> For example,
> 
> - The memory bandwidth of DRAM is 100GB, whose default weight is "1".
> 
> - We hot-plug CXL.mem A with memory bandwidth 20GB.  So, we change the
>   weight of DRAM to 5, and use "1" as the weight of CXL.mem A.
> 
> - We hot-plug CXL.mem B with memory bandwidth 10GB.  So, we change the
>   weight of DRAM to 10, the weight of CXL.mem A to 2, and use "1" as the
>   weight of CXL.mem B.
> 
> That is, if we use "1" as default weight, we need to change weights of
> nodes frequently because we haven't a "base" weight.  The best candidate
> base weight is the weight of DRAM node.  For example, if we set the
> default weight of DRAM node to be "16" and use that as the base weight,
> we don't need to change it in most cases.  The weight of other nodes can
> be set according to the ratio of its memory bandwidth to that of DRAM.
> 
> This makes it easy to set the default weight via HMAT/CDAT too.
> 
> What do you think about that?
> 

Giving this more thought.

Hotplug should be an incredibly rare event. I don't think swapping defaults
"frequently" is a real problem we should handle.

It's expected that dynamic capacity devices will not cause a node to
hotplug, but instead cause a node to grow/shrink.

Seems perfectly fine to rebalance weights in response to rare events.

~Gregory